Renamed cost allocation tags to cost tags and added schema for get list of all available tag keys #2862

asarkar84 · 2018-04-12T20:17:00Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Added Tags filter for budgets and updated the api version

Updated comments

Incorporated review comments

Incorporated review comment

Added Tags filter and grouping for UsageDetails

Added reservation recommendations and tags

Incorporated review comments

Removed unwanted space

Removed extra whitespace

Added schema spec for cost allocation tags

Updated Get Operation

Incorporated review comments

Review comments incorporated

Updated path

…st of all available tag keys Renamed cost allocation tags to cost tags and added schema for get list of all available tag keys

AutorestCI · 2018-04-12T20:17:34Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-04-12T20:18:16Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2158

AutorestCI · 2018-04-12T20:18:36Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2700

AutorestCI · 2018-04-12T20:23:28Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1612

asarkar84 · 2018-04-12T20:33:25Z

@jianghaolu Please take a look. Thanks!

jianghaolu · 2018-04-12T20:35:14Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-03-31/consumption.json

@@ -1868,6 +1907,43 @@
        }
      }
    },
+    "Tags": {
+      "description": "A tag resource.",


Please put in more detailed descriptions. This is easily confused with "Tag".

You might even consider renaming this to "TagResource".

I have updated the description. Please take a look if the changes are fine.

jianghaolu · 2018-04-12T20:36:49Z

...tion/consumption/resource-manager/Microsoft.Consumption/stable/2018-03-31/examples/Tags.json

+        "type": "Microsoft.Consumption/tags",
+        "eTag": "\"1d34d012214157f\"",
+        "properties": {
+          "tags": [


The property name here should be "costTags", as defined in TagProperties.

Thank you! for mentioning this. Actually it was wrong at the other place. I am corrected it there.

Incorporated review comments

jianghaolu · 2018-04-12T21:41:30Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-03-31/consumption.json

+      "description": "The properties of the tag.",
+      "properties": {
+        "tags": {
+          "description": "Tags.",


One more thing : Please avoid using property name as the description. Try to add a little more info :)

Sure! I have made the changes. Will keep this in mind for future as well.

Incorporated review comments

azuresdkciprbot · 2018-04-12T22:46:32Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/consumption/resource-manager/readme.md
Before the PR: Warning(s): 10 Error(s): 0
After the PR: Warning(s): 11 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-12T23:02:01Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/consumption/resource-manager/readme.md
Before the PR: Warning(s): 10 Error(s): 0
After the PR: Warning(s): 11 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jianghaolu · 2018-04-13T22:10:58Z

Per offline discussion - this is a breaking change but 4/13/18 is when the service is first deployed. So this is accepted for now and no future breaking changes will be allowed to this spec.

jhendrixMSFT · 2018-04-16T21:24:12Z

@AutorestCI regenerate azure-sdk-for-go

asarkar84 and others added 25 commits March 8, 2018 15:44

Added Tags filter for budgets and updated the api version

7b927cf

Added Tags filter for budgets and updated the api version

Updated comments

c641158

Updated comments

Incorporated review comments

0e276b2

Incorporated review comments

Incorporated review comments

7be4364

Incorporated review comments

Incorporated review comment

bff7aa7

Incorporated review comment

Merge remote-tracking branch 'upstream/master'

011c9f0

Added Tags filter and grouping for UsageDetails

002a6db

Added Tags filter and grouping for UsageDetails

Merge remote-tracking branch 'upstream/master'

020911c

Added reservation recommendations and tags

502d70e

Added reservation recommendations and tags

Merge remote-tracking branch 'upstream/master'

b41bd12

Incorporated review comments

7956270

Incorporated review comments

Incorporated review comments

346ce83

Incorporated review comments

Removed unwanted space

a0072f9

Removed unwanted space

Removed extra whitespace

ee9bfc3

Removed extra whitespace

add swagger->sdk config for go

6df7a9e

fix broken tags for go

7a5eab1

Merge remote-tracking branch 'upstream/master'

623ff00

Added schema spec for cost allocation tags

6388784

Added schema spec for cost allocation tags

Merge remote-tracking branch 'upstream/master'

a8d47d1

Updated Get Operation

3ccf1b4

Updated Get Operation

Incorporated review comments

884aabe

Incorporated review comments

Review comments incorporated

3d1c7c1

Review comments incorporated

Updated path

def6325

Updated path

Merge remote-tracking branch 'upstream/master'

ef019c5

Renamed cost allocation tags to cost tags and added schema for get li…

1f2de0f

…st of all available tag keys Renamed cost allocation tags to cost tags and added schema for get list of all available tag keys

azuresdkci assigned jianghaolu Apr 12, 2018

azuresdkci requested a review from jianghaolu April 12, 2018 20:17

AutorestCI mentioned this pull request Apr 12, 2018

[AutoPR consumption/resource-manager] Renamed cost allocation tags to cost tags and added schema for get list of all available tag keys Azure/azure-sdk-for-python#2389

Merged

jianghaolu suggested changes Apr 12, 2018

View reviewed changes

asarkar84 added 2 commits April 12, 2018 14:27

Incorporated review comments

5699a84

Incorporated review comments

Incorporated review comments

3bd6450

Incorporated review comments

jianghaolu reviewed Apr 12, 2018

View reviewed changes

Incorporated review comments

7f53393

Incorporated review comments

jianghaolu approved these changes Apr 13, 2018

View reviewed changes

jianghaolu merged commit b9da36a into Azure:master Apr 13, 2018

AutorestCI mentioned this pull request Apr 16, 2018

[AutoPR consumption/resource-manager] Renamed cost allocation tags to cost tags and added schema for get list of all available tag keys Azure/azure-sdk-for-go#1611

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renamed cost allocation tags to cost tags and added schema for get list of all available tag keys #2862

Renamed cost allocation tags to cost tags and added schema for get list of all available tag keys #2862

asarkar84 commented Apr 12, 2018 •

edited

Loading

AutorestCI commented Apr 12, 2018 •

edited

Loading

AutorestCI commented Apr 12, 2018 •

edited

Loading

AutorestCI commented Apr 12, 2018 •

edited

Loading

AutorestCI commented Apr 12, 2018 •

edited

Loading

asarkar84 commented Apr 12, 2018

jianghaolu Apr 12, 2018

jianghaolu Apr 12, 2018

asarkar84 Apr 12, 2018

jianghaolu Apr 12, 2018

asarkar84 Apr 12, 2018

jianghaolu Apr 12, 2018

asarkar84 Apr 12, 2018 •

edited

Loading

azuresdkciprbot commented Apr 12, 2018

azuresdkciprbot commented Apr 12, 2018

jianghaolu commented Apr 13, 2018

jhendrixMSFT commented Apr 16, 2018

Renamed cost allocation tags to cost tags and added schema for get list of all available tag keys #2862

Renamed cost allocation tags to cost tags and added schema for get list of all available tag keys #2862

Conversation

asarkar84 commented Apr 12, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Apr 12, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 12, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 12, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Apr 12, 2018 • edited Loading

Automation for azure-sdk-for-go

asarkar84 commented Apr 12, 2018

jianghaolu Apr 12, 2018

Choose a reason for hiding this comment

jianghaolu Apr 12, 2018

Choose a reason for hiding this comment

asarkar84 Apr 12, 2018

Choose a reason for hiding this comment

jianghaolu Apr 12, 2018

Choose a reason for hiding this comment

asarkar84 Apr 12, 2018

Choose a reason for hiding this comment

jianghaolu Apr 12, 2018

Choose a reason for hiding this comment

asarkar84 Apr 12, 2018 • edited Loading

Choose a reason for hiding this comment

azuresdkciprbot commented Apr 12, 2018

azuresdkciprbot commented Apr 12, 2018

jianghaolu commented Apr 13, 2018

jhendrixMSFT commented Apr 16, 2018

asarkar84 commented Apr 12, 2018 •

edited

Loading

AutorestCI commented Apr 12, 2018 •

edited

Loading

AutorestCI commented Apr 12, 2018 •

edited

Loading

AutorestCI commented Apr 12, 2018 •

edited

Loading

AutorestCI commented Apr 12, 2018 •

edited

Loading

asarkar84 Apr 12, 2018 •

edited

Loading