Add DestinationIPAddress to Private Link Service #29833

wdehrich · 2024-07-15T19:29:01Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…cribe. Node name:'destinationIPAddress' Description:'DestinationIPAddress Location: Microsoft.Network/stable/2024-03-01/privateLinkService.json#L813

openapi-pipeline-app · 2024-07-15T19:29:04Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-07-15T19:29:05Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌ azure-sdk-for-net failed [Detail]

FAQ

❌Pipeline Framework Failed in generating from 4479c4e95f2f497ac6bd0fdf13a13b7fc16a63d8. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
To https://github.com/azure-sdk/azure-sdk-for-net!	refs/heads/main:refs/heads/main	[remote rejected] (protected branch hook declined)DonePushing to https://github.com/azure-sdk/azure-sdk-for-netPOST git-receive-pack (chunked)remote: error: GH006: Protected branch update failed for refs/heads/main.        remote: error: Cannot force-push to this branch        error: failed to push some refs to 'https://github.com/azure-sdk/azure-sdk-for-net'
error	GenerationError: The following packages are still pending.
error		Microsoft.Azure.Management.Network

️✔️Microsoft.Azure.Management.Network

error	FatalError: To https://github.com/azure-sdk/azure-sdk-for-net!	refs/heads/main:refs/heads/main	[remote rejected] (protected branch hook declined)DonePushing to https://github.com/azure-sdk/azure-sdk-for-netPOST git-receive-pack (chunked)remote: error: GH006: Protected branch update failed for refs/heads/main.        remote: error: Cannot force-push to this branch        error: failed to push some refs to 'https://github.com/azure-sdk/azure-sdk-for-net'. Please refer to the inner logs for details or report this issue through https://aka.ms/azsdk/support/specreview-channel.
error	ErrorStack: Error: To https://github.com/azure-sdk/azure-sdk-for-net!	refs/heads/main:refs/heads/main	[remote rejected] (protected branch hook declined)DonePushing to https://github.com/azure-sdk/azure-sdk-for-netPOST git-receive-pack (chunked)remote: error: GH006: Protected branch update failed for refs/heads/main.        remote: error: Cannot force-push to this branch        error: failed to push some refs to 'https://github.com/azure-sdk/azure-sdk-for-net'    at Object.action (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1451:25)    at PluginStore.exec (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1500:29)    at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1927:43    at new Promise (<anonymous>)    at GitExecutorChain.handleTaskData (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1925:16)    at GitExecutorChain.<anonymous> (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1909:44)    at Generator.next (<anonymous>)    at fulfilled (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:52:24)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5).
error	GenerationError: The following packages are still pending.
error		Microsoft.Azure.Management.Network

️❌ azure-sdk-for-net-track2 failed [Detail]

FAQ

❌Pipeline Framework Failed in generating from 4479c4e95f2f497ac6bd0fdf13a13b7fc16a63d8. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
To https://github.com/azure-sdk/azure-sdk-for-net!	refs/heads/main:refs/heads/main	[remote rejected] (protected branch hook declined)DonePushing to https://github.com/azure-sdk/azure-sdk-for-netPOST git-receive-pack (chunked)remote: error: GH006: Protected branch update failed for refs/heads/main.        remote: error: Cannot force-push to this branch        error: failed to push some refs to 'https://github.com/azure-sdk/azure-sdk-for-net'
error	GenerationError: The following packages are still pending.
error		Azure.ResourceManager.Network

️✔️Azure.ResourceManager.Network

error	FatalError: To https://github.com/azure-sdk/azure-sdk-for-net!	refs/heads/main:refs/heads/main	[remote rejected] (protected branch hook declined)DonePushing to https://github.com/azure-sdk/azure-sdk-for-netPOST git-receive-pack (chunked)remote: error: GH006: Protected branch update failed for refs/heads/main.        remote: error: Cannot force-push to this branch        error: failed to push some refs to 'https://github.com/azure-sdk/azure-sdk-for-net'. Please refer to the inner logs for details or report this issue through https://aka.ms/azsdk/support/specreview-channel.
error	ErrorStack: Error: To https://github.com/azure-sdk/azure-sdk-for-net!	refs/heads/main:refs/heads/main	[remote rejected] (protected branch hook declined)DonePushing to https://github.com/azure-sdk/azure-sdk-for-netPOST git-receive-pack (chunked)remote: error: GH006: Protected branch update failed for refs/heads/main.        remote: error: Cannot force-push to this branch        error: failed to push some refs to 'https://github.com/azure-sdk/azure-sdk-for-net'    at Object.action (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1451:25)    at PluginStore.exec (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1500:29)    at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1927:43    at new Promise (<anonymous>)    at GitExecutorChain.handleTaskData (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1925:16)    at GitExecutorChain.<anonymous> (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1909:44)    at Generator.next (<anonymous>)    at fulfilled (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:52:24)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5).
error	GenerationError: The following packages are still pending.
error		Azure.ResourceManager.Network

️🔄 azure-sdk-for-python inProgress [Detail]

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 4479c4e95f2f497ac6bd0fdf13a13b7fc16a63d8. SDK Automation 14.0.0

command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [Preview SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 4479c4e95f2f497ac6bd0fdf13a13b7fc16a63d8. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `FirewallPacketCaptureParametersFormat` has been removed
info	[Changelog] - Field `ID`, `Properties` of struct `FirewallPacketCaptureParameters` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `BastionHostSKUNamePremium` added to enum type `BastionHostSKUName`
info	[Changelog] - New enum type `PrivateEndpointVNetPolicies` with values `PrivateEndpointVNetPoliciesBasic`, `PrivateEndpointVNetPoliciesDisabled`
info	[Changelog] - New enum type `ProbeNoHealthyBackendsBehavior` with values `ProbeNoHealthyBackendsBehaviorAllProbedDown`, `ProbeNoHealthyBackendsBehaviorAllProbedUp`
info	[Changelog] - New enum type `ResiliencyModel` with values `ResiliencyModelMultiHomed`, `ResiliencyModelSingleHomed`
info	[Changelog] - New function `*InboundSecurityRuleClient.Get(context.Context, string, string, string, *InboundSecurityRuleClientGetOptions) (InboundSecurityRuleClientGetResponse, error)`
info	[Changelog] - New field `ConnectionResourceURI` in struct `AuthorizationPropertiesFormat`
info	[Changelog] - New field `EnableSessionRecording` in struct `BastionHostPropertiesFormat`
info	[Changelog] - New field `Filter` in struct `ExpressRouteCrossConnectionsClientListOptions`
info	[Changelog] - New field `DurationInSeconds`, `FileName`, `Filters`, `Flags`, `NumberOfPacketsToCapture`, `Protocol`, `SasURL` in struct `FirewallPacketCaptureParameters`
info	[Changelog] - New field `Identity` in struct `FlowLog`
info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
info	[Changelog] - New field `EnabledFilteringCriteria` in struct `FlowLogProperties`
info	[Changelog] - New field `EnabledFilteringCriteria` in struct `FlowLogPropertiesFormat`
info	[Changelog] - New field `DestinationIPAddress` in struct `PrivateLinkServiceProperties`
info	[Changelog] - New field `NoHealthyBackendsBehavior` in struct `ProbePropertiesFormat`
info	[Changelog] - New field `NetworkIdentifier` in struct `ServiceEndpointPropertiesFormat`
info	[Changelog] - New field `Identity` in struct `VirtualNetworkGateway`
info	[Changelog] - New field `ResiliencyModel` in struct `VirtualNetworkGatewayPropertiesFormat`
info	[Changelog] - New field `PrivateEndpointVNetPolicies` in struct `VirtualNetworkPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 25 additive change(s).

Present SDK breaking changes suppressions
Field `ID`, `Properties` of struct `FirewallPacketCaptureParameters` has been removed
Struct `FirewallPacketCaptureParametersFormat` has been removed

Please refer to the guidance for suppressing SDK breaking changes.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 4479c4e95f2f497ac6bd0fdf13a13b7fc16a63d8. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [Preview SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation InboundSecurityRuleOperations.get
info	[Changelog]   - Added Interface ExpressRoutePortAuthorizationsDeleteHeaders
info	[Changelog]   - Added Interface ExpressRoutePortsDeleteHeaders
info	[Changelog]   - Added Interface InboundSecurityRuleGetOptionalParams
info	[Changelog]   - Added Interface RouteFilterRulesDeleteHeaders
info	[Changelog]   - Added Interface RouteFiltersDeleteHeaders
info	[Changelog]   - Added Type Alias InboundSecurityRuleGetResponse
info	[Changelog]   - Added Type Alias PrivateEndpointVNetPolicies
info	[Changelog]   - Added Type Alias ProbeNoHealthyBackendsBehavior
info	[Changelog]   - Added Type Alias ResiliencyModel
info	[Changelog]   - Interface BastionHost has a new optional parameter enableSessionRecording
info	[Changelog]   - Interface ExpressRouteCircuitAuthorization has a new optional parameter connectionResourceUri
info	[Changelog]   - Interface ExpressRouteCrossConnectionsListOptionalParams has a new optional parameter filter
info	[Changelog]   - Interface FlowLog has a new optional parameter enabledFilteringCriteria
info	[Changelog]   - Interface FlowLog has a new optional parameter identity
info	[Changelog]   - Interface FlowLogInformation has a new optional parameter enabledFilteringCriteria
info	[Changelog]   - Interface FlowLogInformation has a new optional parameter identity
info	[Changelog]   - Interface PrivateLinkService has a new optional parameter destinationIPAddress
info	[Changelog]   - Interface Probe has a new optional parameter noHealthyBackendsBehavior
info	[Changelog]   - Interface ServiceEndpointPropertiesFormat has a new optional parameter networkIdentifier
info	[Changelog]   - Interface VirtualNetwork has a new optional parameter privateEndpointVNetPolicies
info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter identity
info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter resiliencyModel
info	[Changelog]   - Added Enum KnownPrivateEndpointVNetPolicies
info	[Changelog]   - Added Enum KnownProbeNoHealthyBackendsBehavior
info	[Changelog]   - Added Enum KnownResiliencyModel
info	[Changelog]   - Enum KnownBastionHostSkuName has a new value Premium

️❌ azure-resource-manager-schemas failed [Detail]

FAQ

❌Code Generator Failed in generating from 4479c4e95f2f497ac6bd0fdf13a13b7fc16a63d8. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.

️⚠️ azure-powershell warning [Detail]

FAQ

⚠️Warning in generating from 4479c4e95f2f497ac6bd0fdf13a13b7fc16a63d8. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.network.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-07-15T19:29:05Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/1b263a329090477991c0a7b7b0ae21d7?revisionId=5992e5a736394303aa72d1fc220ebb87
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/d496e631581f47bcab5c961219fc2258?revisionId=e16283649da04f67a3658fa4fbf44e8d
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=c928aad2fb1a4ac1b32a5ce4896c0d8f

raosuhas · 2024-07-18T20:21:19Z

/azp run

azure-pipelines · 2024-07-18T20:21:34Z

Azure Pipelines successfully started running 3 pipeline(s).

wdehrich · 2024-07-20T16:15:28Z

/pr RequestMerge

* Add new properties * Prettier * Description must not match the name of the node it is supposed to describe. Node name:'destinationIPAddress' Description:'DestinationIPAddress Location: Microsoft.Network/stable/2024-03-01/privateLinkService.json#L813 * Update description of destination IP address * privateEndpointVNetPolicies should not be read-only * Revert change to virtual network * Fix --------- Co-authored-by: Will Ehrich <[email protected]>

Will Ehrich added 7 commits July 9, 2024 14:17

Add new properties

f30ca81

Prettier

519536a

Description must not match the name of the node it is supposed to des…

231576e

…cribe. Node name:'destinationIPAddress' Description:'DestinationIPAddress Location: Microsoft.Network/stable/2024-03-01/privateLinkService.json#L813

Update description of destination IP address

aef7885

privateEndpointVNetPolicies should not be read-only

2d8e599

Revert change to virtual network

a2e73a0

Fix

c654ac4

wdehrich requested a review from GuptaVertika as a code owner July 15, 2024 19:29

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 15, 2024

This was referenced Jul 15, 2024

[AutoPR Azure.ResourceManager.Network] Add DestinationIPAddress to Private Link Service azure-sdk/azure-sdk-for-net#8453

Closed

[AutoPR Microsoft.Azure.Management.Network] Add DestinationIPAddress to Private Link Service azure-sdk/azure-sdk-for-net#8454

Closed

raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 18, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2024

microsoft-github-policy-service bot added the MergeRequested label Jul 20, 2024

razvanbadea-msft merged commit 737d160 into Azure:guptavertika/release-network-Microsoft.Network-2024-03-01 Jul 22, 2024
22 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DestinationIPAddress to Private Link Service #29833

Add DestinationIPAddress to Private Link Service #29833

wdehrich commented Jul 15, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 15, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 15, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 15, 2024 •

edited

Loading

raosuhas commented Jul 18, 2024

azure-pipelines bot commented Jul 18, 2024

wdehrich commented Jul 20, 2024

Add DestinationIPAddress to Private Link Service #29833

Add DestinationIPAddress to Private Link Service #29833

Conversation

wdehrich commented Jul 15, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Jul 15, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Jul 15, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Jul 15, 2024 • edited Loading

Generated ApiView

raosuhas commented Jul 18, 2024

azure-pipelines bot commented Jul 18, 2024

wdehrich commented Jul 20, 2024

wdehrich commented Jul 15, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 15, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 15, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jul 15, 2024 •

edited

Loading