[Reviewed in priv repo] adding ipam, vnv and sec admin for 2024-01-01 preview

[sssharma24]

…ed in priv repo

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

• New resource provider.
• New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
• Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
• Update existing version to fix OpenAPI spec quality issues in S360.
• Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
• Other, please clarify:
  • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

• I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
• I have reviewed following Resource Provider guidelines, including
  ARM resource provider contract and
  REST guidelines (estimated time: 4 hours).
  I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

• First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
• If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
• To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
• For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
  and https://aka.ms/ci-fix.
• For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
• If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
  This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
• If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

[openapi-pipeline-app]

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/1b263a329090477991c0a7b7b0ae21d7?revisionId=ee4e4d2c207c467db3aa1f2fef6a47ba
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/d496e631581f47bcab5c961219fc2258?revisionId=20409fc6aea147a68ef9c14380fb2fb5
JavaScript	@azure/arm-network	There is no API change compared with the previous version
.Net	Azure.ResourceManager.Network	There is no API change compared with the previous version

[sssharma24]

New API changes have already been reviewed and approved by ARM team including the breaking changes and suppressions required during preview version: https://github.com/Azure/azure-rest-api-specs-pr/pull/17956. This PR adds the same swagger specs to stable version.

[ms-bogdan-rotaru]

@sssharma24 There are still failing checks, hence cannot merge the PR.

[sssharma24]

@sssharma24 There are still failing checks, hence cannot merge the PR.

Swagger LintDiff issue for BodyTopLevelProperties failures seem to be related to the issue Azure/azure-openapi-validator#722. Can we apply suppression for these failures?

[ms-bogdan-rotaru]

@sssharma24 Cannot merge, 1 pending required reviewer is needed to approve the changes.

[sssharma24]

@sssharma24 Cannot merge, 1 pending required reviewer is needed to approve the changes.

@markcowl could you please approve

[ms-bogdan-rotaru]

@sssharma24 The branch is out-of-date and cannot be merged currently.

[ms-bogdan-rotaru]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[rkmanda]

Pl get this approval and request a merge - #29998 (comment)

[raych1]

This tag doesn't exist anymore. Can you update it to package-2024-01-preview either?

[sssharma24]

changing the tag is causing Avocado errors stating we have MISSING_APIS_IN_DEFAULT_TAG

[sssharma24]

package-2024-01 is the latest stable, so I don't think that's the issue reverting back to package-2024-01. example PR for when we merged an old preview version 18ebda8#diff-06b33c899bdfd2b8060eff3b065641a8f1b0ac7a8188d896d9cc2965ddfb22fe

[raych1]

The problem is package-2024-01 tag definition doesn't exist in the readme.md that cause the input file cannot be found while generating the SDK.