Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a sample ARM sample project based on standard template #30040

Merged
merged 17 commits into from
Aug 2, 2024
Merged

Creating a sample ARM sample project based on standard template #30040

merged 17 commits into from
Aug 2, 2024

Conversation

allenjzhang
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 31, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 31, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/contoso/armcontoso https://apiview.dev/Assemblies/Review/19034274c42f494b900a3f8af06c5461?revisionId=e8a84ba6738e4103ab11ad8882c47c9a
Java azure-resourcemanager-contoso https://apiview.dev/Assemblies/Review/f958535e0c7e4c1e85a46c1363c6e2bb?revisionId=31975cfea51f463e9d2029e70f210963
JavaScript @azure/arm-contoso https://apiview.dev/Assemblies/Review/7667e852608e438dbcca91be6fd43b63?revisionId=0f6b4bc2f178485abcd392418aa5a7c8
Swagger Microsoft.Contoso https://apiview.dev/Assemblies/Review/7ced84594b0a41aab472ddec0faf7689?revisionId=35183560f3e0467a92fb882f6f219d10
TypeSpec Contoso.Management https://apiview.dev/Assemblies/Review/0fb8a03ff8c348308ed5dc7cce897b08?revisionId=da0da91d904e4be6b41e1e75edd2bea6

@allenjzhang allenjzhang added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review RPaaSException https://github.com/Azure/azure-sdk-tools/issues/5311#issue-1567009479 labels Jul 31, 2024
markcowl
markcowl approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might add a readme.md in the appropriate location to pass the avocado check. Otherwise, LGTM

@azure-sdk azure-sdk mentioned this pull request Aug 1, 2024
Closed
This was referenced Aug 1, 2024
Closed
Closed
Closed
Closed
@raych1
Copy link
Member

raych1 commented Aug 1, 2024

The lint failures are false positive. This is the tracking issue in tool repo: Azure/azure-openapi-validator#722

qiaozha
qiaozha approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the arm resource patch template, the JS part looks good to me now.

@azure-sdk azure-sdk mentioned this pull request Aug 1, 2024
Closed
@raych1
Copy link
Member

raych1 commented Aug 2, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@qiaozha qiaozha merged commit c4b3316 into Azure:main Aug 2, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe left review comments

@qiaozha qiaozha qiaozha approved these changes

@markcowl markcowl markcowl approved these changes

@live1206 live1206 live1206 approved these changes

@raych1 raych1 raych1 approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@msyyc msyyc msyyc approved these changes

@tadelesh tadelesh Awaiting requested review from tadelesh

Assignees
No one assigned
Labels
Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-NewRPNamespaceWithoutRPaaS new-api-version new-rp-namespace resource-manager RPaaSException https://github.com/Azure/azure-sdk-tools/issues/5311#issue-1567009479 TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@allenjzhang @raych1 @markcowl @live1206 @lirenhe @weidongxu-microsoft @qiaozha @msyyc @AzureRestAPISpecReview @kazrael2119