Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVNM NSG + UDR Management Swagger changes for stable version #30102

Conversation

jbgorthy
Copy link
Contributor

@jbgorthy jbgorthy commented Aug 7, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Aug 7, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@jbgorthy
Copy link
Contributor Author

jbgorthy commented Aug 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jbgorthy
Copy link
Contributor Author

jbgorthy commented Aug 7, 2024

This pr is a copy/paste of two PRs that have already been approved in the private specs repo:
https://github.com/Azure/azure-rest-api-specs-pr/pull/18849
https://github.com/Azure/azure-rest-api-specs-pr/pull/18788

The first commit is an exact copy/paste of these files and should not require additional review.

The last commit adds suppressions for two errors that were encountered in the public repo, but not the private. Justification for suppressions are:

  1. BodyTopLevelProperties - This looks like a false alarm to me, we are returning a list response to the customer with the expected 'value' and 'nextLink' properties as is recommended in https://github.com/cloud-and-ai-microsoft/resource-provider-contract/blob/master/v1.0/get-resource.md
  2. SystemDataDefinitionsCommonTypes - All specs in microsoft.network use a systemData type defined in the network.json file. If we use the one defined in common types, then it causes a duplicate model error in dotnet sdk generation. For now we will use the one in network.json until all of these microsoft.network migrate to the common type ref.

Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 9, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 9, 2024
@rkmanda rkmanda merged commit 1558ccf into Azure:guptavertika/release-network-Microsoft.Network-2024-03-01 Aug 9, 2024
23 of 27 checks passed
dtuCloud pushed a commit to dtuCloud/azure-rest-api-specs that referenced this pull request Aug 26, 2024
…0102)

* Avnm nsg and udr specs + examples.

* Run prettier check on network manager files.

* Add suppression for false alarm and update system data to use network.json ref.

* Add suppress keyword so lintdiff recognizes suppression.

---------

Co-authored-by: Jared Gorthy <[email protected]>
GuptaVertika pushed a commit that referenced this pull request Sep 10, 2024
* Avnm nsg and udr specs + examples.

* Run prettier check on network manager files.

* Add suppression for false alarm and update system data to use network.json ref.

* Add suppress keyword so lintdiff recognizes suppression.

---------

Co-authored-by: Jared Gorthy <[email protected]>
jaskisin pushed a commit to jaskisin/azure-rest-api-specs that referenced this pull request Sep 16, 2024
…0102)

* Avnm nsg and udr specs + examples.

* Run prettier check on network manager files.

* Add suppression for false alarm and update system data to use network.json ref.

* Add suppress keyword so lintdiff recognizes suppression.

---------

Co-authored-by: Jared Gorthy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Network resource-manager SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants