Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade/typespec 0.59 #30122

Merged
merged 15 commits into from
Aug 8, 2024
Merged

Upgrade/typespec 0.59 #30122

merged 15 commits into from
Aug 8, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Aug 8, 2024 •
edited
Loading

Upgrade spec repo to typespec 0.59.0

@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@timotheeguerin timotheeguerin requested review from johanste and MushMal and removed request for a team August 8, 2024 15:33
This was referenced Aug 8, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
chrisradek
chrisradek approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I can't speak to the questions on some of the private namespace usage.

@markcowl markcowl added Approved-LintDiff PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Aug 8, 2024
@timotheeguerin timotheeguerin merged commit 27a9398 into main Aug 8, 2024
39 of 43 checks passed
@timotheeguerin timotheeguerin deleted the upgrade/typespec-0.59 branch August 8, 2024 19:42
dhananjay824 pushed a commit to dhananjay824/azure-rest-api-specs that referenced this pull request Aug 9, 2024
@timotheeguerin
Upgrade/typespec 0.59 (Azure#30122)
258c79b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@chrisradek chrisradek chrisradek approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@benbp benbp Awaiting requested review from benbp

@marcodalessandro marcodalessandro Awaiting requested review from marcodalessandro marcodalessandro is a code owner

@rohankhandelwal rohankhandelwal Awaiting requested review from rohankhandelwal rohankhandelwal is a code owner

@riteshrao riteshrao Awaiting requested review from riteshrao riteshrao is a code owner

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@wanghoppe wanghoppe Awaiting requested review from wanghoppe wanghoppe is a code owner

@johanste johanste Awaiting requested review from johanste johanste is a code owner automatically assigned from Azure/api-stewardship-board

@MushMal MushMal Awaiting requested review from MushMal MushMal is a code owner automatically assigned from Azure/api-stewardship-board

Assignees
No one assigned
Labels
Approved-LintDiff data-plane PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timotheeguerin @markcowl @chrisradek @AzureRestAPISpecReview @mikeharder