Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arc vm 2408.1 change #30256

Merged
merged 22 commits into from
Aug 28, 2024
Merged

Conversation

vrusheshp
Copy link
Contributor

@vrusheshp vrusheshp commented Aug 19, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Aug 19, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@AzureRestAPISpecReview AzureRestAPISpecReview added NotReadyForARMReview VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 19, 2024
@shraddhasun
Copy link
Contributor

You can get rid of the lintdiff error by following what I did to move the operations api to a new folder here
https://github.com/Azure/azure-rest-api-specs-pr/pull/18743/files?file-filters%5B%5D=.md&file-filters%5B%5D=.tsp&show-deleted-files=true&show-viewed-files=true

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required SuppressionReviewRequired and removed VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Aug 20, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Aug 21, 2024
@vrusheshp vrusheshp removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 21, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 21, 2024
@vrusheshp vrusheshp added Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 labels Aug 21, 2024
@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 21, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 21, 2024
@mentat9
Copy link
Member

mentat9 commented Aug 21, 2024

Signed off for ARM and approved your suppression. Please follow instructions in this comment: #30256 (comment) (it's continually updated through the lifecycle of your PR) to move your PR forward.

@vrusheshp vrusheshp added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 22, 2024
@Alancere
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@vrusheshp vrusheshp merged commit e45cb6b into Azure:main Aug 28, 2024
28 of 30 checks passed
@vrusheshp vrusheshp deleted the vrusheshp/arc_vm_gpu_api_changes branch August 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-Python-Sdk-Suppression BreakingChange-Python-Sdk-Suppression-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants