MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. #3138

rahulgouthamDOTgs · 2018-05-25T21:11:40Z

Note : This API has only version change compared to Previous check in .

Ref PRs :
Original PR
#1773

Revert due to Private Preview Feature
#2411

API version change for Public Preview
https://github.com/Azure/azure-rest-api-specs-pr/pull/478

@marstr , @sarangan12 for review , Please do not merge until the label is removed , I will notify proactively .

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Adding the VNET Rest APIs to 2017-12-01 version.

AutorestCI · 2018-05-25T21:12:55Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-05-25T21:13:16Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2626

AutorestCI · 2018-05-25T21:14:14Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2909

AutorestCI · 2018-05-25T21:14:58Z

Automation for azure-libraries-for-java

A PR has been created for you:
AutorestCI/azure-libraries-for-java#193

AutorestCI · 2018-05-25T21:17:04Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1906

rahulgouthamDOTgs · 2018-05-29T18:02:28Z

@marstr , @sarangan12 Please merge this change if you do not see any open issues.

sarangan12 · 2018-05-30T18:03:30Z

Waiting for ARM (Gaurav) approval for the new version...

ravbhatnagar · 2018-05-30T18:08:53Z

...tion/postgresql/resource-manager/Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json

+          "default": {
+            "description": "*** Error Responses: ***\n\n * 400 InvalidResourceId - Invalid resource identifier.\n\n * 400 MismatchingSubscriptionWithUrl - The provided subscription did not match the subscription in the Url.\n\n * 400 MismatchingResourceGroupNameWithUrl - The provided resource group name did not match the name in the Url.\n\n * 400 MismatchingServerNameWithUrl - The provided server name did not match the name in the Url.\n\n * 400 NullVirtualNetworkRequest - Virtual Network Request is Null\n\n * 400 NullVirtualNetworkRequestParameters - Virtual Network Request Parameters are Null\n\n * 400 NullVirtualNetworkSubnetId - The Virtual Network Subnet Id is null\n\n * 404 SubscriptionDoesNotHaveServer - The requested server was not found\n\n * 404 VirtualNetworkRuleNotEnabled - Azure SQL Server Virtual Network Rule feature is not enabled\n\n * 404 OperationIdNotFound - The operation with Id does not exist.\n\n * 409 OperationCancelled - The operation has been cancelled by user.\n\n * 409 OperationInterrupted - The operation on the resource could not be completed because it was interrupted by another operation on the same resource.\n\n * 500 OperationTimedOut - The operation timed out and automatically rolled back. Please retry the operation."
+          },
+          "202": {


Why do you have both 202 and 201? Are you using 201 + non-terminal provisioning state + Azure Async operation header for tracking long running operation. Or are you using 202 + location header. the first pattern is recommended for PUT/PATCH

This is a long running operation , so we use 202 and location header as of now .

Ok. I see other resource types under this provider are also using 202. So this should be fine. Although, please note that 201 is recommended for PUT and PATCH. So something to note for future.

ravbhatnagar · 2018-05-30T18:14:16Z

...tion/postgresql/resource-manager/Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json

+          "description": "Create firewall rule before the virtual network has vnet service endpoint enabled.",
+          "type": "boolean"
+        },
+        "state": {


This should be replaced by the standard "provisioningState" property that ARM recommends to use to indicate the state of the resource during creation.

for now we are keeping this in sync with Microsoft.SQL Resource Provider for consistency .

Consistency with 100+ providers is what we should be trying to achieve, not with one :). Customers would definitely love that more. Not blocking on it. But please note about such things as it impacts the broader Azure REST API usability, consistency and client experience.

Thanks , I will look into this soon.

ravbhatnagar · 2018-05-30T18:40:26Z

Signing off!

…#3138) * Fix Python conf * Adding the VNET Rest APIs to 2017-12-01 version. Adding the VNET Rest APIs to 2017-12-01 version.

* One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fix build errors Fix build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * One file for server and db apis Make one file which is blobAuditing.json that contains both server & db apis + update readme.md and add operations.json * Add extended server auditing settings API * Fixed operation id. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Enable Database Auditing Filtiring With a Predicate Expression New API which enables database auditing filtering by a where clause. In addition, existing related APIs swaggers were unified under same Public API name. * Fixing examples of existing APIs and modifying blobAuditing Swagger file storageAccountAccessKey was removed from requests response, and examples were modified accordingly. * Remove description of predicateExpression related exceptions from old APIs description. Fixing a small issue for client readability. AuditingSettings and ExtendedAuditingSettings APIs have a mutual exceptions description. Description which mentions predicateExpression parameter in all APIs. After this fix, predicateExpression related exceptions will not be mentioned on old APIs. * Moving files to preview/stable as appropriate. * Modifying swagger and examples of 2017 BlobAuditing APIs (#421) * 2017 Blob Auditing APIs - Swagger and examples. Modifying swagger and examples of 2017 blob auditing APIs. * Resetting examples of DatabaseBlobAuditing API to 2017 Resetting examples of DatabaseBlobAuditing API to 2017 * Fixing follwing comments Fixing follwing comments * Fixing build errors Fixing build errors * Fixing comments fixing comments * Removed 2017 database API Removed 2017 database API * Revert "Fixing comments" This reverts commit c09f9f6. * Modifying description of APIs Modifying description of APIs after generating new swagger. * Modifying readme.md. Modifying readme.md. * Updating blobAuditing Json files. Updating blobAuditing Json files. * Temp change Temp change * Final commit Final commit * Fix Python conf of servermanager (#3140) * Fix ServerManager Py Conf (#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (#3148) * Fix for Azure Networking swagger 2018-04-01 version (#3146) * Adding swagger for new api-version consumption 2018-05-31, introducing new Forecast api swagger (#3114) * Forecast Api swagger * consumption readme file update for the new swagger version * addressing review comment on adding nextLink * fixing build error * Addressed feedback on enum and fixed a typo * Stop using unobscured credentials * Fix Duplicated model name with non-identical definitions build error Fix Duplicated model name with non-identical definitions * Fix go tag for storage management plane 2018-03-02 api version (#3156) * Refactoring Job Definitions (#3116) * MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. (#3138) * Fix Python conf * Adding the VNET Rest APIs to 2017-12-01 version. Adding the VNET Rest APIs to 2017-12-01 version. * Add specs for machine learning services provider (#3135) * Add specs for machine learning services provider * Added python config to readme * Added repo generation for Python * Addressed feedback * Address more comments * Adding Security RP API swagger (#3144) * Reverted methods in vpn gateways. (#3163) * Fix Duplicated model name with non-identical definitions build error This reverts commit 616851d and commits fixes. * Fix Automation Duplicated model name with non-identical definitions Fix Automation Duplicated model name with non-identical definitions * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit d1c40f7. * Revert "Fix Duplicated model name with non-identical definitions build error" This reverts commit 2c1261e. * Update readme.md file Update readme.md file

lmazuel and others added 5 commits April 25, 2018 10:05

Fix Python conf

344f0f2

Merge remote-tracking branch 'origin/opendbms/pgmysql'

86812c4

Adding the VNET Rest APIs to 2017-12-01 version.

4e8e32a

Adding the VNET Rest APIs to 2017-12-01 version.

Merge branch 'master' into master

1bc438f

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

1df93ae

rahulgouthamDOTgs added the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 25, 2018

rahulgouthamDOTgs requested review from marstr and sarangan12 May 25, 2018 21:12

azuresdkci assigned sarangan12 May 25, 2018

AutorestCI mentioned this pull request May 25, 2018

[AutoPR mysql/resource-manager/postgresql/resource-manager] ORCASQL VNET with API Version 2017-12-01 for Public Preview. Azure/azure-sdk-for-python#2626

Merged

AutorestCI mentioned this pull request May 25, 2018

[AutoPR postgresql/resource-manager/mysql/resource-manager] ORCASQL VNET with API Version 2017-12-01 for Public Preview. Azure/azure-sdk-for-node#2909

Closed

AutorestCI mentioned this pull request May 25, 2018

[AutoPR postgresql/resource-manager/mysql/resource-manager] ORCASQL VNET with API Version 2017-12-01 for Public Preview. AutorestCI/azure-libraries-for-java#193

Open

rohit-joy changed the title ~~ORCASQL VNET with API Version 2017-12-01 for Public Preview.~~ MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. May 25, 2018

AutorestCI mentioned this pull request May 25, 2018

[AutoPR postgresql/resource-manager/mysql/resource-manager] ORCASQL VNET with API Version 2017-12-01 for Public Preview. Azure/azure-sdk-for-go#1906

Merged

rahulgouthamDOTgs removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 29, 2018

rahulgouthamDOTgs requested a review from lmazuel May 29, 2018 18:57

sarangan12 approved these changes May 30, 2018

View reviewed changes

ravbhatnagar reviewed May 30, 2018

View reviewed changes

sarangan12 approved these changes May 30, 2018

View reviewed changes

sarangan12 merged commit e049f91 into Azure:master May 30, 2018

This was referenced May 31, 2018

Regenerate mysql and postgresql packages Azure/autorest.typescript#137

Closed

Regenerate mysql and postgresql packages Azure/azure-sdk-for-node#2932

Closed

bashahee pushed a commit that referenced this pull request Jun 3, 2018

MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. (…

e3e1276

…#3138) * Fix Python conf * Adding the VNET Rest APIs to 2017-12-01 version. Adding the VNET Rest APIs to 2017-12-01 version.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. #3138

MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. #3138

rahulgouthamDOTgs commented May 25, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

rahulgouthamDOTgs commented May 29, 2018

sarangan12 commented May 30, 2018

ravbhatnagar May 30, 2018

rahulgouthamDOTgs May 30, 2018

ravbhatnagar May 30, 2018

rahulgouthamDOTgs May 30, 2018

ravbhatnagar May 30, 2018

rahulgouthamDOTgs May 30, 2018

ravbhatnagar May 30, 2018

rahulgouthamDOTgs May 30, 2018

ravbhatnagar commented May 30, 2018

MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. #3138

MySQL/PostgreSQL VNET with API Version 2017-12-01 for Public Preview. #3138

Conversation

rahulgouthamDOTgs commented May 25, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented May 25, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented May 25, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 25, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 25, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented May 25, 2018 • edited Loading

Automation for azure-sdk-for-go

rahulgouthamDOTgs commented May 29, 2018

sarangan12 commented May 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravbhatnagar commented May 30, 2018

rahulgouthamDOTgs commented May 25, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading

AutorestCI commented May 25, 2018 •

edited

Loading