[AKS] update go SDK configuration and fix a consistency error

[mboersma]

#3131 forgot to update readme.md for the Go multi-api SDK. This does that and updates some older description fields so they pass the new, more strict model linting.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

[AutorestCI]

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

[AutorestCI]

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2022

[mboersma]

Looks like npm itself has a security issue with a package it wants to install, and I may need to do more to sync up the models since that validation step failed now.

[annatisch]

@mboersma - This seems to be the last CI error - could you take a look?

INFO:swaggertosdk.autorest_tools:FATAL: Error: '$.definitions.OrchestratorProfile.required' has incompatible values (---
INFO:swaggertosdk.autorest_tools:- orchestratorType
INFO:swaggertosdk.autorest_tools:- orchestratorVersion
INFO:swaggertosdk.autorest_tools:, ---
INFO:swaggertosdk.autorest_tools:- orchestratorVersion
INFO:swaggertosdk.autorest_tools:).

It looks like it's just a mismatch between OrchestratorProfile in location.json vs managedClusters.json.

[annatisch]

Thanks for the fix @mboersma.
There's still a couple of linter ARMViolations:

• "Property named: 'enableRBAC', for definition: 'ManagedClusterProperties' must follow camelCase style. Example: 'enableRbac'."
• "Tracked resource 'ContainerService' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well."
• "Tracked resource 'ManagedCluster' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well."

Given that these errors are not caused by the commits in this PR, I wont block merging because of them - but wondering if it's possible to get these fixed or (if the service is already live) to apply for ARM violation suppression so we can get the CI green?

[mboersma]

wondering if it's possible to get these fixed or (if the service is already live) to apply for ARM violation suppression so we can get the CI green?

Thanks @annatisch! Yes, our intent is to suppress those three known violations for now as AKS is already live. We've communicated with @ravbhatnagar and have a plan to implement the PATCH endpoint for Managed Clusters.