Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Hubs 2018-01-01: correction in the type of List API of VirtualNetwork #3767

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

v-Ajnava
Copy link
Member

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3240

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@annatisch
Copy link
Member

Thanks @v-Ajnava - are you able to please fix the failing model validation test?
I'm aware that the failing example is unrelated to your change - so I wont block on it - but it would be great if we could get the CI passing :)

The only change required is to remove the "description" field from each of the response operation values - as you can see in the definition, there's no "description" property.

Thanks!

@v-Ajnava
Copy link
Member Author

v-Ajnava commented Aug 30, 2018

@annatisch actually removed the operations API, we dont support it on preview for now

@annatisch
Copy link
Member

Thanks @v-Ajnava - isn't removing the Operations API an ARM violation?

@v-Ajnava
Copy link
Member Author

@annatisch you are right, will add it back.

@v-Ajnava
Copy link
Member Author

@annatisch, reverted remove the operation API commit. the Modal validation is fixed in previous commit. so it should be good for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants