Update Microsoft.Backup.Admin API version 2018-09-01 #3891

daozha · 2018-09-13T10:46:29Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-09-13T10:46:54Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

azuresdkci · 2018-09-13T10:47:47Z

Can one of the admins verify this patch?

...ation/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/Backup.json

AutorestCI · 2018-09-13T10:48:37Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-09-13T10:49:17Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

...admin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/BackupLocations.json

AutorestCI · 2018-09-13T10:50:30Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

...tion/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/Backups.json

...source-manager/backup/Microsoft.Backup.Admin/stable/2016-05-01/examples/Operations/List.json

AutorestCI · 2018-09-13T10:52:07Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

hovsepm

@daozha please rework you PR in a way that 1st commit will be a copy without any modification from the previous version of your service swagger and the second commit will be your changes.

deathly809 · 2018-09-13T18:09:46Z

@bganapa / @vlad-MSFT / @knithinc This is update spec for BRP.

daozha · 2018-09-14T01:13:29Z

@hovsepm Done. Thanks for your suggestion.

bganapa · 2018-09-14T01:16:08Z

@hovsepm Please wait till one of us from azure stack approves this PR.

deathly809 · 2018-09-14T14:41:53Z

...admin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/BackupLocations.json

@@ -226,17 +226,23 @@
                    "description": "Password to access the location.",
                    "type": "string"
                },
-                "encryptionKeyBase64": {
-                    "description": "Encryption key.",
+                "encryptionCertBase64": {


I am not 100% sure on how certs work, but I know there is usually a public and private key. Does this relate to the public key? Private key?

deathly809 · 2018-09-14T14:46:22Z

...tion/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/Backups.json

+        "RestoreOptions": {
+            "description": "Properties for restore options.",
+            "properties": {
+                "decryptionCertBase64": {


So this is the private key, which means during backup we use the public key?

Yes, public key to wrap the our internally generated encryption key during backup, and private key to decrypt that encryption key during restore.

deathly809

Everything looks good to me.

hovsepm · 2018-09-17T18:14:44Z

@bganapa please ping me directly when this PR will be ready for review.

hovsepm · 2018-09-17T21:38:22Z

@daozha please fix model validator errors (more precisely issues in examples for the new API version) https://travis-ci.org/Azure/azure-rest-api-specs/jobs/428425013

bganapa · 2018-09-17T23:07:50Z

...admin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/BackupLocations.json

+                            "$ref": "#/definitions/BackupLocation"
+                        }
+                    },
+                    "404": {


Please remove 404, when you specify 404 here, the SDK will eat out the exception. We have been standardizing on not to specify any error codes in the swagger

bganapa · 2018-09-17T23:08:28Z

...admin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/BackupLocations.json

+                            "$ref": "#/definitions/BackupLocation"
+                        }
+                    },
+                    "404": {


Put returning 404? please remove here as well

bganapa · 2018-09-17T23:09:47Z

...tion/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/Backups.json

+                            "$ref": "#/definitions/BackupList"
+                        }
+                    },
+                    "404": {


please remove 404 everywhere

bganapa · 2018-09-17T23:19:41Z

...ource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/examples/Backups/Restore.json

+    "responses": {
+        "200": {},
+        "202": {},
+        "404": {}


you will be in need of removing 404 in the examples as well

bganapa

looks good except for 404

daozha · 2018-09-18T02:25:31Z

@bganapa Done, removed all 404. Thanks.

daozha · 2018-09-18T02:26:36Z

@hovsepm Done. Thank you.

hovsepm · 2018-09-18T18:04:57Z

@daozha good. I need explicit sign-off from @bganapa

bganapa · 2018-09-18T18:08:03Z

@hovsepm looks good to us. Approved. Thanks for the follow ups.

azuresdkci assigned hovsepm Sep 13, 2018

azuresdkci requested a review from hovsepm September 13, 2018 10:46

daozha commented Sep 13, 2018

View reviewed changes

...ation/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/Backup.json Show resolved Hide resolved

daozha commented Sep 13, 2018

View reviewed changes

...admin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/BackupLocations.json Show resolved Hide resolved

daozha commented Sep 13, 2018

View reviewed changes

...tion/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/Backups.json Show resolved Hide resolved

daozha commented Sep 13, 2018

View reviewed changes

...source-manager/backup/Microsoft.Backup.Admin/stable/2016-05-01/examples/Operations/List.json Show resolved Hide resolved

hovsepm suggested changes Sep 13, 2018

View reviewed changes

daozha added 2 commits September 14, 2018 09:08

Microsoft.Backup.Admin copy API version 2018-09-01 from 2016-05-01

6f14d38

Update Microsoft.Backup.Admin API version 2018-09-01

7d5bd61

daozha force-pushed the certwrap_restore branch from dbb748e to 7d5bd61 Compare September 14, 2018 01:12

deathly809 reviewed Sep 14, 2018

View reviewed changes

deathly809 approved these changes Sep 15, 2018

View reviewed changes

hovsepm added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 17, 2018

bganapa reviewed Sep 17, 2018

View reviewed changes

bganapa requested changes Sep 17, 2018

View reviewed changes

resolve comments

87d083a

deathly809 approved these changes Sep 18, 2018

View reviewed changes

bganapa approved these changes Sep 18, 2018

View reviewed changes

hovsepm approved these changes Sep 18, 2018

View reviewed changes

hovsepm merged commit e9e15be into Azure:master Sep 18, 2018

daozha mentioned this pull request Sep 20, 2018

Generate AzureStack Backup.Admin SDK from 2018-09-01 spec Azure/azure-sdk-for-net#4779

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Microsoft.Backup.Admin API version 2018-09-01 #3891

Update Microsoft.Backup.Admin API version 2018-09-01 #3891

daozha commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

azuresdkci commented Sep 13, 2018

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

hovsepm left a comment

deathly809 commented Sep 13, 2018

daozha commented Sep 14, 2018

bganapa commented Sep 14, 2018

deathly809 Sep 14, 2018

deathly809 Sep 14, 2018

daozha Sep 15, 2018

deathly809 left a comment

hovsepm commented Sep 17, 2018

hovsepm commented Sep 17, 2018

bganapa Sep 17, 2018

bganapa Sep 17, 2018

bganapa Sep 17, 2018

bganapa Sep 17, 2018

bganapa left a comment

daozha commented Sep 18, 2018

daozha commented Sep 18, 2018

hovsepm commented Sep 18, 2018

bganapa commented Sep 18, 2018

Update Microsoft.Backup.Admin API version 2018-09-01 #3891

Update Microsoft.Backup.Admin API version 2018-09-01 #3891

Conversation

daozha commented Sep 13, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Sep 13, 2018

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-go

hovsepm left a comment

Choose a reason for hiding this comment

deathly809 commented Sep 13, 2018

daozha commented Sep 14, 2018

bganapa commented Sep 14, 2018

deathly809 Sep 14, 2018

Choose a reason for hiding this comment

deathly809 Sep 14, 2018

Choose a reason for hiding this comment

daozha Sep 15, 2018

Choose a reason for hiding this comment

deathly809 left a comment

Choose a reason for hiding this comment

hovsepm commented Sep 17, 2018

hovsepm commented Sep 17, 2018

bganapa Sep 17, 2018

Choose a reason for hiding this comment

bganapa Sep 17, 2018

Choose a reason for hiding this comment

bganapa Sep 17, 2018

Choose a reason for hiding this comment

bganapa Sep 17, 2018

Choose a reason for hiding this comment

bganapa left a comment

Choose a reason for hiding this comment

daozha commented Sep 18, 2018

daozha commented Sep 18, 2018

hovsepm commented Sep 18, 2018

bganapa commented Sep 18, 2018

daozha commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading