-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Microsoft.Backup.Admin API version 2018-09-01 #3891
Conversation
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Can one of the admins verify this patch? |
...ation/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/Backup.json
Show resolved
Hide resolved
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
...admin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/BackupLocations.json
Show resolved
Hide resolved
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
...tion/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2018-09-01/Backups.json
Show resolved
Hide resolved
...source-manager/backup/Microsoft.Backup.Admin/stable/2016-05-01/examples/Operations/List.json
Show resolved
Hide resolved
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daozha please rework you PR in a way that 1st commit will be a copy without any modification from the previous version of your service swagger and the second commit will be your changes.
@bganapa / @vlad-MSFT / @knithinc This is update spec for BRP. |
dbb748e
to
7d5bd61
Compare
@hovsepm Done. Thanks for your suggestion. |
@hovsepm Please wait till one of us from azure stack approves this PR. |
@@ -226,17 +226,23 @@ | |||
"description": "Password to access the location.", | |||
"type": "string" | |||
}, | |||
"encryptionKeyBase64": { | |||
"description": "Encryption key.", | |||
"encryptionCertBase64": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not 100% sure on how certs work, but I know there is usually a public and private key. Does this relate to the public key? Private key?
"RestoreOptions": { | ||
"description": "Properties for restore options.", | ||
"properties": { | ||
"decryptionCertBase64": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is the private key, which means during backup we use the public key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, public key to wrap the our internally generated encryption key during backup, and private key to decrypt that encryption key during restore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
@bganapa please ping me directly when this PR will be ready for review. |
@daozha please fix model validator errors (more precisely issues in examples for the new API version) https://travis-ci.org/Azure/azure-rest-api-specs/jobs/428425013 |
"$ref": "#/definitions/BackupLocation" | ||
} | ||
}, | ||
"404": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove 404, when you specify 404 here, the SDK will eat out the exception. We have been standardizing on not to specify any error codes in the swagger
"$ref": "#/definitions/BackupLocation" | ||
} | ||
}, | ||
"404": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put returning 404? please remove here as well
"$ref": "#/definitions/BackupList" | ||
} | ||
}, | ||
"404": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove 404 everywhere
"responses": { | ||
"200": {}, | ||
"202": {}, | ||
"404": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will be in need of removing 404 in the examples as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good except for 404
@bganapa Done, removed all 404. Thanks. |
@hovsepm Done. Thank you. |
@hovsepm looks good to us. Approved. Thanks for the follow ups. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger