Add api version 2018-10-01 for Microsoft.Compute #3896

rareddaz · 2018-09-13T19:17:42Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

msftclas · 2018-09-13T19:17:54Z

All CLA requirements met.

AutorestCI · 2018-09-13T19:19:54Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3383

AutorestCI · 2018-09-13T19:20:35Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-09-13T19:21:55Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3669

AutorestCI · 2018-09-13T19:23:21Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-09-13T19:24:25Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2780

azuresdkci · 2018-09-13T19:36:39Z

Can one of the admins verify this patch?

jhendrixMSFT

As a first step please have a look at the linter failures, see the log for more details.

specification/compute/resource-manager/readme.md

specification/compute/resource-manager/Microsoft.Compute/stable/2018-10-01/gallery.json

specification/compute/resource-manager/readme.md

AutorestCI · 2018-09-18T22:17:49Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

rareddaz · 2018-09-20T18:30:12Z

specification/compute/resource-manager/readme.md

@@ -445,6 +459,7 @@ swagger-to-sdk:
    after_scripts:
      - python ./scripts/multiapi_init_gen.py azure-mgmt-compute
  - repo: azure-sdk-for-java
+  - repo: azure-sdk-for-js


I am not sure why its showing as "added" even while comparing with Azure repository.. This change in readme.md was simply pulled in from Azure master to forked repository

rareddaz · 2018-09-20T18:30:58Z

specification/compute/resource-manager/readme.typescript.md

@@ -0,0 +1,12 @@
+## TypeScript
+
+These settings apply only when `--typescript` is specified on the command line.


Same as other comment. This file came in from Azure master actually to forked repository..

rareddaz · 2018-09-20T18:32:23Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/gallery.json

@@ -40,7 +40,7 @@
          "Galleries"
        ],
        "operationId": "Galleries_CreateOrUpdate",
-        "description": "Create or update a gallery.",
+        "description": "Create or update a Shared Image Gallery.",


all changes in this file are already there in Azure master branch.. Not sure why its showing as "added" in my PR, as I simply pulled Azure master into my forked repository.

AutorestCI mentioned this pull request Sep 13, 2018

[AutoPR compute/resource-manager] Add api version 2018-10-01 for Microsoft.Compute Azure/azure-sdk-for-node#3595

Merged

azuresdkci assigned jhendrixMSFT Sep 13, 2018

azuresdkci requested a review from jhendrixMSFT September 13, 2018 19:40

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 15, 2018

jhendrixMSFT requested changes Sep 15, 2018

View reviewed changes

hyonholee reviewed Sep 18, 2018

View reviewed changes

specification/compute/resource-manager/readme.md Outdated Show resolved Hide resolved

hyonholee reviewed Sep 18, 2018

View reviewed changes

specification/compute/resource-manager/readme.md Outdated Show resolved Hide resolved

vladimirjoanovic reviewed Sep 18, 2018

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2018-10-01/gallery.json Outdated Show resolved Hide resolved

vladimirjoanovic added the ARMReviewInProgress label Sep 18, 2018

jhendrixMSFT reviewed Sep 18, 2018

View reviewed changes

specification/compute/resource-manager/readme.md Outdated Show resolved Hide resolved

vladimirjoanovic added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 18, 2018

rareddaz commented Sep 20, 2018

View reviewed changes

rareddaz requested review from MikhailTryakhov, kay-owolabi and yangyuan as code owners September 21, 2018 18:27

rareddaz force-pushed the master branch from 14b4590 to cf4aa82 Compare September 21, 2018 19:01

This was referenced Sep 21, 2018

[AutoPR compute/resource-manager] Add api version 2018-10-01 for Microsoft.Compute Azure/azure-sdk-for-python#3404

Merged

[AutoPR compute/resource-manager] Add api version 2018-10-01 for Microsoft.Compute Azure/azure-sdk-for-go#2795

Merged

Added API version 2018-10-01

71cfd63

rareddaz force-pushed the master branch from cf4aa82 to 71cfd63 Compare September 21, 2018 19:12

jhendrixMSFT approved these changes Sep 21, 2018

View reviewed changes

jhendrixMSFT merged commit acaf947 into Azure:master Sep 21, 2018

yugangw-msft mentioned this pull request Sep 26, 2018

[vmss]: user new api-version 2018-10-01 for Automatic OS Upgrade GA Azure/azure-cli#7428

Closed

hyonholee mentioned this pull request Sep 27, 2018

[Compute] Update Compute client version to 23.0.0. Azure/azure-sdk-for-net#4809

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add api version 2018-10-01 for Microsoft.Compute #3896

Add api version 2018-10-01 for Microsoft.Compute #3896

rareddaz commented Sep 13, 2018

msftclas commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

azuresdkci commented Sep 13, 2018

jhendrixMSFT left a comment

AutorestCI commented Sep 18, 2018 •

edited

Loading

rareddaz Sep 20, 2018

rareddaz Sep 20, 2018

rareddaz Sep 20, 2018

		@@ -0,0 +1,12 @@
		## TypeScript

		These settings apply only when `--typescript` is specified on the command line.

Add api version 2018-10-01 for Microsoft.Compute #3896

Add api version 2018-10-01 for Microsoft.Compute #3896

Conversation

rareddaz commented Sep 13, 2018

PR information

Quality of Swagger

msftclas commented Sep 13, 2018 • edited Loading

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Sep 13, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Sep 13, 2018

jhendrixMSFT left a comment

Choose a reason for hiding this comment

AutorestCI commented Sep 18, 2018 • edited Loading

Automation for azure-sdk-for-js

rareddaz Sep 20, 2018

Choose a reason for hiding this comment

rareddaz Sep 20, 2018

Choose a reason for hiding this comment

rareddaz Sep 20, 2018

Choose a reason for hiding this comment

msftclas commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 13, 2018 •

edited

Loading

AutorestCI commented Sep 18, 2018 •

edited

Loading