-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StorageSync : Clone existing ApiVersion 2018-04-02 for creating a new version 2018-07-01 #3927
StorageSync : Clone existing ApiVersion 2018-04-02 for creating a new version 2018-07-01 #3927
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankushbindlish2 ask me to take a look at this offline.
At this stage, the expected path for the directory 2018-07-01
is:
$REPO_ROOT/specification/storagesync/resource-manager/Microsoft.StorageSync/preview/2018-07-01/
In addition, I'd update the README here as well to include the new tag. That way the Automation for the various languages above will light-up.
I just went ahead and sniped this from @annatisch since I have more context. |
Updated with review comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding a section in the README for $(go)
while you're at it?
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger