Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageSync : Clone existing ApiVersion 2018-04-02 for creating a new version 2018-07-01 #3927

Merged
merged 6 commits into from
Sep 18, 2018
Merged

StorageSync : Clone existing ApiVersion 2018-04-02 for creating a new version 2018-07-01 #3927

merged 6 commits into from
Sep 18, 2018

Conversation

ankushbindlish2
Copy link
Member

@ankushbindlish2 ankushbindlish2 commented Sep 18, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 18, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2734

@AutorestCI
Copy link

AutorestCI commented Sep 18, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2732

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 18, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 18, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3628

@AutorestCI
Copy link

AutorestCI commented Sep 18, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2402

Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushbindlish2 ask me to take a look at this offline.

At this stage, the expected path for the directory 2018-07-01 is:

$REPO_ROOT/specification/storagesync/resource-manager/Microsoft.StorageSync/preview/2018-07-01/

In addition, I'd update the README here as well to include the new tag. That way the Automation for the various languages above will light-up.

@marstr marstr assigned marstr and unassigned annatisch Sep 18, 2018
@marstr marstr removed the request for review from annatisch September 18, 2018 16:33
@marstr
Copy link
Member

marstr commented Sep 18, 2018

I just went ahead and sniped this from @annatisch since I have more context.

@ankushbindlish2
Copy link
Member Author

Updated with review comments

Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a section in the README for $(go) while you're at it?

specification/storagesync/resource-manager/readme.ruby.md Outdated Show resolved Hide resolved
@marstr marstr merged commit cbf6f45 into Azure:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants