-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix network trace API REST format #4295
Conversation
@naveedaz Please review. |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
@azuresdkci add to whitelist |
@michimune I am requesting an ARM review of the API. From what I could gather looking at the changes requested here, the API surface would remain the same (from the perspective of the generated SDK) but the behavior of what that generated function does is different. Its calling a new REST endpoint. This would break all existing customers and all of them would have to upgrade to a newer SDK for things to work as expected. I an requesting the ARM folks to sign off on these changes. |
This does seem like something that should be landed in a new API version. |
Actually the old API endpoints still exist. Only the swagger and SDKs want to point to a different REST endpoint. Do we still need a new API version in this case? |
Actually Navy told me what was wrong. I am working on fix. |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
@vladimirjoanovic @praries880 I believe it's finally in a good shape. Automation says there aren't any breaking changes. |
@veronicagg can you kindly merge this PR? |
Automation for azure-sdk-for-javaEncountered an unknown error: (azure-sdk-for-java)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 249, in generate_sdk_from_git_object
with tempfile.TemporaryDirectory() as temp_dir:
File "/usr/lib/python3.6/tempfile.py", line 931, in __init__
self.name = mkdtemp(suffix, prefix, dir)
File "/usr/lib/python3.6/tempfile.py", line 499, in mkdtemp
prefix, suffix, dir, output_type = _sanitize_params(prefix, suffix, dir)
File "/usr/lib/python3.6/tempfile.py", line 269, in _sanitize_params
dir = gettempdir()
File "/usr/lib/python3.6/tempfile.py", line 437, in gettempdir
tempdir = _get_default_tempdir()
File "/usr/lib/python3.6/tempfile.py", line 372, in _get_default_tempdir
dirlist)
FileNotFoundError: [Errno 2] No usable temporary directory found in ['/tmp', '/var/tmp', '/usr/tmp', '/git-restapi'] |
Thank you very much! |
* add new API version; add put/get AppRegInvitie API there * update specification/azurelogistics/resource-manager/readme.md * fix pipline error * added provision state to appRegInvite * fix ARM comments Co-authored-by: Jeremiah Guo <[email protected]>
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger