Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model ContainerNic refs under ContainerNicConfig as sub resources #4459

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Model ContainerNic refs under ContainerNicConfig as sub resources #4459

merged 1 commit into from
Nov 14, 2018

Conversation

Flip-Liquid
Copy link
Contributor

Modelling container nic children on container nic configs as resource ids only to fix a circular reference issue.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 14, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Nov 14, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Nov 14, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 14, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3794

dsgouda
dsgouda approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Nov 14, 2018

Will merge when CIs pass

@AutorestCI
Copy link

AutorestCI commented Nov 14, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Nov 14, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 14, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#3290

@dsgouda dsgouda merged commit baf31d9 into Azure:network-november-release Nov 14, 2018
@Flip-Liquid
Copy link
Contributor Author

Thanks @dsgouda

@AutorestCI
Copy link

AutorestCI commented Nov 14, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@EvgenyAgafonchikov EvgenyAgafonchikov mentioned this pull request Nov 14, 2018
Merged
3 tasks
@MikhailTryakhov
Copy link
Contributor

@dsgouda looks like this merge was incorrect because it was merged to 2018-08-01 folder instead of 2018-10-01
Please confirm and provide Jack with steps need to be done to revert these changes

@MikhailTryakhov
Copy link
Contributor

@dsgouda looks like there is PR with a correct fix https://github.com/Azure/azure-rest-api-specs/pull/4463/files
so we just need to revert this merge

Flip-Liquid added a commit to Flip-Liquid/azure-rest-api-specs that referenced this pull request Nov 14, 2018
@Flip-Liquid
Revert "change container nics property type on container nic config t…
a34ad41 
…o resourceid (Azure#4459)"

This reverts commit baf31d9.
@Flip-Liquid Flip-Liquid mentioned this pull request Nov 14, 2018
Merged
@Flip-Liquid
Copy link
Contributor Author

@MikhailTryakhov, please see #4467

@dsgouda
Copy link
Contributor

dsgouda commented Nov 14, 2018

@jcgknudson @MikhailTryakhov please open a PR reverting this change and i can merge it

dsgouda pushed a commit that referenced this pull request Nov 14, 2018
@Flip-Liquid @dsgouda
Revert "Model ContainerNic refs under ContainerNicConfig as sub resou…
a18fe30 
…rces" (#4467)

* Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)"

This reverts commit 633d12d.

* Revert "Port fix from PR 4459 to 2018-10-01 (#4463)"

This reverts commit 5ea0c7b.

* Revert "change container nics property type on container nic config to resourceid (#4459)"

This reverts commit baf31d9.
jianghaolu pushed a commit that referenced this pull request Nov 27, 2018
@MikhailTryakhov @jianghaolu
Network november release (#4509)
134de63 
* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01

* Updates readme

* Updates API version in new specs and examples

* [Networkwatcer] add FlowLogFormatParameters (#4374)

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json

[Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties

* Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json"

This reverts commit f4f438a.

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json

[networkwatcer] add FlowLogFormatParameters

* [Network wathcer] add a new field trafficAnalyticsInterval for TA (#4420)

* Make NIC VM ref readonly (#4443)

* Mark private IP address read-only (#4447)

* change container nics property type on container nic config to resourceid (#4459)

* Port fix from PR 4459 to 2018-10-01 (#4463)

* Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)

* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01

* Updates readme

* Updates API version in new specs and examples

* Adds Rewrite rule set for Header CRUD

Adds the structure of rewriteRuleSets in the applicationGatewayProperties.
Adds recursively the sub structures in the rewriteRuleSet.
Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule.

* Adds examples for the Header CRUD in application gateway

* Fix the examples; replacing rules with rewriteRules.

* Fixing the properties of application Gateway rewriteRule

* Revert "Fixing the properties of application Gateway rewriteRule"

This reverts commit 05c9c91.

* Fixing the properties of application Gateway rewriteRule

* Mark the provisioning state as readOnly

* Mark etag as readOnly

* Revert "Model ContainerNic refs under ContainerNicConfig as sub resources" (#4467)

* Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)"

This reverts commit 633d12d.

* Revert "Port fix from PR 4459 to 2018-10-01 (#4463)"

This reverts commit 5ea0c7b.

* Revert "change container nics property type on container nic config to resourceid (#4459)"

This reverts commit baf31d9.

* Fixes the missing array for the header actions (#4497)

* Network py 2018-10

* add package-2018-10 to Go SDK codegen

* Application gateway Identity and Keyvault support (#4387)

* identity and keyvault

* Capitalization comment

* Ported fix from master branch (#4547)
jianghaolu pushed a commit that referenced this pull request Nov 27, 2018
@dedhar @jianghaolu
Add support for List Operation on global reach connections (#4589)
2aebd7d 
* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01

* Updates readme

* Updates API version in new specs and examples

* [Networkwatcer] add FlowLogFormatParameters (#4374)

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json

[Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties

* Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json"

This reverts commit f4f438a.

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json

[networkwatcer] add FlowLogFormatParameters

* [Network wathcer] add a new field trafficAnalyticsInterval for TA (#4420)

* Make NIC VM ref readonly (#4443)

* Mark private IP address read-only (#4447)

* change container nics property type on container nic config to resourceid (#4459)

* Port fix from PR 4459 to 2018-10-01 (#4463)

* Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)

* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01

* Updates readme

* Updates API version in new specs and examples

* Adds Rewrite rule set for Header CRUD

Adds the structure of rewriteRuleSets in the applicationGatewayProperties.
Adds recursively the sub structures in the rewriteRuleSet.
Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule.

* Adds examples for the Header CRUD in application gateway

* Fix the examples; replacing rules with rewriteRules.

* Fixing the properties of application Gateway rewriteRule

* Revert "Fixing the properties of application Gateway rewriteRule"

This reverts commit 05c9c91.

* Fixing the properties of application Gateway rewriteRule

* Mark the provisioning state as readOnly

* Mark etag as readOnly

* Revert "Model ContainerNic refs under ContainerNicConfig as sub resources" (#4467)

* Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (#4331)"

This reverts commit 633d12d.

* Revert "Port fix from PR 4459 to 2018-10-01 (#4463)"

This reverts commit 5ea0c7b.

* Revert "change container nics property type on container nic config to resourceid (#4459)"

This reverts commit baf31d9.

* Fixes the missing array for the header actions (#4497)

* Network py 2018-10

* add package-2018-10 to Go SDK codegen

* Application gateway Identity and Keyvault support (#4387)

* identity and keyvault

* Capitalization comment

* Ported fix from master branch (#4547)

* Add support for list api for global reach connections

* address farhan comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Flip-Liquid @azuresdkci @AutorestCI @dsgouda @MikhailTryakhov