EventHub: 2018-preview - added new API for NetworkRuleSet #4748

v-Ajnava · 2018-12-04T03:23:35Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-portal-comment · 2018-12-04T03:23:36Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-04T03:24:12Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2018-12-04T03:24:39Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2018-12-04T03:26:44Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-04T03:26:52Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-12-04T03:28:29Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2153

AutorestCI · 2018-12-04T03:28:43Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3729

AutorestCI · 2018-12-04T03:36:15Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

KrisBash · 2018-12-06T21:26:27Z

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

+            "$ref": "#/parameters/ResourceGroupNameParameter"
+          },
+          {
+            "$ref": "#/parameters/NamespaceNameParamet


For hygiene, resource type name should be lowerCamelCase

KrisBash · 2018-12-06T21:27:49Z

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

+            "$ref": "#/parameters/ResourceGroupNameParameter"
+          },
+          {
+            "$ref": "#/parameters/NamespaceNameParamet


Same comment on lowerCamelCasing for hygien

KrisBash · 2018-12-06T21:50:39Z

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

+            "$ref": "#/parameters/ResourceGroupNameParameter"
+          },
+          {
+            "$ref": "#/parameters/NamespaceNameParamet


The resource type name should be plural: networkRulesets. I'm not sure what the distinction is between virtualNetworkRules and networkRulsets, but could an improved resource type name help make that distinction?

as this is the preview version, we will be will be deprecated virtualNetworkRules API and will be going ahead with only networkruleset API.
for plural: networkRulesets, Correct me if I am wrong. each namespace will be having only one networkRuleset which will consist of ipRule list and virtualNetworkRule list.
so should we make plural: networkRulesets or singular : networkRuleset ?

yeah, today we do pluralize the resourceType names even though for that type there may be just a single instance possible.

KrisBash

Please see comment about pluralization of resource type name

v-Ajnava · 2018-12-07T19:33:29Z

@KrisBash can you please see the comment for pluralization. changing the definition name of NetworkRuleset to loweCamelCase will change class name to lowerCamelCase which Autorest generates.

nschonni

minor typos

nschonni · 2018-12-11T01:12:07Z

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

+            }
+          },
+          "200": {
+            "description": "Namespace successfuly created.",


successfuly -> successfully

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

nschonni · 2018-12-11T01:12:33Z

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

+            }
+          },
+          "200": {
+            "description": "Namespace successfuly updated.",


successfuly -> successfully

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

nschonni · 2018-12-11T01:13:16Z

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

+            "$ref": "#/parameters/resourceGroupNameParameter"
+          },
+          {
+            "$ref": "#/parameters/namespaceNameParamet


vaule -> value

nschonni · 2018-12-11T01:14:31Z

...venthub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json

+            "$ref": "#/parameters/resourceGroupNameParameter"
+          },
+          {
+            "$ref": "#/parameters/namespaceNameParamet


NameSpaceVirtualNetworkRuleSetget -> NameSpaceVirtualNetworkRuleSetGet
Or change it to a sentence

fixed, changed the example filenames from NameSpaceVirtualNetworkRuleSetget to NameSpaceNetworkRuleSetGet

ravbhatnagar · 2018-12-12T08:37:25Z

@v-Ajnava - You have updated the model names to be plural, which was not needed. The resource type name in the URL of the API needs to be pluralized.

v-Ajnava · 2018-12-12T17:51:28Z

@ravbhatnagar updated resource type name in url with plural and lowerCamelCase and reverted plural model names

ravbhatnagar · 2018-12-12T22:58:46Z

cool, signing off from ARM side.

praries880 · 2018-12-14T18:04:14Z

@KrisBash You need to approve the changes here. I can not merge the changes in without your approval.

KrisBash

Thanks for the changes

* added new NetworkRule APIs * updated lowerCamelCase for Parameters * pluralize NetworkRuleSets * fixed lint errors * fixed typo and updated examples files names for NetworkRuleSets * updated resource type name in url with plural and lowerCamelCase

) * Swagger for HybridAKS provisioned clusters (#4697) Added swagger for HybridAKS provisioned clusters * Swagger fix validation errors and added examples (#4744) * added examples and fixed some validation errors * fixed more validation errors and warnings * Added x-ms-secret flag for passwords * fixing liniting issues in swagger (#4748) * Fixes for prettier, spell checks and go-sdk generation (#4767) * Fixes for prettier, spell checks and go-sdk generation * changed default network plugin to calico * formatting fix * added enums, defaults and moved nodepool config to a common definition * changed go-sdk to track2 * Added cluster prefix to name and location

added new NetworkRule APIs

7807c4f

azuresdkci assigned praries880 Dec 4, 2018

azuresdkci requested a review from praries880 December 4, 2018 03:24

This was referenced Dec 4, 2018

[AutoPR eventhub/resource-manager] EventHub: 2018-preview - added new API for NetworkRuleSet Azure/azure-sdk-for-java#2725

Merged

[AutoPR eventhub/resource-manager] EventHub: 2018-preview - added new API for NetworkRuleSet Azure/azure-sdk-for-go#3563

Merged

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 5, 2018

KrisBash reviewed Dec 6, 2018

View reviewed changes

KrisBash suggested changes Dec 6, 2018

View reviewed changes

KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Dec 6, 2018

updated lowerCamelCase for Parameters

8ecb8cf

v-ajnava added 2 commits December 10, 2018 16:16

pluralize NetworkRuleSets

dad6363

fixed lint errors

a60b308

nschonni reviewed Dec 11, 2018

View reviewed changes

fixed typo and updated examples files names for NetworkRuleSets

3b57de7

updated resource type name in url with plural and lowerCamelCase

7d461b5

ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 12, 2018

ravbhatnagar removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 12, 2018

praries880 approved these changes Dec 14, 2018

View reviewed changes

KrisBash approved these changes Dec 14, 2018

View reviewed changes

praries880 merged commit 7ec8852 into Azure:master Dec 14, 2018

v-Ajnava mentioned this pull request Jan 4, 2019

ServiceBus2018-preview: Updated as per review comments from ARM Team for Eventhub swagger #4989

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EventHub: 2018-preview - added new API for NetworkRuleSet #4748

EventHub: 2018-preview - added new API for NetworkRuleSet #4748

v-Ajnava commented Dec 4, 2018

openapi-portal-comment bot commented Dec 4, 2018

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

azuresdkci commented Dec 4, 2018

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

KrisBash Dec 6, 2018

v-Ajnava Dec 7, 2018

KrisBash Dec 6, 2018

v-Ajnava Dec 7, 2018

KrisBash Dec 6, 2018

v-Ajnava Dec 7, 2018

ravbhatnagar Dec 10, 2018

KrisBash left a comment

v-Ajnava commented Dec 7, 2018 •

edited

Loading

nschonni left a comment

nschonni Dec 11, 2018

v-Ajnava Dec 11, 2018

nschonni Dec 11, 2018

nschonni Dec 11, 2018

nschonni Dec 11, 2018

v-Ajnava Dec 11, 2018

ravbhatnagar commented Dec 12, 2018

v-Ajnava commented Dec 12, 2018

ravbhatnagar commented Dec 12, 2018

praries880 commented Dec 14, 2018

KrisBash left a comment

EventHub: 2018-preview - added new API for NetworkRuleSet #4748

EventHub: 2018-preview - added new API for NetworkRuleSet #4748

Conversation

v-Ajnava commented Dec 4, 2018

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-portal-comment bot commented Dec 4, 2018

AutorestCI commented Dec 4, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Dec 4, 2018 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented Dec 4, 2018

AutorestCI commented Dec 4, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Dec 4, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Dec 4, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Dec 4, 2018 • edited Loading

Automation for azure-sdk-for-js

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KrisBash left a comment

Choose a reason for hiding this comment

v-Ajnava commented Dec 7, 2018 • edited Loading

nschonni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravbhatnagar commented Dec 12, 2018

v-Ajnava commented Dec 12, 2018

ravbhatnagar commented Dec 12, 2018

praries880 commented Dec 14, 2018

KrisBash left a comment

Choose a reason for hiding this comment

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

v-Ajnava commented Dec 7, 2018 •

edited

Loading