Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new api-version to Microsoft.Security Alerts resource #4902

Merged
merged 6 commits into from
Feb 1, 2019
Merged

Adding new api-version to Microsoft.Security Alerts resource #4902

merged 6 commits into from
Feb 1, 2019

Conversation

orparnes
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#582

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3998

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3782

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4195

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@hovsepm
Copy link
Contributor

hovsepm commented Dec 13, 2018

@orparnes please fix the build breaks

This was referenced Dec 13, 2018
Closed
Closed
Closed
Closed
@orparnes
Copy link
Contributor Author

@chlahav is added to the review. #Closed

@hovsepm
Copy link
Contributor

hovsepm commented Dec 13, 2018

@orparnes please rework you PR in a way that the first commit will be a copy of existing swagger and then rest of the commits will be modifications. Otherwise it is impossible to understand what is the difference between API 2019-01-01 and 2015-06-01 (or whatever was the baseline).

@chlahav chlahav self-requested a review December 16, 2018 14:37
@chlahav chlahav added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 16, 2018
@orparnes
Copy link
Contributor Author

@orparnes please rework you PR in a way that the first commit will be a copy of existing swagger and then rest of the commits will be modifications. Otherwise it is impossible to understand what is the difference between API 2019-01-01 and 2015-06-01 (or whatever was the baseline).

Just pushed another 2 commits:
First one is copy of "preview\2015-06-01-preview" into "stable\2019-01-01"
Second one is changes made to the new version and documentation fixes for the old one.

Those are the changes:

preview\2015-06-01-preview\security.json

  • Under "AlertProperties", Add "isIncident" as it wasn't documented at all
  • Under "AlertProperties", for "reportedSeverity", write all possible values (enum)

stable\2019-01-01

  • Basically, creating a "stable" version for the "alerts" type, called it "2019-01-01".
  • This is the first "stable" version of "Microsoft.Security", so added "stable" directory

stable\2019-01-01\security.json

  • Remove all info that is not related to the "alerts" type.
  • Under "AlertProperties", for "reportedSeverity", changed the possible values of the enum (this is the only actual change)

stable\2019-01-01\examples
those are the exact same examples of the "preview" version, except the "api-version" itself

Others stable versions for other "Microsoft.Security" types will be added after this first one.

@hovsepm
Copy link
Contributor

hovsepm commented Jan 2, 2019

@orparnes as I mentioned above please rework your PR. Plus you should not make changes in the stable PR in the new API version PR.

@hovsepm hovsepm added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Jan 7, 2019
@hovsepm hovsepm removed their assignment Jan 10, 2019
@ravbhatnagar
Copy link
Contributor

There is another API-version for Security RP in review #4978
@orparnes - Are you shipping 2 api versions and the changes in each are not part of the other API-version? Is this the intention?
It may be better/quicker to get a review meeting scheduled (with armapireview) to go over the changes and the new APIs.

@ravbhatnagar
Copy link
Contributor

Confirmed with service team that they are introducing a non-preview (GA) API version for the RP and want to support only alerts and location/alerts APIs in that. The only change from preview for these APIs is new values for AlertSeverity property.

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewMeetingRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 17, 2019
@orparnes
Copy link
Contributor Author

@hovsepm Can you please merge this PR?

@hovsepm
Copy link
Contributor

hovsepm commented Jan 22, 2019

@orparnes I've signed off already. @jianghaolu will make the final review and merge this PR.

@AutorestCI AutorestCI mentioned this pull request Jan 23, 2019
Closed
@jianghaolu
Copy link
Contributor

license/cla is not running. I'll try closing and reopening.

@jianghaolu jianghaolu closed this Jan 31, 2019
@jianghaolu jianghaolu reopened this Jan 31, 2019
This was referenced Jan 31, 2019
Merged
Merged
Merged
Merged
@jianghaolu jianghaolu merged commit 93f46f5 into Azure:master Feb 1, 2019
yangl900 added a commit to yangl900/azure-rest-api-specs that referenced this pull request Feb 4, 2019
@yangl900
Revert "Adding new api-version to Microsoft.Security Alerts resource (A…
43d2a1f 
…zure#4902)"

This reverts commit 93f46f5.
jhendrixMSFT pushed a commit that referenced this pull request Feb 4, 2019
@yangl900 @jhendrixMSFT
Revert "[AKS] add apiServerAuthorizedIPRanges property" (#5150)
c00c1cb 
* Revert "typo: azure-mgmt-containerservices -> azure-mgmt-containerservice (#5103)"

This reverts commit c8be36b.

* Revert "Add missing Java code gen info to Kusto (#5142)"

This reverts commit 8c304e7.

* Revert "Update compute.json (#4866)"

This reverts commit 72afb64.

* Revert "Add SkillsetOperations to C# code generation settings (#5132)"

This reverts commit b2ed47f.

* Revert "[GuestConfiguration]Update ConfigurationInfo class to include version field (#5131)"

This reverts commit 930987c.

* Revert "Adding new api-version to Microsoft.Security Alerts resource (#4902)"

This reverts commit 93f46f5.

* Revert "Add a spec for policyStates API version 2018-07-01-preview (#5134)"

This reverts commit 84d025e.

* Revert "added link to disk properties for UltraSSD values (#5135)"

This reverts commit e713e24.

* Revert "Undoing unintended removal of a field (#5133)"

This reverts commit e0f2f8c.

* Revert "Run separate instance of OAV (#5026)"

This reverts commit e44239a.

* Revert "Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription (#5105)"

This reverts commit eaf5e5c.

* Revert "Resourcehealth events response (#5116)"

This reverts commit 935baac.

* Revert "Add Helm Events to ACR Schema for Event Grid (#5109)"

This reverts commit 6f4cee5.

* Revert " Creates the "real" API for Scheduled Alert Rules (#5084)"

This reverts commit d847550.

* Revert "Update managedInstances.json (#5114)"

This reverts commit 2072ba5.

* Revert "HDFS FE: Update 2018-11-09 DataLakeStorage Swagger. (#5108)"

This reverts commit 60a8c18.

* Revert "Add dispatch child to LUIS Runtime response (#5100)"

This reverts commit 03581da.

* Revert "Add new field 'proximityPlacementGroup' to properties of HanaInstance (#5107)"

This reverts commit 31fa6a1.

* Revert "fix Go SDK codegen for Microsoft.Insights (#5106)"

This reverts commit b5ac8e3.

* Revert "[AKS] add apiServerAuthorizedIPRanges property (#5101)"

This reverts commit 8d178c3.
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@orparnes @AnuTalluri
Adding new api-version to Microsoft.Security Alerts resource (Azure#4902
a93e415 
)

* Copy preview/2015-06-01-preview to stable/2019-01-01 (as we want to edit "alerts" endpoint, which exists only in the 2015-06-01 version)

* Fix alerts examples of version 2015-06-01-preview

* Remove anything that is not "alerts" related from version 2019-01-01

* Set all changes for "alerts" type of the new version "2019-01-01"

* Add the stable version to the readme file

* Rollback readme change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu jianghaolu approved these changes

@hovsepm hovsepm hovsepm approved these changes

@chlahav chlahav chlahav approved these changes

Assignees

@jianghaolu jianghaolu

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@orparnes @AutorestCI @azuresdkci @hovsepm @ravbhatnagar @jianghaolu @chlahav @kpajdzik