-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for dropped databases on Managed Instance #4953
Added support for dropped databases on Managed Instance #4953
Conversation
If you're a MSFT employee, click this link |
Hello!! The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays! Thanks and Have a WONDERFUL HOLIDAY |
Automation for azure-sdk-for-rubyA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Here are scenario tests: https://github.com/Azure/azure-sdk-for-net/pull/5107 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a new ARM violation, see the task result here. This either needs to be fixed or ARM team to provide an approval for suppression.
@v-djnisi The arm validation error concerns the lack of a PATCH api on the restorableDroppedDatabases. A PATCH API is required on all tracked resources, which is why this resource has been flagged. Note, the linting runs on all files in the commit, not just the changed files - which is why this is being flagged on an existing file. I notice that there is no PUT api for this resource type. Can the user not create/update this resource? If that is the case, I think it would make sense to request a suppression for this validation error. Is this something you can comment on? |
Correct, this resource can't be created or updated. Once database is dropped it transitions to dropped databases, and it's only purpose is to provide data and backups so that we can restore it afterwards if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off from ARM. For this specific case, a suppression should be requested given the nature of the resource
Anything required from me, regarding the suppression? |
@v-djnisi yes please send an email to |
b69193a
to
6761783
Compare
Added suppression. |
Latest improvements:
Adding dropped database, as well as short term retention for dropped databases to readme.me. API for both of these is in prod for quite some time.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.