Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for dropped databases on Managed Instance #4953

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

v-djnisi
Copy link
Contributor

@v-djnisi v-djnisi commented Dec 20, 2018

Latest improvements:

Adding dropped database, as well as short term retention for dropped databases to readme.me. API for both of these is in prod for quite some time.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Contributor

Hello!!

The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays!

Thanks and Have a WONDERFUL HOLIDAY

@AutorestCI
Copy link

AutorestCI commented Dec 20, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2143

@AutorestCI
Copy link

AutorestCI commented Dec 20, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3769

@AutorestCI
Copy link

AutorestCI commented Dec 20, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#570

@AutorestCI
Copy link

AutorestCI commented Dec 20, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3910

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Dec 20, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2138

@AutorestCI
Copy link

AutorestCI commented Dec 20, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4181

@v-djnisi
Copy link
Contributor Author

v-djnisi commented Dec 20, 2018

Here are scenario tests: https://github.com/Azure/azure-sdk-for-net/pull/5107

Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a new ARM violation, see the task result here. This either needs to be fixed or ARM team to provide an approval for suppression.

@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 20, 2018
@KrisBash
Copy link
Contributor

@v-djnisi The arm validation error concerns the lack of a PATCH api on the restorableDroppedDatabases. A PATCH API is required on all tracked resources, which is why this resource has been flagged. Note, the linting runs on all files in the commit, not just the changed files - which is why this is being flagged on an existing file. I notice that there is no PUT api for this resource type. Can the user not create/update this resource? If that is the case, I think it would make sense to request a suppression for this validation error. Is this something you can comment on?

@v-djnisi
Copy link
Contributor Author

Correct, this resource can't be created or updated. Once database is dropped it transitions to dropped databases, and it's only purpose is to provide data and backups so that we can restore it afterwards if necessary.

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off from ARM. For this specific case, a suppression should be requested given the nature of the resource

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 21, 2018
@v-djnisi
Copy link
Contributor Author

Anything required from me, regarding the suppression?

@jhendrixMSFT
Copy link
Member

@v-djnisi yes please send an email to armpm and adxsr with a request for the suppression along with an explanation.

@v-djnisi
Copy link
Contributor Author

Added suppression.

@jhendrixMSFT jhendrixMSFT merged commit 2c26ca1 into Azure:master Jan 18, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants