Fix errors in ddosCustomPolicy.json #5008

anton-evseev · 2019-01-09T11:37:37Z

When ddosCustomPolicy.json was added to Network's 2018-11-01 it wasn't included in readme.md. Because of that CI didn't catch that those specs contain errors and break Autorest generation.
This PR:

Adds ddosCustomPolicy.json to readme.md
Renames enums that used description as name
Removes duplicate parameters (they are already inherited from allOf and duplicate "tags" break Autorest generation).
Fixes examples

It seems that location was missing from specs. If you try to PUT resource using ARMClient without location you would get an error LocationRequired

 C:\Users\v-anevse> ARMClient.exe put "/subscriptions/xxx/resourceGroups/test-evg/providers/Microsoft.Network/ddosCustomPolicies/policyTest?api-version=2018-11-01"  '{\"properties\":{\"protocolCustomSettings\":[{\"protocol\":\"Tcp\"}]}}'
{
  "error": {
    "code": "LocationRequired",
    "message": "The location property is required for this definition."
  }
}

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-portal-comment · 2019-01-09T11:37:38Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

azuresdkci · 2019-01-09T11:39:47Z

Can one of the admins verify this patch?

AutorestCI · 2019-01-09T11:43:16Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#904

AutorestCI · 2019-01-09T11:43:38Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-01-09T11:54:27Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4141

AutorestCI · 2019-01-09T11:58:13Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2019-01-09T12:31:31Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4516

AutorestCI · 2019-01-09T12:35:26Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

anton-evseev · 2019-01-09T13:40:16Z

I also found throught ARMClient that this resource is available when using API version 2018-10-01. @MikhailTryakhov could you please take a look? I think we need to copy those specs to 2018-10-01

MikhailTryakhov · 2019-01-09T21:25:44Z

@jianghaolu please review, it's important fix

MikhailTryakhov

LGTM. very urgent

* Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01

* Adds base for updating Microsoft.Network from version stable/2018-11-01 to version 2018-12-01 * Updates readme * Updates API version in new specs and examples * fixing invalid paths in frontdoor (#4991) * add max bound for application gateway autoscale config (#4996) * fixing location in network samples (#4992) * Fix duplicate path in old Network API versions (#5003) * missing location in route tables (#5024) * removed confusing readonly parameters from example (#5022) * Fix errors in ddosCustomPolicy.json (#5013) * Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01 * Pick AppGw changes from 2018-11-01 (#5044) * Adding the structure of ruleSequence and conditions in rewriteRuleSets under applicationGatewayProperties (#5009) * Added Prepare action for subnet (#5058) * Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property * updated the destination address description to also include service tags (#5112) * Update for Get Application Gateway Server Variables APIs (#5113) * Changes in the existing APIs result format. * adding proxyresource to server variables APIs result * Updating applicationgateway.json * Update applicationGateway.json * add Go SDK build for 2018-12-01 * changes to pythonand ruby readme files * Update readme.ruby.md * adding jave readme changes * Minor Fix in spacing * Creating a new tag for 2018-12 version * Update readme.python.md * Update applicationGateway.json * fixing examples * examples * Fixed issue: #4721 (#5087) * Fixed issue: #4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01 * Threat Intel changes for Azure Firewall (#5143) * Threat Intel changes for Azure Firewall * Move the property to the end of the list * Fix typos in Network 2018-12-01

anton-evseev requested a review from MikhailTryakhov as a code owner January 9, 2019 11:37

azuresdkci assigned jianghaolu Jan 9, 2019

azuresdkci requested a review from jianghaolu January 9, 2019 11:38

AutorestCI mentioned this pull request Jan 9, 2019

[AutoPR network/resource-manager] Fix errors with ddosCustomPolicy.json Azure/azure-sdk-for-js#914

Merged

anton-evseev mentioned this pull request Jan 9, 2019

Fix duplicate path in old Network API versions (Network January branch) #5003

Merged

5 tasks

AutorestCI mentioned this pull request Jan 9, 2019

[AutoPR network/resource-manager] Fix errors with ddosCustomPolicy.json Azure/azure-sdk-for-python#4143

Merged

AutorestCI mentioned this pull request Jan 9, 2019

[AutoPR network/resource-manager] Fix errors with ddosCustomPolicy.json Azure/azure-sdk-for-node#4525

Merged

anton-evseev force-pushed the ddos-custom-policy branch from f786e80 to e0583d7 Compare January 9, 2019 12:31

anton-evseev force-pushed the ddos-custom-policy branch from e0583d7 to ff2c86b Compare January 9, 2019 12:42

Add ddosCustomPolicy.json to readme.md and fix spec errors

dbd13ad

anton-evseev force-pushed the ddos-custom-policy branch from ff2c86b to dbd13ad Compare January 9, 2019 13:02

anton-evseev changed the title ~~Fix errors with ddosCustomPolicy.json~~ Fix errors in ddosCustomPolicy.json Jan 9, 2019

MikhailTryakhov approved these changes Jan 9, 2019

View reviewed changes

jianghaolu approved these changes Jan 9, 2019

View reviewed changes

jianghaolu merged commit c9269db into Azure:master Jan 9, 2019

anton-evseev deleted the ddos-custom-policy branch January 10, 2019 05:30

anton-evseev added a commit to anton-evseev/azure-rest-api-specs that referenced this pull request Jan 10, 2019

Add ddosCustomPolicy.json to readme.md and fix spec errors (Azure#5008)

07046ee

This was referenced Jan 10, 2019

Fix errors in ddosCustomPolicy.json #5013

Merged

Re-generate Network SDK Azure/azure-sdk-for-net#5131

Merged

sergey-shandar pushed a commit that referenced this pull request Jan 18, 2019

Fix errors in ddosCustomPolicy.json (#5013)

9d588c8

* Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019

Add ddosCustomPolicy.json to readme.md and fix spec errors (Azure#5008)

e8f284c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix errors in ddosCustomPolicy.json #5008

Fix errors in ddosCustomPolicy.json #5008

anton-evseev commented Jan 9, 2019 •

edited

Loading

openapi-portal-comment bot commented Jan 9, 2019

azuresdkci commented Jan 9, 2019

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

anton-evseev commented Jan 9, 2019

MikhailTryakhov commented Jan 9, 2019

MikhailTryakhov left a comment

Fix errors in ddosCustomPolicy.json #5008

Fix errors in ddosCustomPolicy.json #5008

Conversation

anton-evseev commented Jan 9, 2019 • edited Loading

Contribution checklist:

ARM API Review Checklist

openapi-portal-comment bot commented Jan 9, 2019

azuresdkci commented Jan 9, 2019

AutorestCI commented Jan 9, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jan 9, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jan 9, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jan 9, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jan 9, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jan 9, 2019 • edited Loading

Automation for azure-sdk-for-java

anton-evseev commented Jan 9, 2019

MikhailTryakhov commented Jan 9, 2019

MikhailTryakhov left a comment

Choose a reason for hiding this comment

anton-evseev commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading

AutorestCI commented Jan 9, 2019 •

edited

Loading