Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version 2019-02-01-preview #5289

Merged
merged 5 commits into from
Mar 26, 2019
Merged

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version 2019-02-01-preview #5289

merged 5 commits into from
Mar 26, 2019

Conversation

paulmey
Copy link
Member

@paulmey paulmey commented Feb 27, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

Changes with 2018-02-01-preview:

  • capitalized all enum values (including discriminators) in line with other RPs
  • added ManagedImage as a source
  • added PowerShell customization step
  • added WindowsRestart customization step
  • added VHD as a distribution target

@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Feb 27, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4447

@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1788

@AutorestCI AutorestCI mentioned this pull request Feb 27, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#5017

@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3214

@AutorestCI AutorestCI mentioned this pull request Feb 27, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Feb 27, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4430

@KrisBash KrisBash added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 28, 2019
KrisBash
KrisBash suggested changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

.../Microsoft.VirtualMachineImages/preview/2019-02-01-preview/examples/CreateImageTemplate.json Show resolved Hide resolved
...resource-manager/Microsoft.VirtualMachineImages/preview/2019-02-01-preview/imagebuilder.json Show resolved Hide resolved
...resource-manager/Microsoft.VirtualMachineImages/preview/2019-02-01-preview/imagebuilder.json Show resolved Hide resolved
...resource-manager/Microsoft.VirtualMachineImages/preview/2019-02-01-preview/imagebuilder.json Show resolved Hide resolved
@KrisBash KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 28, 2019
@AutorestCI AutorestCI mentioned this pull request Feb 28, 2019
Closed
@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 28, 2019
@AutorestCI AutorestCI mentioned this pull request Feb 28, 2019
Merged
@anuchandy
Copy link
Member

anuchandy commented Mar 3, 2019 •
edited
Loading

@paulmey can we use the plural form for operation group, VirtualMachineImageTemplate_xx -> VirtualMachineImageTemplates_xx ?

anuchandy
anuchandy requested changes Mar 10, 2019
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment on using plural form for operation group.

This was referenced Mar 12, 2019
Closed
Closed
@paulmey
Copy link
Member Author

paulmey commented Mar 20, 2019

Please see the comment on using plural form for operation group.

This is done. Can we merge this so that we can start reviewing the next API version?

@anuchandy
Copy link
Member

@dsgouda should I wait for https://github.com/Azure/AzNetSdkTools/issues/133 to close before merging this?

@paulmey
Copy link
Member Author

paulmey commented Mar 21, 2019

We'll start a review for our 2019-05-01-preview version immediately after this one gets merged... so if we can carry that issue over... 😉

@dsgouda
Copy link
Contributor

dsgouda commented Mar 21, 2019

@anuchandy We are not supporting new RPs for Automation for Net Sdk today, you can proceed with the review.

This was referenced Mar 21, 2019
Closed
Closed
@paulmey
Copy link
Member Author

paulmey commented Mar 25, 2019

Please merge

@anuchandy anuchandy merged commit 713ccf7 into Azure:master Mar 26, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 26, 2019
Merged
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Mar 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@anuchandy anuchandy anuchandy approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@anuchandy anuchandy

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@paulmey @AutorestCI @azuresdkci @anuchandy @dsgouda @jhendrixMSFT @nschonni @KrisBash