LUIS runtime changes #5424
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,11 +5,52 @@ | |
| "version": "2.0" | ||
| }, | ||
| "x-ms-parameterized-host": { | ||
| "hostTemplate": "{AzureRegion}.api.cognitive.microsoft.{AzureCloud}/luis/v2.0", | ||
| "parameters": [ | ||
| { | ||
| "name": "AzureRegion", | ||
| "description": "Supported Azure regions for Cognitive Services endpoints", | ||
| "x-ms-parameter-location": "client", | ||
|
There was a problem hiding this comment. Is there a reason these are supposed to be client level parameters? There was a problem hiding this comment. @nebadr @AmirGeorge - client level params? There was a problem hiding this comment. @tsuwandy for possible input. There was a problem hiding this comment. @dsgouda We are not aware exactly why but is it causing problem? There was a problem hiding this comment. This is not necessarily a problem. We want to ensure your intent is to tie each client instance to a particular Azure region. There was a problem hiding this comment. @dsgouda Yes, this is our intent. Confirmed. |
||
| "required": true, | ||
| "type": "string", | ||
| "in": "path", | ||
| "x-ms-skip-url-encoding": true, | ||
| "x-ms-enum": { | ||
| "name": "AzureRegions", | ||
| "modelAsString": false | ||
| }, | ||
| "enum": [ | ||
| "westus", | ||
| "westeurope", | ||
| "southeastasia", | ||
| "eastus2", | ||
| "westcentralus", | ||
| "westus2", | ||
| "eastus", | ||
| "southcentralus", | ||
| "northeurope", | ||
| "eastasia", | ||
| "australiaeast", | ||
| "brazilsouth", | ||
| "virginia" | ||
| ] | ||
| }, | ||
| { | ||
| "name": "AzureCloud", | ||
| "description": "Supported Azure Clouds for Cognitive Services endpoints", | ||
| "x-ms-parameter-location": "client", | ||
| "required": true, | ||
| "type": "string", | ||
| "in": "path", | ||
| "x-ms-skip-url-encoding": true, | ||
| "x-ms-enum": { | ||
| "name": "AzureClouds", | ||
| "modelAsString": false | ||
| }, | ||
| "enum": [ | ||
| "com", | ||
| "us" | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
|
|
@@ -35,6 +76,7 @@ | |
| "name": "appId", | ||
| "in": "path", | ||
| "type": "string", | ||
| "format": "uuid", | ||
| "required": true, | ||
| "description": "The LUIS application ID (guid)." | ||
| }, | ||
|
|
@@ -74,7 +116,7 @@ | |
| { | ||
| "name": "bing-spell-check-subscription-key", | ||
| "in": "query", | ||
| "description": "The subscription key to use when enabling Bing spell check", | ||
| "type": "string" | ||
| }, | ||
| { | ||
|
|
@@ -115,6 +157,7 @@ | |
| "name": "appId", | ||
| "in": "path", | ||
| "type": "string", | ||
| "format": "uuid", | ||
| "required": true, | ||
| "description": "The LUIS application ID (Guid)." | ||
| }, | ||
|
|
@@ -155,7 +198,7 @@ | |
| { | ||
| "name": "bing-spell-check-subscription-key", | ||
| "in": "query", | ||
| "description": "The subscription key to use when enabling Bing spell check", | ||
| "type": "string" | ||
| }, | ||
| { | ||
|
|
@@ -327,7 +370,7 @@ | |
| }, | ||
| "additionalProperties": { | ||
| "type": "object", | ||
| "description": "List of additional properties. For example, score and resolution values for pre-built LUIS entities." | ||
| }, | ||
| "required": [ | ||
| "entity", | ||
|
|
@@ -406,14 +449,5 @@ | |
| } | ||
| }, | ||
| "parameters": { | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will prevent the users from using customized domain/containers.
Please revert this change.
If you believe this change is a must, we can kickstart an email thread to discuss abt this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diberry has this been addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nebadr @AmirGeorge Is this something you can address? I don't think I introduced this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsgouda @diberry this change has been reverted in the second commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nebadr - should I close this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diberry We want to merge this PR. I meant the change has been reverted here in this PR but in the second commit (this change appears to be outdated).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nebadr Do I need to pull something into this PR to fix or it is good to go as it is now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diberry No, it is good. Thanks.