-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTM billing api for getting reservation Transactions by invoice section. #5475
Merged
veronicagg
merged 8 commits into
Azure:master
from
msft-adrianma:adrianma-dev-billing-Microsoft.Billing-2018-11-01-preview
Apr 3, 2019
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
edc89ed
swagger for Get{Reservation}TransactionsByInvoiceSection.
msft-adrianma 8975935
gtm rest apis for Get{Reservation}TransactionsByInvoiceSection.
msft-adrianma ed5299b
updating operationId for tansactions to Noun_verb as per feedback.
msft-adrianma db6a90f
fixing examples
msft-adrianma c0cb8dc
fix bugs in examples.
msft-adrianma da348c1
remove more duplicates
msft-adrianma 6ce40a3
Merge branch 'master' into adrianma-dev-billing-Microsoft.Billing-201…
msft-adrianma 8aac196
fix example
msft-adrianma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
...ling/preview/2018-11-01-preview/examples/ReservationTransactionsListByInvoiceSection.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-11-01-preview", | ||
| "billingAccountId": "1234", | ||
| "invoiceSectionId": "42425", | ||
| "startDate": "2018-04-01", | ||
| "endDate": "2018-05-30", | ||
| "$filter": "properties/kind eq 'Reservation'" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/providers/Microsoft.Billing/BillingAccounts/1234/InvoiceSection/42425/transactions/transactionSummaryId1", | ||
| "name": "transactionSummaryId1", | ||
| "type": "Microsoft.Billing/transactions", | ||
| "properties": { | ||
| "kind": "reservation", | ||
| "date": "2018-04-23T00:00:00Z", | ||
| "invoice": "2344233", | ||
| "orderName": "Contoso Reserved", | ||
| "orderId": "6d8e7ed9-d3be-48b0-8c7a-e19246a6d30c", | ||
| "productDescription": "Standard D1, US West 3", | ||
| "transactionType": "Cancel", | ||
| "transactionAmount": { | ||
| "currency": "USD", | ||
| "value": 5000.00 | ||
| }, | ||
| "quantity": 4, | ||
| "invoiceSectionId": "42425", | ||
| "invoiceSectionName": "Contoso operations invoiceSection", | ||
| "billingProfileId": "789456", | ||
| "billingProfileName": "Contoso operations billing", | ||
| "subscriptionId": "789456", | ||
| "subscriptionName": "Contoso operations billing" | ||
| } | ||
| }, | ||
| { | ||
| "id": "/providers/Microsoft.Billing/BillingAccounts/1234/InvoiceSection/42425/transactions/transactionSummaryId2", | ||
| "name": "transactionSummaryId2", | ||
| "type": "Microsoft.Billing/transactions", | ||
| "properties": { | ||
| "kind": "reservation", | ||
| "date": "2018-05-05T00:00:00Z", | ||
| "invoice": "Pending", | ||
| "orderName": "MSFT Reserved", | ||
| "orderId": "1c24006f-8350-4315-ad8f-6d11180448f9", | ||
| "productDescription": "Standard D1, US West 3", | ||
| "transactionType": "Purchase", | ||
| "transactionAmount": { | ||
| "currency": "USD", | ||
| "value": 6000.00 | ||
| }, | ||
| "quantity": 5, | ||
| "invoiceSectionId": "42425", | ||
| "invoiceSectionName": "Contoso operations invoiceSection", | ||
| "billingProfileId": "789456", | ||
| "billingProfileName": "Contoso operations billing", | ||
| "subscriptionId": "789456", | ||
| "subscriptionName": "Contoso operations billing" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
...crosoft.Billing/preview/2018-11-01-preview/examples/TransactionsListByInvoiceSection.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-11-01-preview", | ||
| "billingAccountId": "1234", | ||
| "invoiceSectionId": "42425", | ||
| "startDate": "2018-04-01", | ||
| "endDate": "2018-05-30" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/providers/Microsoft.Billing/BillingAccounts/1234/InvoiceSection/42425/transactions/transactionSummaryId1", | ||
| "name": "transactionSummaryId1", | ||
| "type": "Microsoft.Billing/transactions", | ||
| "properties": { | ||
| "kind": "all", | ||
| "date": "2018-05-01T00:00:00Z", | ||
| "invoice": "2344233", | ||
| "productTypeId": "A12345", | ||
| "productType": "Reserved VM Instance", | ||
| "productDescription": "Standard D1, US West 3", | ||
| "transactionType": "Purchase", | ||
| "transactionAmount": { | ||
| "currency": "USD", | ||
| "value": 5000.00 | ||
| }, | ||
| "invoiceSectionId": "42425", | ||
| "invoiceSectionName": "Contoso operations invoiceSection", | ||
| "billingProfileId": "789456", | ||
| "billingProfileName": "Contoso operations billing" | ||
| } | ||
| }, | ||
| { | ||
| "id": "/providers/Microsoft.Billing/BillingAccounts/1234/InvoiceSection/42425/transactions/transactionSummaryId2", | ||
| "name": "transactionSummaryId2", | ||
| "type": "Microsoft.Billing/transactions", | ||
| "properties": { | ||
| "kind": "all", | ||
| "date": "2018-04-01T00:00:00Z", | ||
| "invoice": "pending", | ||
| "productTypeId": "A12345", | ||
| "productType": "VM Instance", | ||
| "productDescription": "Standard Support", | ||
| "transactionType": "Cancel", | ||
| "transactionAmount": { | ||
| "currency": "USD", | ||
| "value": 50.00 | ||
| }, | ||
| "invoiceSectionId": "42425", | ||
| "invoiceSectionName": "Contoso operations invoiceSection", | ||
| "billingProfileId": "789456", | ||
| "billingProfileName": "Contoso operations billing" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that this doesn't have a corresponding GET for a single transaction. I'm also noticing the same pattern on all the other ones that was already approved, so I can't really block based on that.
However, this is a violation of the Resource Provider Contract. Can we get that fixed?