[Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview #5486

wilcobmsft · 2019-03-26T22:45:47Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2019-03-26T22:46:19Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4423

AutorestCI · 2019-03-26T22:46:21Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3853

AutorestCI · 2019-03-26T22:46:31Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1861

AutorestCI · 2019-03-26T22:46:57Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-03-26T23:19:18Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3207

azuresdkci · 2019-03-26T23:49:34Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

adxsdknet · 2019-03-26T23:56:02Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5602
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@259be18
adxsdknet/azure-sdk-for-net@e5c0046
adxsdknet/azure-sdk-for-net@70d4b6f
adxsdknet/azure-sdk-for-net@9c74e7d

shahabhijeet · 2019-03-27T17:46:52Z

startbuild

wilcobmsft · 2019-03-27T22:44:32Z

@majastrz Can you provide ARM feedback for this please?

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

majastrz · 2019-03-28T01:13:02Z

},

Another asynchronous GET #Closed

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json:436 in 90e03b4. [](commit_id = 90e03b4, deletion_comment = False)

majastrz

Please fix the asynchronous GETs.

REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

jhendrixMSFT

Can you please also open a work item to track fixing your operation IDs? A lot of them don't follow the required noun_verb format making for awkward SDK APIs.

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

…n ids across this swagger.

REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

…llingProfile.

REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

wilcobmsft · 2019-03-28T21:44:31Z

@jhendrixMSFT Thanks - we've opened a bug to clean up the operation ids in a future PR (before we publish corresponding SDKs).

jhendrixMSFT · 2019-03-29T15:56:23Z

@AutorestCI regenerate azure-sdk-for-go

* .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit * .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit * .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit * .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

wilcobmsft added 5 commits March 26, 2019 14:42

Add elevate API.

e739ea8

Remove unnecessary comma.

45051ba

Validation fix.

db27efe

Add billingProfiles/invoiceSections.

4949029

validation fix

dd0140c

Specify empty body for 204 response in example.

183a23e

azuresdkci assigned jhendrixMSFT Mar 26, 2019

azuresdkci requested a review from jhendrixMSFT March 26, 2019 22:57

AutorestCI mentioned this pull request Mar 26, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview Azure/azure-sdk-for-go#4396

Closed

wilcobmsft added 4 commits March 26, 2019 16:03

Build fix for Java SDK.

1fd63f1

Remove $expand from billingProfiles/invoiceSections.

a2665e7

Move /elevate to top-level invoice sections resource.

a762bef

Example fix.

59680b2

AutorestCI mentioned this pull request Mar 26, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview Azure/azure-sdk-for-java#3224

Merged

Java build break.

90e03b4

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 26, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 26, 2019

.NET SDK Resource Provider:'Billing'

259be18

REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

majastrz reviewed Mar 28, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Outdated Show resolved Hide resolved

majastrz requested changes Mar 28, 2019

View reviewed changes

majastrz added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 28, 2019

Remove erroneous 202s.

96952ae

majastrz approved these changes Mar 28, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Mar 28, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 28, 2019

.NET SDK Resource Provider:'Billing'

e5c0046

REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

jhendrixMSFT requested changes Mar 28, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Outdated Show resolved Hide resolved

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Outdated Show resolved Hide resolved

Update operation ids. Opened bug MSAzure#4268142 to clean up operatio…

99c717c

…n ids across this swagger.

AutorestCI mentioned this pull request Mar 28, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview Azure/azure-sdk-for-js#1831

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 28, 2019

.NET SDK Resource Provider:'Billing'

70d4b6f

REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

jhendrixMSFT reviewed Mar 28, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Outdated Show resolved Hide resolved

InvoiceSection_ElevateToBillingProfile -> InvoiceSections_ElevateToBi…

500edc5

…llingProfile.

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 28, 2019

.NET SDK Resource Provider:'Billing'

9c74e7d

REST Spec PR 'Azure/azure-rest-api-specs#5486' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

jhendrixMSFT approved these changes Mar 28, 2019

View reviewed changes

jhendrixMSFT merged commit 98aa5b9 into Azure:master Mar 28, 2019

AutorestCI mentioned this pull request Mar 28, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview Azure/azure-sdk-for-js#1860

Merged

AutorestCI mentioned this pull request Mar 29, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview Azure/azure-sdk-for-go#4422

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview #5486

[Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview #5486

wilcobmsft commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

azuresdkci commented Mar 26, 2019

adxsdknet commented Mar 26, 2019 •

edited

Loading

shahabhijeet commented Mar 27, 2019

wilcobmsft commented Mar 27, 2019

majastrz commented Mar 28, 2019 •

edited

Loading

majastrz left a comment

jhendrixMSFT left a comment

wilcobmsft commented Mar 28, 2019

jhendrixMSFT commented Mar 29, 2019

[Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview #5486

[Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview #5486

Conversation

wilcobmsft commented Mar 26, 2019 • edited Loading

Contribution checklist:

AutorestCI commented Mar 26, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Mar 26, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 26, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Mar 26, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Mar 26, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Mar 26, 2019

adxsdknet commented Mar 26, 2019 • edited Loading

Automation for azure-sdk-for-net

shahabhijeet commented Mar 27, 2019

wilcobmsft commented Mar 27, 2019

majastrz commented Mar 28, 2019 • edited Loading

majastrz left a comment

Choose a reason for hiding this comment

jhendrixMSFT left a comment

Choose a reason for hiding this comment

wilcobmsft commented Mar 28, 2019

jhendrixMSFT commented Mar 29, 2019

wilcobmsft commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

AutorestCI commented Mar 26, 2019 •

edited

Loading

adxsdknet commented Mar 26, 2019 •

edited

Loading

majastrz commented Mar 28, 2019 •

edited

Loading