-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing assessments and assessmentsMetadata types #5649
Conversation
Automation for azure-sdk-for-rubyEncountered a Subprocess error: (azure-sdk-for-ruby)
Command: ['/usr/local/bin/autorest', '/tmp/tmp_fm5xnow/rest/specification/security/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpg3p0nx4l'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
at main (/opt/node_modules/autorest/dist/app.js:232:19)
at <anonymous>
/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
autorest_core_1.Shutdown();
^
ReferenceError: autorest_core_1 is not defined
at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
at emitOne (events.js:121:20)
at process.emit (events.js:211:7)
at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
return binding.close(fd);
^
Error: EBADF: bad file descriptor, close
at Object.fs.closeSync (fs.js:612:18)
at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
at process._fatalException (bootstrap_node.js:391:26) |
Automation for azure-sdk-for-pythonEncountered an unknown error: (azure-sdk-for-python)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
return next(self.gen)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
repo.git.checkout(branch_or_commit)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
return self.execute(call, **exec_kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
cmdline: git checkout 322d3d62eb077ce48cbf2501ca4b7ecdf716da66
stderr: 'fatal: reference is not a tree: 322d3d62eb077ce48cbf2501ca4b7ecdf716da66' |
Automation for azure-sdk-for-jsA PR has been created for you: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goEncountered an unknown error: (azure-sdk-for-go)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
return next(self.gen)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
repo.git.checkout(branch_or_commit)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
return self.execute(call, **exec_kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
cmdline: git checkout 322d3d62eb077ce48cbf2501ca4b7ecdf716da66
stderr: 'fatal: reference is not a tree: 322d3d62eb077ce48cbf2501ca4b7ecdf716da66' |
Can one of the admins verify this patch? |
@fearthecowboy I'm not sure what this modeler failure means, can you please elaborate? Oh ok I see, it's complaining because |
...ion/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessments.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following error needs to be fixed.
Swagger document contains two or more x-ms-enum extensions with the same name 'ReportedSeverity' and different values: Informational,Low,Medium,High vs. Compute,Network,Data,IdentityAndAccess,IoT
REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit
REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit
@jhendrixMSFT all you comments were resolved, can you please review again? |
@chlahav for SDK this looks good, still need ARM to sign off. Have these APIs been deployed? We can't merge until they're live. |
@jhendrixMSFT these APIs are not exposed since we need ARM review to open them in the manifest. |
startbuild |
REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit
...icrosoft.Security/preview/2019-01-01-preview/examples/Assessments/GetAssessment_example.json
Outdated
Show resolved
Hide resolved
"type": "string", | ||
"description": "Human readable description for the reason the assessment result status" | ||
}, | ||
"additionalData": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additionalData [](start = 9, length = 14)
Are these known ahead of time or completely arbitrary? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completely arbitrary,
the set of additional data keys are decided per assessment (we have more than 50 assessments and growing) and currently the set is still changing for some of the assessments.
one day it might be more stable, but we will have more types than we can easily document #Closed
"description": "Details of the resource that was assessed", | ||
"discriminator": "assessedResourceSource", | ||
"properties": { | ||
"assessedResourceSource": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assessedResourceSource [](start = 9, length = 22)
This should probably be an enum that only allows "Azure" as the value if you're using it as a discriminator. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, also added OnPremise value because one valued enum is not included in the .Net ctors and creates a breaking change when the new value is added.
we will add the relevant OnPremiseResourceDetails before the completion of this PR, but we still need to work on them #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take a look at my comments and questions?
startbuild |
REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit
Automation for azure-sdk-for-netA PR has been created for you: |
@majastrz the requested changes were pushed, can you please review? |
REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Now that #5929 has been merged into master can you please merge master into your fork to pick up those changes? |
@chlahav hello! What's the status of this PR? |
we are still working on validating the API, we will update this PR right beforehand to save you guys unnecessary reviews |
In Testing, Please Ignore[Logs] (Generated from 35998a7, Iteration 1)Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Python: Azure/azure-sdk-for-python [Logs] [Diff]
JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
|
@chlahav is this ready yet? also note there are several merge conflicts that need to be resolved. |
@chlahav can we close the PR for now since you're not ready for merge, and the PR is over 4 months, there're lots of conflict with latest code base already. Pls create new PR when you're ready for review and merge. |
Closing due to inactivity. |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.