Spec for LineOfCredit API and other corrections #6054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added specs for Agreements API in version 2018-11-01-preview
Updated as per naming convension
Corrected specs and examples for BillingRP
Fixed the errors
Fixing errors in spec
Updated examples
Incorporated review comments
Incorporated review comments
Updated the operation id for Billing spec
Incorporated review comments
Incorporated review comments
Fixed the errors
Added multiple inputs
Fixed build errors
Incorporated review comments
Spec for LineOfCredit API and other corrections
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
|
@shahabhijeet Regarding breaking changes - PUT to PATCH was a swagger mistake, our code support PATCH so I just corrected it. We may still not have any actual API usage since we have not seen any failures due to customer passing the wrong verb. |
ryansbenson
reviewed
May 24, 2019
...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
Show resolved
Hide resolved
...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
Show resolved
Hide resolved
...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
Outdated
Show resolved
Hide resolved
ryansbenson
added
the
ARMChangesRequested
Incorporated review comments
adxsdknet
added a commit
to adxsdknet/azure-sdk-for-net
that referenced
this pull request
May 24, 2019
REST Spec PR 'Azure/azure-rest-api-specs#6054' REST Spec PR Author 'asarkar84' REST Spec PR Last commit
ryansbenson
reviewed
May 24, 2019
...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
Outdated
Show resolved
Hide resolved
...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
Outdated
Show resolved
Hide resolved
ryansbenson
reviewed
May 28, 2019
...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
Outdated
Show resolved
Hide resolved
...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
Outdated
Show resolved
Hide resolved
...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
Outdated
Show resolved
Hide resolved
Incorporated review comments
adxsdknet
added a commit
to adxsdknet/azure-sdk-for-net
that referenced
this pull request
May 28, 2019
REST Spec PR 'Azure/azure-rest-api-specs#6054' REST Spec PR Author 'asarkar84' REST Spec PR Last commit
ryansbenson
reviewed
May 28, 2019
...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
Show resolved
Hide resolved
Updated the increase api
adxsdknet
added a commit
to adxsdknet/azure-sdk-for-net
that referenced
this pull request
May 28, 2019
REST Spec PR 'Azure/azure-rest-api-specs#6054' REST Spec PR Author 'asarkar84' REST Spec PR Last commit
Incorporated review comments
wilcobmsft
approved these changes
May 30, 2019
sanjaiganesh
added
ARMSignedOff
|
Please fix all the error that you see in the required jobs (public.rest-api-specs) |
Fixed error
|
@shahabhijeet All errors are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.