[FaceAPI] Add detection model argument on Detect and AddFace methods #6214

TFR258 · 2019-06-04T10:09:36Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-06-04T10:09:38Z

SDK Automation [Logs] (Generated from d7666d6)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

AutorestCI · 2019-06-04T10:10:38Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5708

AutorestCI · 2019-06-04T10:11:01Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2534

AutorestCI · 2019-06-04T10:11:04Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmphm65p0ei/rest/specification/cognitiveservices/data-plane/Face/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp94wpwb34']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-06-04T10:11:07Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3506

AutorestCI · 2019-06-04T10:12:00Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4961

azuresdkci · 2019-06-04T10:14:35Z

Can one of the admins verify this patch?

TFR258 · 2019-06-04T10:23:30Z

Spellchecker is failing due to mistake in specification/mediaservices/resource-manager/Microsoft.Media/stable/2018-07-01/Encoding.json:1200:9 -> Unknown word (speicified)

lebronJ

Approved with suggestions.

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json

TFR258 · 2019-06-05T02:18:48Z

Hi @kpajdzik, @yangyuan & @DavidLiCIG ,

There seems to have been an issue with the Automation for azure-sdk-for-java job. Can you restart it for me?

Can you also help reviewing this PR.

Thanks,
Tom

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json

lebronJ · 2019-06-05T14:57:12Z

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json

@@ -967,7 +967,7 @@
    },
    "/persongroups/{personGroupId}/persons/{personId}/persistedfaces": {
      "post": {
-        "description": "Add a face to a person into a large person group for face identification or verification. To deal with an image contains multiple faces, input face can be specified as an image with a targetFace rectangle. It returns a persistedFaceId representing the added face. No image will be stored. Only the extracted face feature will be stored on server until [LargePersonGroup PersonFace - Delete](/docs/services/563879b61984550e40cbbe8d/operations/599ae2966ac60f11b48b5aa3), [LargePersonGroup Person - Delete](/docs/services/563879b61984550e40cbbe8d/operations/599ade5c6ac60f11b48b5aa2) or [LargePersonGroup - Delete](/docs/services/563879b61984550e40cbbe8d/operations/599adc216ac60f11b48b5a9f) is called.\n<br /> Note persistedFaceId is different from faceId generated by [Face - Detect](/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395236).\n*   Higher face image quality means better recognition precision. Please consider high-quality faces: frontal, clear, and face size is 200x200 pixels (100 pixels between eyes) or bigger.\n*   Each person entry can hold up to 248 faces.\n*   JPEG, PNG, GIF (the first frame), and BMP format are supported. The allowed image file size is from 1KB to 6MB.\n*   \"targetFace\" rectangle should contain one face. Zero or multiple faces will be regarded as an error. If the provided \"targetFace\" rectangle is not returned from [Face - Detect](/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395236), there’s no guarantee to detect and add the face successfully.\n*   Out of detectable face size (36x36 - 4096x4096 pixels), large head-pose, or large occlusions will cause failures.\n*   Adding/deleting faces to/from a same person will be processed sequentially. Adding/deleting faces to/from different persons are processed in parallel.",
+        "description": "Add a face to a person into a person group for face identification or verification. To deal with an image contains multiple faces, input face can be specified as an image with a targetFace rectangle. It returns a persistedFaceId representing the added face. No image will be stored. Only the extracted face feature will be stored on server until [LargePersonGroup PersonFace - Delete](/docs/services/563879b61984550e40cbbe8d/operations/599ae2966ac60f11b48b5aa3), [LargePersonGroup Person - Delete](/docs/services/563879b61984550e40cbbe8d/operations/599ade5c6ac60f11b48b5aa2) or [LargePersonGroup - Delete](/docs/services/563879b61984550e40cbbe8d/operations/599adc216ac60f11b48b5a9f) is called.\n<br /> Note persistedFaceId is different from faceId generated by [Face - Detect](/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395236).\n*   Higher face image quality means better recognition precision. Please consider high-quality faces: frontal, clear, and face size is 200x200 pixels (100 pixels between eyes) or bigger.\n*   Each person entry can hold up to 248 faces.\n*   JPEG, PNG, GIF (the first frame), and BMP format are supported. The allowed image file size is from 1KB to 6MB.\n*   \"targetFace\" rectangle should contain one face. Zero or multiple faces will be regarded as an error. If the provided \"targetFace\" rectangle is not returned from [Face - Detect](/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395236), there’s no guarantee to detect and add the face successfully.\n*   Out of detectable face size (36x36 - 4096x4096 pixels), large head-pose, or large occlusions will cause failures.\n*   Adding/deleting faces to/from a same person will be processed sequentially. Adding/deleting faces to/from different persons are processed in parallel.\n* The minimum detectable face size is 36x36 pixels in an image no larger than 1920x1080 pixels. Images with dimensions higher than 1920x1080 pixels will need a proportionally larger minimum face size.\n* Different 'detectionModel' values can be provided. To use and compare different detection models, please refer to [How to specify a detection model](https://docs.microsoft.com/en-us/azure/cognitive-services/face/face-api-how-to-topics/specify-detection-model)\n  | Model | Recommended use-case(s) |\n  | ---------- | -------- |\n  | 'detection_01': | The default detection model for [PersonGroup Person - Add Face](/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f3039523b). Recommend for near frontal face detection. For scenarios with exceptionally large angle (head-pose) faces, occluded faces or wrong image orientation, the faces in such cases may not be detected. |\n  | 'detection_02': | Detection model released in 2019 May with improved accuracy especially on small, side and blurry faces. |",


Please take care of all the large inside this description, they should be removed.

lebronJ · 2019-06-05T14:57:37Z

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json

@@ -2539,7 +2557,7 @@
    },
    "/persongroups/{personGroupId}/persons/{personId}/persistedfaces?overload=stream": {
      "post": {
-        "description": "Add a representative face to a person for identification. The input face is specified as an image with a targetFace rectangle.",
+        "description": "Add a face to a person into a person group for face identification or verification. To deal with an image contains multiple faces, input face can be specified as an image with a targetFace rectangle. It returns a persistedFaceId representing the added face. No image will be stored. Only the extracted face feature will be stored on server until [LargePersonGroup PersonFace - Delete](/docs/services/563879b61984550e40cbbe8d/operations/599ae2966ac60f11b48b5aa3), [LargePersonGroup Person - Delete](/docs/services/563879b61984550e40cbbe8d/operations/599ade5c6ac60f11b48b5aa2) or [LargePersonGroup - Delete](/docs/services/563879b61984550e40cbbe8d/operations/599adc216ac60f11b48b5a9f) is called.\n<br /> Note persistedFaceId is different from faceId generated by [Face - Detect](/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395236).\n*   Higher face image quality means better recognition precision. Please consider high-quality faces: frontal, clear, and face size is 200x200 pixels (100 pixels between eyes) or bigger.\n*   Each person entry can hold up to 248 faces.\n*   JPEG, PNG, GIF (the first frame), and BMP format are supported. The allowed image file size is from 1KB to 6MB.\n*   \"targetFace\" rectangle should contain one face. Zero or multiple faces will be regarded as an error. If the provided \"targetFace\" rectangle is not returned from [Face - Detect](/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395236), there’s no guarantee to detect and add the face successfully.\n*   Out of detectable face size (36x36 - 4096x4096 pixels), large head-pose, or large occlusions will cause failures.\n*   Adding/deleting faces to/from a same person will be processed sequentially. Adding/deleting faces to/from different persons are processed in parallel.\n* The minimum detectable face size is 36x36 pixels in an image no larger than 1920x1080 pixels. Images with dimensions higher than 1920x1080 pixels will need a proportionally larger minimum face size.\n* Different 'detectionModel' values can be provided. To use and compare different detection models, please refer to [How to specify a detection model](https://docs.microsoft.com/en-us/azure/cognitive-services/face/face-api-how-to-topics/specify-detection-model)\n  | Model | Recommended use-case(s) |\n  | ---------- | -------- |\n  | 'detection_01': | The default detection model for [PersonGroup Person - Add Face](/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f3039523b). Recommend for near frontal face detection. For scenarios with exceptionally large angle (head-pose) faces, occluded faces or wrong image orientation, the faces in such cases may not be detected. |\n  | 'detection_02': | Detection model released in 2019 May with improved accuracy especially on small, side and blurry faces. |",


lebronJ

LGTM.

TFR258 · 2019-06-06T07:34:28Z

Hi @kpajdzik ,

This PR is ready to ship =)

The automation for Automation for azure-sdk-for-java failed. Can you help restarting it?

Thanks

kpajdzik · 2019-06-06T15:48:49Z

Hi @kpajdzik ,

This PR is ready to ship =)

The automation for Automation for azure-sdk-for-java failed. Can you help restarting it?

Thanks

Java's generator has some problem with cognitive services Swagger. The owners still can generate the SDKs with manual adjustments so don't worry about it.

[FaceAPI] Add detection model argument on Detect and AddFace methods

1d8183d

TFR258 requested review from DavidLiCIG and yangyuan as code owners June 4, 2019 10:09

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR cognitiveservices/data-plane/Face] [FaceAPI] Add detection model argument on Detect and AddFace methods Azure/azure-sdk-for-python#5667

Merged

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR cognitiveservices/data-plane/Face] [FaceAPI] Add detection model argument on Detect and AddFace methods Azure/azure-sdk-for-ruby#2533

Merged

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR cognitiveservices/data-plane/Face] [FaceAPI] Add detection model argument on Detect and AddFace methods Azure/azure-sdk-for-js#3430

Closed

azuresdkci assigned kpajdzik Jun 4, 2019

azuresdkci requested a review from kpajdzik June 4, 2019 10:11

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR cognitiveservices/data-plane/Face] [FaceAPI] Add detection model argument on Detect and AddFace methods Azure/azure-sdk-for-go#4949

Merged

lebronJ approved these changes Jun 4, 2019

View reviewed changes

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json Outdated Show resolved Hide resolved

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json Show resolved Hide resolved

Update detect and detection model-related descriptions

4ef1c81

lebronJ suggested changes Jun 5, 2019

View reviewed changes

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json Outdated Show resolved Hide resolved

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json Outdated Show resolved Hide resolved

[FaceAPI] Amend DetectionModel parameter description

3445d5c

lebronJ reviewed Jun 5, 2019

View reviewed changes

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json Show resolved Hide resolved

[FaceAPI] Make Add Faces description consistent accross multiple calls

7c460c4

lebronJ reviewed Jun 5, 2019

View reviewed changes

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json Outdated Show resolved Hide resolved

specification/cognitiveservices/data-plane/Face/stable/v1.0/Face.json Outdated Show resolved Hide resolved

[FaceAPI] Correct description of PersonGroup Person - Add Face

11957f5

lebronJ suggested changes Jun 5, 2019

View reviewed changes

kpajdzik approved these changes Jun 5, 2019

View reviewed changes

[FaceAPI] Remove all mentions of large groups in persongroup description

d7666d6

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR cognitiveservices/data-plane/Face] [FaceAPI] Add detection model argument on Detect and AddFace methods Azure/azure-sdk-for-js#3503

Merged

lebronJ approved these changes Jun 6, 2019

View reviewed changes

kpajdzik merged commit 2d45351 into Azure:master Jun 6, 2019

lebronJ mentioned this pull request Jun 11, 2019

[FaceAPI] Add detection model parameter Azure/azure-sdk-for-net#6522

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FaceAPI] Add detection model argument on Detect and AddFace methods #6214

[FaceAPI] Add detection model argument on Detect and AddFace methods #6214

TFR258 commented Jun 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

azuresdkci commented Jun 4, 2019

TFR258 commented Jun 4, 2019

lebronJ left a comment

TFR258 commented Jun 5, 2019

lebronJ Jun 5, 2019

lebronJ Jun 5, 2019

lebronJ left a comment

TFR258 commented Jun 6, 2019

kpajdzik commented Jun 6, 2019

[FaceAPI] Add detection model argument on Detect and AddFace methods #6214

[FaceAPI] Add detection model argument on Detect and AddFace methods #6214

Conversation

TFR258 commented Jun 4, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 4, 2019 • edited Loading

SDK Automation [Logs] (Generated from d7666d6)

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jun 4, 2019

TFR258 commented Jun 4, 2019

lebronJ left a comment

Choose a reason for hiding this comment

TFR258 commented Jun 5, 2019

lebronJ Jun 5, 2019

Choose a reason for hiding this comment

lebronJ Jun 5, 2019

Choose a reason for hiding this comment

lebronJ left a comment

Choose a reason for hiding this comment

TFR258 commented Jun 6, 2019

kpajdzik commented Jun 6, 2019

TFR258 commented Jun 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading