Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set IoTSecuritySolutions & IoTSecuritySolutionAnalytics API as stable #6766

Merged
merged 6 commits into from
Jul 31, 2019
Merged

Set IoTSecuritySolutions & IoTSecuritySolutionAnalytics API as stable #6766

merged 6 commits into from
Jul 31, 2019

Conversation

hagba
Copy link
Contributor

@hagba hagba commented Jul 29, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from dea80a5, Iteration 8)

Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Jul 29, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5709

@AutorestCI AutorestCI mentioned this pull request Jul 29, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5389

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 29, 2019
Merged
@hagba hagba added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 29, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@majastrz majastrz added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 29, 2019
majastrz
majastrz requested changes Jul 29, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments. Please take a look and make changes.

@hagba hagba removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 30, 2019
@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 31, 2019
majastrz
majastrz approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@amarzavery amarzavery merged commit d7d9b6d into Azure:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarzavery amarzavery amarzavery approved these changes

@majastrz majastrz majastrz approved these changes

Assignees

@amarzavery amarzavery

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hagba @AutorestCI @azuresdkci @amarzavery @majastrz