Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add change feed properties to 2019-04-01 Storage. #7049

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Add change feed properties to 2019-04-01 Storage. #7049

merged 1 commit into from
Sep 6, 2019

Conversation

tonykjose
Copy link
Contributor

@tonykjose tonykjose commented Aug 27, 2019 •
edited
Loading

Add change feed properties to Storage Blob Services.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@tonykjose
Add change feed properties to 2019-04-01 Storage.
7743674 
Add change feed properties to Storage Blob Services.
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 27, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 7743674, Iteration 2)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Failed Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]
  • No packages generated.

@AutorestCI AutorestCI mentioned this pull request Aug 27, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 27, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6885

This was referenced Aug 27, 2019
Merged
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Aug 27, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 27, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5707

@weidongxu-microsoft
Copy link
Member

Is this a readonly property, or not?

If not, it might break GET-PUT pipeline. https://microsoft.sharepoint.com/:w:/t/azureresourcemanagerteam/EWXsAQ1yx25KkyYCeeWGUgwBSBxEdUDEbHi6FZ__U8EOQw?rtime=oPAFQY8Z10g

@weidongxu-microsoft weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 28, 2019
@tonykjose
Copy link
Contributor Author

tonykjose commented Aug 28, 2019 via email

@weidongxu-microsoft
Copy link
Member

@tonykjose So if user1 with latest SDK call PUT and set the property to false, and then user2 with old SDK call GET, change some other property, then PUT without this property, it will stay false. Then I think it should be fine.

I think I still need ARM signoff.

@tonykjose
Copy link
Contributor Author

tonykjose commented Aug 28, 2019 via email

KrisBash
KrisBash approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see one comment, but signing off

specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/blob.json
"ChangeFeed": {
"properties": {
"enabled": {
"type": "boolean",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

booleans are less preferred as it becomes a breaking change if you need to change to an enum later. If you model this as something like '"state":[enabled|disabled]' you can add tertiary states to the enum later, without a breaking change. Something to consider.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 6, 2019
@weidongxu-microsoft
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@weidongxu-microsoft weidongxu-microsoft merged commit 35ae8d5 into Azure:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

Assignees

@weidongxu-microsoft weidongxu-microsoft

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tonykjose @AutorestCI @azuresdkci @weidongxu-microsoft @KrisBash