-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY FOR DESIGN REVIEW] -> MachineLearningServices: Adding new API version and definition for AmlInstance compute type #7323
Conversation
Adding new version 2019-11-01
In Testing, Please Ignore[Logs] (Generated from 9a2ab25, Iteration 36).NET: test-repo-billy/azure-sdk-for-net [Logs]
Go: test-repo-billy/azure-sdk-for-go [Logs]
Python: test-repo-billy/azure-sdk-for-python [Logs]
JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you: |
Can one of the admins verify this patch? |
Hi @vhamine, why do you send a PR in draft? Are you ready for review process? |
|
The PR is not ready for review yet as I am still making changes. This being my first interaction with azure rest API specification, I thought I should create a draft PR and get familiar with the pipeline checks. I plan to attend the office hours today and send a PR for review by EOD. Thanks! |
…g applicationURIs from connectivityEndpoints
...ager/Microsoft.MachineLearningServices/stable/2019-11-01/examples/createComputeInstance.json
Show resolved
Hide resolved
...rce-manager/Microsoft.MachineLearningServices/stable/2019-11-01/machineLearningServices.json
Show resolved
Hide resolved
...rce-manager/Microsoft.MachineLearningServices/stable/2019-11-01/machineLearningServices.json
Outdated
Show resolved
Hide resolved
...rce-manager/Microsoft.MachineLearningServices/stable/2019-11-01/machineLearningServices.json
Outdated
Show resolved
Hide resolved
...rce-manager/Microsoft.MachineLearningServices/stable/2019-11-01/machineLearningServices.json
Outdated
Show resolved
Hide resolved
Hi @vhamine, I have a look at your swagger specification. It looks good to me and I already approved for your PR. All review process is completed before clicking the merge button. |
1. Updating the ComputeInstance state list 2. Changing the return type for CI start, stop, and restart operations
Hi @vhamine, Can we know what is this PR status as it is existing for a long time? |
This PR is not required any more. Can you close it? |
Hi, @vhamine. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.