Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failover Database Readable Secondary #7405

Merged
merged 8 commits into from
Oct 29, 2019
Merged

Failover Database Readable Secondary #7405

merged 8 commits into from
Oct 29, 2019

Conversation

emgu-ms
Copy link
Contributor

@emgu-ms emgu-ms commented Oct 4, 2019

Latest improvements:

Add swagger changes for failover databases readable secondary

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@emgu-ms emgu-ms requested a review from jaredmoo as a code owner October 4, 2019 21:53
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 4, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from edb7b3d, Iteration 4)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
In-Progress Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • Package generation in progress.

@AutorestCI AutorestCI mentioned this pull request Oct 4, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 4, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpqt8rhn2x/rest/specification/sql/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpcl1ppy8h']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@emgu-ms emgu-ms changed the title Failover Database Readable Secondary Failover Database Readable Secondary [DO NOT MERGE] Oct 4, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 4, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 5, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6184

@AutorestCI AutorestCI mentioned this pull request Oct 5, 2019
Closed
@emgu-ms emgu-ms changed the title Failover Database Readable Secondary [DO NOT MERGE] Failover Database Readable Secondary Oct 8, 2019
@emgu-ms
Copy link
Contributor Author

emgu-ms commented Oct 8, 2019

Ready to be merged as its now been deployed to some clusters

@AutorestCI AutorestCI mentioned this pull request Oct 9, 2019
Closed
sergey-shandar
sergey-shandar reviewed Oct 15, 2019
View reviewed changes
...ication/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/FailoverDatabases.json
@@ -37,6 +37,21 @@
"required": true,
"type": "string"
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, append new parameters to the end of the parameter array.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generated file so we can't move this to the end of the parameter array

@sergey-shandar sergey-shandar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Oct 15, 2019
KrisBash
KrisBash approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 18, 2019
@sergey-shandar sergey-shandar merged commit 5349a57 into Azure:master Oct 29, 2019
@AutorestCI AutorestCI mentioned this pull request Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar left review comments

@jaredmoo jaredmoo jaredmoo approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@sergey-shandar sergey-shandar

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emgu-ms @AutorestCI @azuresdkci @sergey-shandar @jaredmoo @KrisBash