[Azure Cognitive Search] Rename Track 2 models and add missing property #7936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Azure API review feedback, we're renaming some Result types from <model><operation>Result to <operation><model>Result. Also, the @search.coverage property of AutocompleteResult was missing from the spec. Note that it's not actually supported by the service yet, but will be added in the near future.
|
Azure Pipelines successfully started running 1 pipeline(s). |
brjohnstmsft
requested review from
jhendrixMSFT,
navalev,
JonathanGiles,
arv100kri and
bleroy
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
bleroy
approved these changes
Dec 11, 2019
|
@brjohnstmsft are we still waiting for reviews from others? |
|
@jhendrixMSFT Nope, this is ready to merge |
jhendrixMSFT
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Azure API review feedback, we're renaming some Result types from
<model><operation>Resultto<operation><model>Result.Also, the
@search.coverageproperty ofAutocompleteResultwas missing from the spec. Note that it's not actually supported by the service yet, but will be added in the near future.FYI @jhendrixMSFT -- This applies to our Track 2 specs only, and our first Track 2 SDK has not shipped yet, so this won't actually break any customers.
FYI @JonathanGiles -- Please review and let me know if the names make sense from an API guidelines perspective.
FYI @navalev @itye-msft -- Please ensure these changes are reflected correctly in the generated Java SDK code.
FYI @arv100kri @bleroy -- Just making sure you're aware of these changes for Track 2.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.