Add identity property to service resource #8017

feordin · 2019-12-20T20:04:48Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

None of the below apply, nothing has been removed and no new service added, we are adding one additional property to a resource

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2019-12-20T20:05:08Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-20T20:07:03Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 14f40d1 with merge commit 3e6f0b6. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-healthcareapis [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2019-12-20T20:07:04Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 14f40d1 with merge commit 3e6f0b6. SDK Automation 13.0.17.20191226.1
️✔️healthcareapis/mgmt/2019-09-16 [Logs] [Release SDK Changes]
- healthcareapis.mgmt.2019-09-16.zip
️✔️preview/healthcareapis/mgmt/2018-08-20-preview [Logs] [Release SDK Changes]
- preview.healthcareapis.mgmt.2018-08-20-preview.zip

openapi-sdkautomation · 2019-12-20T20:07:05Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 14f40d1 with merge commit 3e6f0b6. SDK Automation 13.0.17.20191226.1

⚠️sdk/healthcareapis/mgmt-v2018_08_20_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/healthcareapis/mgmt-v2018_08_20_preview/src/main/java/com/microsoft/azure/management/healthcareapis/v2018_08_20_preview/implementation/ServicesInner.java:[19,73] cannot find symbol
[mvn]   symbol:   class ErrorDetailsInnerException
[mvn]   location: package com.microsoft.azure.management.healthcareapis.v2018_08_20_preview
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/healthcareapis/mgmt-v2018_08_20_preview/src/main/java/com/microsoft/azure/management/healthcareapis/v2018_08_20_preview/implementation/OperationsInner.java:[15,73] cannot find symbol
[mvn]   symbol:   class ErrorDetailsInnerException
[mvn]   location: package com.microsoft.azure.management.healthcareapis.v2018_08_20_preview
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/healthcareapis/mgmt-v2018_08_20_preview/src/main/java/com/microsoft/azure/management/healthcareapis/v2018_08_20_preview/implementation/OperationResultsInner.java:[13,73] cannot find symbol
[mvn]   symbol:   class ErrorDetailsInnerException
[mvn]   location: package com.microsoft.azure.management.healthcareapis.v2018_08_20_preview
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-healthcareapis: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/healthcareapis/mgmt-v2018_08_20_preview/src/main/java/com/microsoft/azure/management/healthcareapis/v2018_08_20_preview/implementation/ServicesInner.java:[19,73] cannot find symbol
[mvn] [ERROR]   symbol:   class ErrorDetailsInnerException
[mvn] [ERROR]   location: package com.microsoft.azure.management.healthcareapis.v2018_08_20_preview
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/healthcareapis/mgmt-v2018_08_20_preview/src/main/java/com/microsoft/azure/management/healthcareapis/v2018_08_20_preview/implementation/OperationsInner.java:[15,73] cannot find symbol
[mvn] [ERROR]   symbol:   class ErrorDetailsInnerException
[mvn] [ERROR]   location: package com.microsoft.azure.management.healthcareapis.v2018_08_20_preview
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/healthcareapis/mgmt-v2018_08_20_preview/src/main/java/com/microsoft/azure/management/healthcareapis/v2018_08_20_preview/implementation/OperationResultsInner.java:[13,73] cannot find symbol
[mvn] [ERROR]   symbol:   class ErrorDetailsInnerException
[mvn] [ERROR]   location: package com.microsoft.azure.management.healthcareapis.v2018_08_20_preview
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/healthcareapis/mgmt-v2019-09-16 [Logs] [Release SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-healthcareapis: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - javadoc: error - Illegal package name: "com.microsoft.azure.management.healthcareapis.v2019-09-16"
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/healthcareapis/mgmt-v2019-09-16/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

openapi-sdkautomation · 2019-12-20T20:07:10Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 14f40d1 with merge commit 3e6f0b6. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-healthcareapis [Logs] [Release SDK Changes]

azure-arm-healthcareapis-1.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/healthcareApisManagementClient.js → ./dist/arm-healthcareapis.js...
[npmPack] created ./dist/arm-healthcareapis.js in 268ms

openapi-sdkautomation · 2019-12-20T20:07:14Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 14f40d1 with merge commit 3e6f0b6. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

❌Microsoft.Azure.Management.HealthcareApis [Logs] [Release SDK Changes]

Failed to create the package Microsoft.Azure.Management.HealthcareApis.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=healthcareapis /v:n /p:SkipTests=true , {}

azuresdkci · 2019-12-20T20:32:27Z

Can one of the admins verify this patch?

...lthcareapis/resource-manager/Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json

yungezz · 2020-01-06T01:38:32Z

pinging ARM for feedback.

yungezz · 2020-01-07T05:15:23Z

/azp run

azure-pipelines · 2020-01-07T05:15:44Z

Azure Pipelines successfully started running 3 pipeline(s).

yungezz · 2020-01-07T05:25:53Z

hi @NullMDR could you pls help to look at the SDK Net task failure? thanks.

PhoenixHe-NV · 2020-01-07T07:30:02Z

@yungezz It could be ignored as .net SDK owner said. I'll suppress this failure later.

azure-pipelines · 2020-01-07T17:08:17Z

Azure Pipelines successfully started running 1 pipeline(s).

feordin added 2 commits December 20, 2019 11:49

Add Identity property to the healthcareapis resource

013f305

Update description on identity type

99ba706

azuresdkci assigned yungezz Dec 20, 2019

azuresdkci requested a review from yungezz December 20, 2019 20:05

yungezz reviewed Dec 23, 2019

View reviewed changes

...lthcareapis/resource-manager/Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json Outdated Show resolved Hide resolved

...lthcareapis/resource-manager/Microsoft.HealthcareApis/stable/2019-09-16/healthcare-apis.json Show resolved Hide resolved

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 23, 2019

anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 6, 2020

Change enum to model as string

14f40d1

yungezz approved these changes Jan 8, 2020

View reviewed changes

yungezz merged commit 3e6f0b6 into Azure:master Jan 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add identity property to service resource #8017

Add identity property to service resource #8017

feordin commented Dec 20, 2019

azure-pipelines bot commented Dec 20, 2019

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading

azuresdkci commented Dec 20, 2019

yungezz commented Jan 6, 2020

yungezz commented Jan 7, 2020

azure-pipelines bot commented Jan 7, 2020

yungezz commented Jan 7, 2020

PhoenixHe-NV commented Jan 7, 2020

azure-pipelines bot commented Jan 7, 2020

Add identity property to service resource #8017

Add identity property to service resource #8017

Conversation

feordin commented Dec 20, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Dec 20, 2019

openapi-sdkautomation bot commented Dec 20, 2019 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Dec 20, 2019 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Dec 20, 2019 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Dec 20, 2019 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Dec 20, 2019 • edited Loading

azure-sdk-for-net - Release

azuresdkci commented Dec 20, 2019

yungezz commented Jan 6, 2020

yungezz commented Jan 7, 2020

azure-pipelines bot commented Jan 7, 2020

yungezz commented Jan 7, 2020

PhoenixHe-NV commented Jan 7, 2020

azure-pipelines bot commented Jan 7, 2020

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 20, 2019 •

edited

Loading