Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition #8257

Merged
merged 1 commit into from
Jan 30, 2020
Merged

[AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition #8257

merged 1 commit into from
Jan 30, 2020

Conversation

rakku-ms
Copy link
Contributor

…nDefinition

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@rakku-ms rakku-ms requested a review from bganapa January 30, 2020 00:47
@bganapa bganapa merged commit 4691c2a into Azure:stackadmin Jan 30, 2020
viananth added a commit to viananth/azure-rest-api-specs that referenced this pull request Mar 31, 2020
@viananth
commit 4691c2a
e86758c 
Author: Rakesh Kumar <[email protected]>
Date:   Wed Jan 29 17:46:01 2020 -0800

    [AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition (Azure#8257)

commit 9e551f0
Author: bganapa <[email protected]>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (Azure#7766)
njuCZ pushed a commit that referenced this pull request Aug 13, 2020
@viananth
[Azure Stack] Updates to User-Subscriptions Spec (#8914)
1b430eb 
* commit 4691c2a
Author: Rakesh Kumar <[email protected]>
Date:   Wed Jan 29 17:46:01 2020 -0800

    [AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition (#8257)

commit 9e551f0
Author: bganapa <[email protected]>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (#7766)

* Fix sub def in example

* Address PR comments

* Fix model validation error

* Fix prettier issue
innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020
@viananth @innosam
[Azure Stack] Updates to User-Subscriptions Spec (Azure#8914)
4a9731b 
* commit 4691c2a
Author: Rakesh Kumar <[email protected]>
Date:   Wed Jan 29 17:46:01 2020 -0800

    [AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition (Azure#8257)

commit 9e551f0
Author: bganapa <[email protected]>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (Azure#7766)

* Fix sub def in example

* Address PR comments

* Fix model validation error

* Fix prettier issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bganapa bganapa bganapa approved these changes

Assignees

@allenjzhang allenjzhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakku-ms @bganapa @allenjzhang