Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2019-06-01-preview API version for AAD Admin on Azure SQL Server #8340

Merged
merged 8 commits into from
Feb 22, 2020

Conversation

amolagar5
Copy link
Contributor

@amolagar5 amolagar5 commented Feb 7, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fengzhou-msft fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 8, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 11, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 11, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from d4a1890 with merge commit f4e7ef1. SDK Automation 13.0.17.20191226.1
  • ️✔️sdk/sql/mgmt-v2014_04_01 [Logs]  [Release SDK Changes]
  • ️✔️sdk/sql/mgmt-v2015_05_01_preview [Logs]  [Release SDK Changes]
  • ⚠️sdk/sql/mgmt-v2017_03_01_preview [Logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[30,147] cannot find symbol
      [mvn]   symbol:   class UUID
      [mvn]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[43,192] cannot find symbol
      [mvn]   symbol:   class UUID
      [mvn]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/SensitivityLabelsImpl.java:[59,172] cannot find symbol
      [mvn]   symbol:   class SensitivityLabelSource
      [mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.SensitivityLabelsImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,158] cannot find symbol
      [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,117] cannot find symbol
      [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[47,154] cannot find symbol
      [mvn]   symbol:   class UUID
      [mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[63,199] cannot find symbol
      [mvn]   symbol:   class UUID
      [mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[30,147] cannot find symbol
      [mvn] [ERROR]   symbol:   class UUID
      [mvn] [ERROR]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[43,192] cannot find symbol
      [mvn] [ERROR]   symbol:   class UUID
      [mvn] [ERROR]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/SensitivityLabelsImpl.java:[59,172] cannot find symbol
      [mvn] [ERROR]   symbol:   class SensitivityLabelSource
      [mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.SensitivityLabelsImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,158] cannot find symbol
      [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,117] cannot find symbol
      [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[47,154] cannot find symbol
      [mvn] [ERROR]   symbol:   class UUID
      [mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[63,199] cannot find symbol
      [mvn] [ERROR]   symbol:   class UUID
      [mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/sql/mgmt-v2017_10_01_preview [Logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,167] cannot find symbol
        [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,126] cannot find symbol
        [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,167] cannot find symbol
        [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,126] cannot find symbol
        [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/sql/mgmt-v2018_06_01_preview [Logs]  [Release SDK Changes]
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2018_06_01_preview/src/main/java/com/microsoft/azure/management/sql/v2018_06_01_preview/implementation/ManagedDatabaseSensitivityLabelsImpl.java:[68,182] cannot find symbol
          [mvn]   symbol:   class SensitivityLabelSource
          [mvn]   location: class com.microsoft.azure.management.sql.v2018_06_01_preview.implementation.ManagedDatabaseSensitivityLabelsImpl
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2018_06_01_preview/src/main/java/com/microsoft/azure/management/sql/v2018_06_01_preview/implementation/ManagedDatabaseSensitivityLabelsImpl.java:[68,182] cannot find symbol
          [mvn] [ERROR]   symbol:   class SensitivityLabelSource
          [mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2018_06_01_preview.implementation.ManagedDatabaseSensitivityLabelsImpl
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Feb 11, 2020

        azure-sdk-for-js - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from d4a1890 with merge commit f4e7ef1. SDK Automation 13.0.17.20191226.1
        • ️✔️@azure/arm-sql [Logs]  [Release SDK Changes]
          [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
          [npmPack] loaded rollup.config.js with warnings
          [npmPack] (!) Unused external imports
          [npmPack] default imported from external module 'rollup' but never used
          [npmPack] 
          [npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
          [npmPack] created ./dist/arm-sql.js in 1.8s

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Feb 11, 2020

        azure-sdk-for-net - Release

        🔄 inProgress [Logs] [Expand Details]
        • 🔄 Generate from d4a1890 with merge commit f4e7ef1. SDK Automation 13.0.17.20191226.1

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Feb 11, 2020

        azure-sdk-for-python - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from d4a1890 with merge commit f4e7ef1. SDK Automation 13.0.17.20191226.1
        • ️✔️azure-mgmt-sql [Logs]  [Release SDK Changes]
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        2 similar comments
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @amolagar5
        Copy link
        Contributor Author

        Please take a look as possible. All issues have been resolved.

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        Copy link
        Contributor

        @ravbhatnagar ravbhatnagar left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        @amolagar5 - few comments.

        }
        }
        },
        "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/disableAzureADOnlyAuthentication": {
        Copy link
        Contributor

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        why is there a POST action to disable this? its a property on the resource type, and so can be updated via a PATCH.

        Copy link
        Contributor Author

        @amolagar5 amolagar5 Feb 21, 2020

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        its not for patch. its an action. and had no body, only updates a value implicitly.
        Eventually customers will use RBAC to assign it in different roles. like$role.NotActions.Remove("Microsoft.Sql/servers/disableAzureADOnlyAuthentication/action")

        Copy link
        Contributor

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        OK, looks like different RBAC may be needed to allow modifying this property - someone may not have /write access on the resource but they can still update this property.

        Copy link
        Contributor Author

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        yes. that is the intention here. to keep permissions separate for setting and un-setting that value.

        @ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 21, 2020
        @ravbhatnagar
        Copy link
        Contributor

        signing off from ARM side.

        @ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 21, 2020
        @amolagar5 amolagar5 changed the title Add 2019-06-01-preview API version for AAD Admin on SQL Server Add 2019-06-01-preview API version for AAD Admin on Azure SQL Server Feb 22, 2020
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @fengzhou-msft fengzhou-msft merged commit f4e7ef1 into Azure:master Feb 22, 2020
        00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        4 participants