Added Swagger for some New API related to Private Endpoint work #8587

deymadhumanti · 2020-03-04T07:00:17Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2020-03-04T07:00:32Z

Can one of the admins verify this patch?

azure-pipelines · 2020-03-04T07:00:34Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-04T07:02:03Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 10fb274 with merge commit 3937487. SDK Automation 13.0.17.20200320.2
⚠️recoveryservices/mgmt/2016-06-01 [Logs]
```
No file is changed.
```
⚠️recoveryservices/mgmt/2016-12-01 [Logs]
```
No file is changed.
```
⚠️recoveryservices/mgmt/2017-07-01 [Logs]
```
No file is changed.
```
⚠️recoveryservices/mgmt/2019-05-13 [Logs]
```
No file is changed.
```
️✔️recoveryservices/mgmt/2019-06-15 [Logs] [Release SDK Changes]
- recoveryservices.mgmt.2019-06-15.zip

openapi-sdkautomation · 2020-03-04T07:02:05Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 10fb274 with merge commit 3937487. SDK Automation 13.0.17.20200320.2
️✔️Microsoft.Azure.Management.RecoveryServices.Backup [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.RecoveryServices.Backup.4.0.1-preview.nupkg
- Microsoft.Azure.Management.RecoveryServices.Backup.4.0.1-preview.snupkg

openapi-sdkautomation · 2020-03-04T07:02:06Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 10fb274 with merge commit 3937487. SDK Automation 13.0.17.20200320.2

️✔️@azure/arm-recoveryservicesbackup [Logs] [Release SDK Changes]

azure-arm-recoveryservicesbackup-5.0.0.tgz

[npmPack] npm WARN lifecycle @azure/[email protected]~prepack: cannot run in wd @azure/[email protected] npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/recoveryservicesbackup/arm-recoveryservicesbackup)

openapi-sdkautomation · 2020-03-04T07:02:06Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 10fb274 with merge commit 3937487. SDK Automation 13.0.17.20200320.2
️✔️sdk/recoveryservices.backup/mgmt-v2016_08_10 [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-03-04T07:06:51Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 10fb274 with merge commit 3937487. SDK Automation 13.0.17.20200320.2

️✔️azure-mgmt-recoveryservicesbackup [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 2.396% size of original (original: 218410 chars, delta: 5233 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation BackupResourceVaultConfigsOperations.put
[ChangeLog]   - Added operation group RecoveryServicesBackupClientOperationsMixin
[ChangeLog]   - Added operation group PrivateEndpointConnectionOperations

azure-pipelines · 2020-03-04T10:36:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-04T12:17:37Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-05T11:31:28Z

Azure Pipelines successfully started running 1 pipeline(s).

akning-ms · 2020-03-05T13:31:28Z

Hi deymadhumanti Not sure whether your PR is ready for review as there is some validation error to fix. if not ready, you can put lable 'NotReadyForReview' until it is ready. Thanks

azure-pipelines · 2020-03-06T06:24:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-06T09:01:31Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-06T09:26:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-10T05:58:08Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-10T06:52:41Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-12T07:17:46Z

Azure Pipelines successfully started running 1 pipeline(s).

anthony-c-martin · 2020-03-16T16:40:36Z

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2020-02-02/bms.json

+        }
+      }
+    },
+    "/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}/operationsStatus/{operationId}": {


Please see
https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html#common-issues-found-in-review
"Operation results as a child resource"

Does this apply for operationStatus as well ? Also, this is the pattern we used for all other async operations in recovery services. Can we keep this consistent to existing async apis?

anthony-c-martin · 2020-03-16T16:41:37Z

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2020-02-02/bms.json

+    "application/json"
+  ],
+  "paths": {
+    "/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}": {


Please include a "list" API for privateEndpointConnections

Yes we need to add, since vault properties has the list already. That is the way portal/private link center will call. List was just an auxillary api. Given we had to deliver on tight deadlines, we added min set. We have this as action item and will do it post this release. Will that work?

anthony-c-martin · 2020-03-20T20:58:05Z

List API will be added shortly, and I've recommended a pattern to follow going forwards for async operations. Signing off on this change.

openapi-sdkautomation · 2020-03-23T07:30:10Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

…e#8587) * Added a new Package version for private endpoint related API * Resolved PR comments * deleted capital BMS.json * Fixed PR validation failures * deleted request body from json * Added swagger for Get and List PrivateLinkResource API * Resolved Model validation failures as part of PR validation * Fixed LintDiff validation * Fixed SpellCheck validation * undoing RRP side changes * Want to Run Python SDK * Fixed PrettierCheck failures Co-authored-by: deymadhumanti <[email protected]>

deymadhumanti added 2 commits March 2, 2020 17:55

Added a new Package version for private endpoint related API

a3281d5

Resolved PR comments

9f47bf3

openapi-assignment-bot bot assigned akning-ms Mar 4, 2020

openapi-sdkautomation bot mentioned this pull request Mar 4, 2020

[AutoPR sdk/recoveryservices.backup/mgmt-v2016_08_10] Added Swagger for some New API related to Private Endpoint work AzureSDKAutomation/azure-sdk-for-java#1881

Closed

deymadhumanti added 2 commits March 4, 2020 16:01

deleted capital BMS.json

3289ffa

Fixed PR validation failures

bcab54a

deleted request body from json

bbba31d

Added swagger for Get and List PrivateLinkResource API

095906a

akning-ms added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 5, 2020

Resolved Model validation failures as part of PR validation

d41ec12

sumitmal2711 added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Mar 6, 2020

Fixed LintDiff validation

e3dfeae

Fixed SpellCheck validation

cb338c3

undoing RRP side changes

3f6f148

Want to Run Python SDK

92dd30b

Fixed PrettierCheck failures

10fb274

sumitmal2711 removed the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Mar 12, 2020

anthony-c-martin requested changes Mar 16, 2020

View reviewed changes

anthony-c-martin added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 16, 2020

anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Mar 20, 2020

sumitmal2711 requested a review from anthony-c-martin March 23, 2020 06:12

akning-ms merged commit 3937487 into Azure:master Mar 23, 2020

deymadhumanti mentioned this pull request Mar 27, 2020

Added swagger for private link resource API #8655

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Swagger for some New API related to Private Endpoint work #8587

Added Swagger for some New API related to Private Endpoint work #8587

deymadhumanti commented Mar 4, 2020

azuresdkci commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 5, 2020

akning-ms commented Mar 5, 2020

azure-pipelines bot commented Mar 6, 2020

azure-pipelines bot commented Mar 6, 2020

azure-pipelines bot commented Mar 6, 2020

azure-pipelines bot commented Mar 10, 2020

azure-pipelines bot commented Mar 10, 2020

azure-pipelines bot commented Mar 12, 2020

anthony-c-martin Mar 16, 2020

sumitmal2711 Mar 16, 2020

anthony-c-martin Mar 16, 2020

sumitmal2711 Mar 16, 2020 •

edited

Loading

anthony-c-martin commented Mar 20, 2020

openapi-sdkautomation bot commented Mar 23, 2020 •

edited

Loading

Added Swagger for some New API related to Private Endpoint work #8587

Added Swagger for some New API related to Private Endpoint work #8587

Conversation

deymadhumanti commented Mar 4, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Mar 4, 2020 • edited Loading

azure-sdk-for-python - Release

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 4, 2020

azure-pipelines bot commented Mar 5, 2020

akning-ms commented Mar 5, 2020

azure-pipelines bot commented Mar 6, 2020

azure-pipelines bot commented Mar 6, 2020

azure-pipelines bot commented Mar 6, 2020

azure-pipelines bot commented Mar 10, 2020

azure-pipelines bot commented Mar 10, 2020

azure-pipelines bot commented Mar 12, 2020

anthony-c-martin Mar 16, 2020

Choose a reason for hiding this comment

sumitmal2711 Mar 16, 2020

Choose a reason for hiding this comment

anthony-c-martin Mar 16, 2020

Choose a reason for hiding this comment

sumitmal2711 Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

anthony-c-martin commented Mar 20, 2020

openapi-sdkautomation bot commented Mar 23, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 4, 2020 •

edited

Loading

sumitmal2711 Mar 16, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 23, 2020 •

edited

Loading