-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[acr] update default package tag and PrivateEndpointConnection resource for containerregistry #8646
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9b20436
to
7127d2a
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
e270ea0
to
6ed9f42
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
@djyou @northtyphoon @zikalino, does this look good to you? The removed fields are inherited from the proxyresource definition. So the only breaking change is that id, name and type are now readonly and that PrivateEndpointConnection inherits from proxyresource for the purpose of typing. Not sure why the example check is failing, no output. Its just in red... |
6ed9f42
to
5444c1f
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
5444c1f
to
a810e7b
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
PR looks good to me, although not sure what is causing this example error. "Breaking changes" are because PrivateEndpointConnection now inherits from ProxyResource. cc: @zikalino |
/azp run |
…ce for containerregistry (Azure#8646) * update default package tag * Update typescript autorest config file. * PrivateEndpointConnection should inherit proxyresource Update spec Co-authored-by: Oluwatosin Adewale <[email protected]>
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.