-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated APNS related documentation for 2017-04-01 version #8664
Conversation
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All nit comments, the changes looks good 😀 ✨
...tionhubs/resource-manager/Microsoft.NotificationHubs/stable/2017-04-01/notificationhubs.json
Outdated
Show resolved
Hide resolved
...tionhubs/resource-manager/Microsoft.NotificationHubs/stable/2017-04-01/notificationhubs.json
Outdated
Show resolved
Hide resolved
...tionhubs/resource-manager/Microsoft.NotificationHubs/stable/2017-04-01/notificationhubs.json
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
Addressing feedback from MicrosoftDocs/azure-docs#34922 |
Thanks @markcowl for reviewing. What do I need to do to get the PR merged? |
@stankovski just need the required checks to pass. Reunning and will investigate failures |
@markcowl I just realized that this PR is still open. Any way to get it merged? |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
* Updated APNS related documentation for 2017-04-01 version * Additional changes * Addressed code review feedback * Added default gcmEndpoint value
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.