Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated APNS related documentation for 2017-04-01 version #8664

Merged
merged 4 commits into from
Jun 15, 2020

Conversation

stankovski
Copy link
Member

@stankovski stankovski commented Mar 10, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 10, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 1a7ad12 with merge commit c9aad88. SDK Automation 13.0.17.20200605.3
  • ⚠️sdk/notificationhubs/mgmt-v2014_09_01 [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2014_09_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2014_09_01/implementation/NamespaceResourceImpl.java:[18,82] type argument com.microsoft.azure.management.notificationhubs.v2014_09_01.implementation.NamespaceResourceInner is not within bounds of type-variable InnerModelT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2014_09_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2014_09_01/implementation/NamespaceResourceImpl.java:[29,54] cannot find symbol
      [mvn]   symbol:   method getTags()
      [mvn]   location: class com.microsoft.azure.management.notificationhubs.v2014_09_01.implementation.NamespaceResourceInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2014_09_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2014_09_01/implementation/NamespacesImpl.java:[30,99] type argument com.microsoft.azure.management.notificationhubs.v2014_09_01.implementation.NamespaceResourceInner is not within bounds of type-variable InnerT
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-notificationhubs: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2014_09_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2014_09_01/implementation/NamespaceResourceImpl.java:[18,82] type argument com.microsoft.azure.management.notificationhubs.v2014_09_01.implementation.NamespaceResourceInner is not within bounds of type-variable InnerModelT
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2014_09_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2014_09_01/implementation/NamespaceResourceImpl.java:[29,54] cannot find symbol
      [mvn] [ERROR]   symbol:   method getTags()
      [mvn] [ERROR]   location: class com.microsoft.azure.management.notificationhubs.v2014_09_01.implementation.NamespaceResourceInner
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2014_09_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2014_09_01/implementation/NamespacesImpl.java:[30,99] type argument com.microsoft.azure.management.notificationhubs.v2014_09_01.implementation.NamespaceResourceInner is not within bounds of type-variable InnerT
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/notificationhubs/mgmt-v2016_03_01 [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2016_03_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2016_03_01/NamespaceResource.java:[61,12] region() in com.microsoft.azure.management.notificationhubs.v2016_03_01.NamespaceResource clashes with region() in com.microsoft.azure.arm.resources.models.Resource
        [mvn]   return type java.lang.String is not compatible with com.microsoft.azure.arm.resources.Region
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2016_03_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2016_03_01/NamespaceResource.java:[91,5] types com.microsoft.azure.management.notificationhubs.v2016_03_01.NamespaceResource.DefinitionStages.WithRegion and com.microsoft.azure.arm.resources.models.Resource.DefinitionWithRegion are incompatible; both define withRegion(java.lang.String), but with unrelated return types
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2016_03_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2016_03_01/implementation/NamespaceResourceImpl.java:[107,19] region() in com.microsoft.azure.management.notificationhubs.v2016_03_01.implementation.NamespaceResourceImpl cannot implement region() in com.microsoft.azure.arm.resources.models.Resource
        [mvn]   return type java.lang.String is not compatible with com.microsoft.azure.arm.resources.Region
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2016_03_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2016_03_01/implementation/NamespaceResourceImpl.java:[173,34] withRegion(java.lang.String) in com.microsoft.azure.management.notificationhubs.v2016_03_01.implementation.NamespaceResourceImpl cannot override withRegion(java.lang.String) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
        [mvn]   overridden method is final
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-notificationhubs: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2016_03_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2016_03_01/NamespaceResource.java:[61,12] region() in com.microsoft.azure.management.notificationhubs.v2016_03_01.NamespaceResource clashes with region() in com.microsoft.azure.arm.resources.models.Resource
        [mvn] [ERROR]   return type java.lang.String is not compatible with com.microsoft.azure.arm.resources.Region
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2016_03_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2016_03_01/NamespaceResource.java:[91,5] types com.microsoft.azure.management.notificationhubs.v2016_03_01.NamespaceResource.DefinitionStages.WithRegion and com.microsoft.azure.arm.resources.models.Resource.DefinitionWithRegion are incompatible; both define withRegion(java.lang.String), but with unrelated return types
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2016_03_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2016_03_01/implementation/NamespaceResourceImpl.java:[107,19] region() in com.microsoft.azure.management.notificationhubs.v2016_03_01.implementation.NamespaceResourceImpl cannot implement region() in com.microsoft.azure.arm.resources.models.Resource
        [mvn] [ERROR]   return type java.lang.String is not compatible with com.microsoft.azure.arm.resources.Region
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2016_03_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2016_03_01/implementation/NamespaceResourceImpl.java:[173,34] withRegion(java.lang.String) in com.microsoft.azure.management.notificationhubs.v2016_03_01.implementation.NamespaceResourceImpl cannot override withRegion(java.lang.String) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
        [mvn] [ERROR]   overridden method is final
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/notificationhubs/mgmt-v2017_04_01 [View full logs]  [Release SDK Changes]
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2017_04_01/NamespaceResource.java:[71,12] region() in com.microsoft.azure.management.notificationhubs.v2017_04_01.NamespaceResource clashes with region() in com.microsoft.azure.arm.resources.models.Resource
          [mvn]   return type java.lang.String is not compatible with com.microsoft.azure.arm.resources.Region
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2017_04_01/NamespaceResource.java:[106,5] types com.microsoft.azure.management.notificationhubs.v2017_04_01.NamespaceResource.DefinitionStages.WithRegion and com.microsoft.azure.arm.resources.models.Resource.DefinitionWithRegion are incompatible; both define withRegion(java.lang.String), but with unrelated return types
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2017_04_01/implementation/NamespaceResourceImpl.java:[117,19] region() in com.microsoft.azure.management.notificationhubs.v2017_04_01.implementation.NamespaceResourceImpl cannot implement region() in com.microsoft.azure.arm.resources.models.Resource
          [mvn]   return type java.lang.String is not compatible with com.microsoft.azure.arm.resources.Region
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2017_04_01/implementation/NamespaceResourceImpl.java:[194,34] withRegion(java.lang.String) in com.microsoft.azure.management.notificationhubs.v2017_04_01.implementation.NamespaceResourceImpl cannot override withRegion(java.lang.String) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
          [mvn]   overridden method is final
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-notificationhubs: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2017_04_01/NamespaceResource.java:[71,12] region() in com.microsoft.azure.management.notificationhubs.v2017_04_01.NamespaceResource clashes with region() in com.microsoft.azure.arm.resources.models.Resource
          [mvn] [ERROR]   return type java.lang.String is not compatible with com.microsoft.azure.arm.resources.Region
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2017_04_01/NamespaceResource.java:[106,5] types com.microsoft.azure.management.notificationhubs.v2017_04_01.NamespaceResource.DefinitionStages.WithRegion and com.microsoft.azure.arm.resources.models.Resource.DefinitionWithRegion are incompatible; both define withRegion(java.lang.String), but with unrelated return types
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2017_04_01/implementation/NamespaceResourceImpl.java:[117,19] region() in com.microsoft.azure.management.notificationhubs.v2017_04_01.implementation.NamespaceResourceImpl cannot implement region() in com.microsoft.azure.arm.resources.models.Resource
          [mvn] [ERROR]   return type java.lang.String is not compatible with com.microsoft.azure.arm.resources.Region
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/notificationhubs/mgmt-v2017_04_01/src/main/java/com/microsoft/azure/management/notificationhubs/v2017_04_01/implementation/NamespaceResourceImpl.java:[194,34] withRegion(java.lang.String) in com.microsoft.azure.management.notificationhubs.v2017_04_01.implementation.NamespaceResourceImpl cannot override withRegion(java.lang.String) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
          [mvn] [ERROR]   overridden method is final
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Mar 10, 2020

        azure-sdk-for-go - Release

        ️✔️ succeeded [Logs] [Expand Details]

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Mar 10, 2020

        azure-sdk-for-python - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from 1a7ad12 with merge commit c9aad88. SDK Automation 13.0.17.20200605.3
        • ️✔️azure-mgmt-notificationhubs [View full logs]  [Release SDK Changes]
          [build_conf] INFO:packaging_tools:Building template azure-mgmt-notificationhubs
          [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
          [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
          [build_conf] INFO:packaging_tools:Template done azure-mgmt-notificationhubs
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
          [ChangeLog] Size of delta 0.006% size of original (original: 32914 chars, delta: 2 chars)
          [ChangeLog] 

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Mar 10, 2020

        azure-sdk-for-net - Release

        ️✔️ succeeded [Logs] [Expand Details]

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Mar 10, 2020

        azure-sdk-for-js - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from 1a7ad12 with merge commit c9aad88. SDK Automation 13.0.17.20200605.3
        • ️✔️@azure/arm-notificationhubs [View full logs]  [Release SDK Changes]
          [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
          [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
          [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
          [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
          [npmPack] loaded rollup.config.js with warnings
          [npmPack] (!) Unused external imports
          [npmPack] default imported from external module 'rollup' but never used
          [npmPack] 
          [npmPack] ./esm/notificationHubsManagementClient.js → ./dist/arm-notificationhubs.js...
          [npmPack] created ./dist/arm-notificationhubs.js in 350ms
          [npmPack] npm notice 
          [npmPack] npm notice package: @azure/[email protected]
          [npmPack] npm notice === Tarball Contents === 
          [npmPack] npm notice 102.0kB dist/arm-notificationhubs.js                        
          [npmPack] npm notice 38.4kB  dist/arm-notificationhubs.min.js                    
          [npmPack] npm notice 345B    esm/models/index.js                                 
          [npmPack] npm notice 447B    esm/operations/index.js                             
          [npmPack] npm notice 37.6kB  esm/models/mappers.js                               
          [npmPack] npm notice 18.6kB  esm/operations/namespaces.js                        
          [npmPack] npm notice 1.1kB   esm/models/namespacesMappers.js                     
          [npmPack] npm notice 20.8kB  esm/operations/notificationHubs.js                  
          [npmPack] npm notice 1.9kB   esm/notificationHubsManagementClient.js             
          [npmPack] npm notice 2.7kB   esm/notificationHubsManagementClientContext.js      
          [npmPack] npm notice 1.0kB   esm/models/notificationHubsMappers.js               
          [npmPack] npm notice 2.3kB   esm/operations/operations.js                        
          [npmPack] npm notice 458B    esm/models/operationsMappers.js                     
          [npmPack] npm notice 2.1kB   esm/models/parameters.js                            
          [npmPack] npm notice 1.0kB   rollup.config.js                                    
          [npmPack] npm notice 1.7kB   package.json                                        
          [npmPack] npm notice 457B    tsconfig.json                                       
          [npmPack] npm notice 230.9kB dist/arm-notificationhubs.js.map                    
          [npmPack] npm notice 31.7kB  dist/arm-notificationhubs.min.js.map                
          [npmPack] npm notice 14.4kB  esm/models/index.d.ts.map                           
          [npmPack] npm notice 181B    esm/operations/index.d.ts.map                       
          [npmPack] npm notice 126B    esm/models/index.js.map                             
          [npmPack] npm notice 196B    esm/operations/index.js.map                         
          [npmPack] npm notice 1.7kB   esm/models/mappers.d.ts.map                         
          [npmPack] npm notice 20.5kB  esm/models/mappers.js.map                           
          [npmPack] npm notice 7.6kB   esm/operations/namespaces.d.ts.map                  
          [npmPack] npm notice 10.6kB  esm/operations/namespaces.js.map                    
          [npmPack] npm notice 500B    esm/models/namespacesMappers.d.ts.map               
          [npmPack] npm notice 513B    esm/models/namespacesMappers.js.map                 
          [npmPack] npm notice 8.9kB   esm/operations/notificationHubs.d.ts.map            
          [npmPack] npm notice 11.4kB  esm/operations/notificationHubs.js.map              
          [npmPack] npm notice 715B    esm/notificationHubsManagementClient.d.ts.map       
          [npmPack] npm notice 839B    esm/notificationHubsManagementClient.js.map         
          [npmPack] npm notice 531B    esm/notificationHubsManagementClientContext.d.ts.map
          [npmPack] npm notice 1.4kB   esm/notificationHubsManagementClientContext.js.map  
          [npmPack] npm notice 499B    esm/models/notificationHubsMappers.d.ts.map         
          [npmPack] npm notice 512B    esm/models/notificationHubsMappers.js.map           
          [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                  
          [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                    
          [npmPack] npm notice 215B    esm/models/operationsMappers.d.ts.map               
          [npmPack] npm notice 228B    esm/models/operationsMappers.js.map                 
          [npmPack] npm notice 543B    esm/models/parameters.d.ts.map                      
          [npmPack] npm notice 1.5kB   esm/models/parameters.js.map                        
          [npmPack] npm notice 3.3kB   README.md                                           
          [npmPack] npm notice 38.2kB  esm/models/index.d.ts                               
          [npmPack] npm notice 131B    esm/operations/index.d.ts                           
          [npmPack] npm notice 36.3kB  src/models/index.ts                                 
          [npmPack] npm notice 415B    src/operations/index.ts                             
          [npmPack] npm notice 2.3kB   esm/models/mappers.d.ts                             
          [npmPack] npm notice 30.2kB  src/models/mappers.ts                               
          [npmPack] npm notice 21.4kB  esm/operations/namespaces.d.ts                      
          [npmPack] npm notice 39.6kB  src/operations/namespaces.ts                        
          [npmPack] npm notice 740B    esm/models/namespacesMappers.d.ts                   
          [npmPack] npm notice 1.1kB   src/models/namespacesMappers.ts                     
          [npmPack] npm notice 25.6kB  esm/operations/notificationHubs.d.ts                
          [npmPack] npm notice 46.7kB  src/operations/notificationHubs.ts                  
          [npmPack] npm notice 1.3kB   esm/notificationHubsManagementClient.d.ts           
          [npmPack] npm notice 1.8kB   src/notificationHubsManagementClient.ts             
          [npmPack] npm notice 968B    esm/notificationHubsManagementClientContext.d.ts    
          [npmPack] npm notice 2.5kB   src/notificationHubsManagementClientContext.ts      
          [npmPack] npm notice 726B    esm/models/notificationHubsMappers.d.ts             
          [npmPack] npm notice 1.0kB   src/models/notificationHubsMappers.ts               
          [npmPack] npm notice 2.1kB   esm/operations/operations.d.ts                      
          [npmPack] npm notice 4.2kB   src/operations/operations.ts                        
          [npmPack] npm notice 148B    esm/models/operationsMappers.d.ts                   
          [npmPack] npm notice 422B    src/models/operationsMappers.ts                     
          [npmPack] npm notice 628B    esm/models/parameters.d.ts                          
          [npmPack] npm notice 2.1kB   src/models/parameters.ts                            
          [npmPack] npm notice 1.1kB   LICENSE.txt                                         
          [npmPack] npm notice === Tarball Details === 
          [npmPack] npm notice name:          @azure/arm-notificationhubs             
          [npmPack] npm notice version:       1.2.0                                   
          [npmPack] npm notice filename:      azure-arm-notificationhubs-1.2.0.tgz    
          [npmPack] npm notice package size:  78.6 kB                                 
          [npmPack] npm notice unpacked size: 846.5 kB                                
          [npmPack] npm notice shasum:        d2bfda92cc5e0445354d83cdfd0238a3195adcc7
          [npmPack] npm notice integrity:     sha512-BXT3XsJurk6UZ[...]je6CBJW30/Qsg==
          [npmPack] npm notice total files:   69                                      
          [npmPack] npm notice 

        Copy link

        @zhangeugenia zhangeugenia left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        All nit comments, the changes looks good 😀 ✨

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @stankovski
        Copy link
        Member Author

        Addressing feedback from MicrosoftDocs/azure-docs#34922

        @stankovski
        Copy link
        Member Author

        Thanks @markcowl for reviewing. What do I need to do to get the PR merged?

        @markcowl
        Copy link
        Member

        @stankovski just need the required checks to pass. Reunning and will investigate failures

        @stankovski
        Copy link
        Member Author

        @markcowl I just realized that this PR is still open. Any way to get it merged?

        @stankovski stankovski closed this Jun 10, 2020
        @stankovski stankovski reopened this Jun 10, 2020
        @markcowl markcowl added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 15, 2020
        @markcowl
        Copy link
        Member

        /azp run automation - sdk

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 15, 2020

        Azure CLI Extension Generation - Release

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 15, 2020

        azure-sdk-for-python-track2 - Release

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 15, 2020

        Trenton Generation - Release

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        4 participants