-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Web - Add powerShellVersion property to SiteConfig #8681
Conversation
Can one of the admins verify this patch? |
Hello @akning-ms, we are trying to get in this change soon. Could you please take a look? Please let me know if you need anything else from my side. Thank you. |
"powerShellVersion": { | ||
"description": "Version of PowerShell.", | ||
"type": "string" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New mutable properties need to go in a new api-version. See breaking changes doc here: https://armwiki.azurewebsites.net/api_contracts/Intro.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following description of the breaking change does not apply in this case because if the PUT request does not contain the new property then App service will preserve the current value of that property. Because of that we think there is no need to introduce new api version for this specific case.
New property added to response
If a new property/field is added to the response an API, the GET-PUT pipeline will be broken. Consider the case where from portal a customer updates the value of a new property "A". Another customer does a GET of this resource using the SDK. The SDK will ignore the property since it does not understand it. From the SDK, the customer does a PUT using the model that was returned from the GET. This will overwrite the change made by the first customer from the portal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
Comment was made before the most recent commit for PR 8681 in repo Azure/azure-rest-api-specs |
I've pulled the latest changes and rebased the code for my PR. Please merge once all checks has passed. Thank you. |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.