Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASR][A2A] Adding support for proximity placement group #8718

Merged
merged 3 commits into from
Apr 9, 2020
Merged

[ASR][A2A] Adding support for proximity placement group #8718

merged 3 commits into from
Apr 9, 2020

Conversation

ayfathim
Copy link
Contributor

@ayfathim ayfathim commented Mar 16, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayfathim ayfathim changed the title [ASR][A2A] Adding support for roximity placement group [ASR][A2A] Adding support for proximity placement group Mar 16, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from ddde774 with merge commit 32bd4d8. SDK Automation 13.0.17.20200326.3 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 16, 2020
Closed
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fengzhou-msft fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 17, 2020
@ayfathim
Copy link
Contributor Author

ayfathim commented Apr 7, 2020

@fengzhou-msft : please include the required people from ARM team to review this.

@ayfathim
Copy link
Contributor Author

ayfathim commented Apr 9, 2020

@Azure/arm-api-review-board : Please review this

KrisBash
KrisBash approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 9, 2020
@fengzhou-msft fengzhou-msft merged commit 32bd4d8 into Azure:master Apr 9, 2020
@ayfathim ayfathim mentioned this pull request Apr 12, 2020
Merged
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@ayfathim @00Kai0
[ASR][A2A] Adding support for proximity placement group (Azure#8718)
0efefad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

Assignees

@fengzhou-msft fengzhou-msft

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayfathim @azuresdkci @KrisBash @fengzhou-msft