Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SecurityPartnerProvider Resource #8721

Conversation

ishaniGupta27
Copy link
Contributor

@ishaniGupta27 ishaniGupta27 commented Mar 16, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ishaniGupta27 ishaniGupta27 changed the title Dev/isgu/security partner provider2 Adding SecurityPartnerProvider Resource Mar 16, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 16, 2020

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from a5e15d0 with merge commit e0862d57f00aec31ada5872b9903b76025ad5b86. SDK Automation 13.0.17.20200320.2
  • ⚠️network/mgmt/2015-06-15 [Logs
      No file is changed.
    • ⚠️network/mgmt/2016-03-30 [Logs
        No file is changed.
      • ⚠️network/mgmt/2016-06-01 [Logs
          No file is changed.
        • ️✔️network/mgmt/2016-09-01 [Logs]  [Preview SDK Changes]
        • ️✔️network/mgmt/2016-12-01 [Logs]  [Preview SDK Changes]
        • ⚠️network/mgmt/2017-03-01 [Logs
            No file is changed.
          • ⚠️network/mgmt/2017-06-01 [Logs
              No file is changed.
            • ⚠️network/mgmt/2017-08-01 [Logs
                No file is changed.
              • ⚠️network/mgmt/2017-09-01 [Logs
                  No file is changed.
                • ⚠️network/mgmt/2017-10-01 [Logs
                    No file is changed.
                  • ⚠️network/mgmt/2017-11-01 [Logs
                      No file is changed.
                    • ⚠️network/mgmt/2018-01-01 [Logs
                        No file is changed.
                      • ⚠️network/mgmt/2018-02-01 [Logs
                          No file is changed.
                        • ⚠️network/mgmt/2018-04-01 [Logs
                            No file is changed.
                          • ⚠️network/mgmt/2018-06-01 [Logs
                              No file is changed.
                            • ⚠️network/mgmt/2018-07-01 [Logs
                                No file is changed.
                              • ⚠️network/mgmt/2018-08-01 [Logs
                                  No file is changed.
                                • ⚠️network/mgmt/2018-10-01 [Logs
                                    No file is changed.
                                  • ⚠️network/mgmt/2018-11-01 [Logs
                                      No file is changed.
                                    • ⚠️network/mgmt/2018-12-01 [Logs
                                        No file is changed.
                                      • ⚠️network/mgmt/2019-02-01 [Logs
                                          No file is changed.
                                        • ⚠️network/mgmt/2019-04-01 [Logs
                                            No file is changed.
                                          • ⚠️network/mgmt/2019-06-01 [Logs
                                              No file is changed.
                                            • ⚠️network/mgmt/2019-07-01 [Logs
                                                No file is changed.
                                              • ⚠️network/mgmt/2019-08-01 [Logs
                                                  No file is changed.
                                                • ⚠️network/mgmt/2019-09-01 [Logs
                                                    No file is changed.
                                                  • ️✔️network/mgmt/2019-11-01 [Logs]  [Preview SDK Changes]
                                                  • ⚠️preview/network/mgmt/2015-05-01-preview [Logs
                                                      No file is changed.

                                                    @openapi-sdkautomation
                                                    Copy link

                                                    openapi-sdkautomation bot commented Mar 16, 2020

                                                    azure-sdk-for-java

                                                    ⚠️ warning [Logs] [Expand Details]
                                                    • ⚠️ Generate from a5e15d0 with merge commit e0862d57f00aec31ada5872b9903b76025ad5b86. SDK Automation 13.0.17.20200320.2
                                                    • ️✔️sdk/network/mgmt-v2019_02_01 [Logs]  [Preview SDK Changes]
                                                    • ⚠️sdk/network/mgmt-v2019_04_01 [Logs]  [Preview SDK Changes]
                                                        [mvn] [ERROR] COMPILATION ERROR : 
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
                                                        [mvn]   symbol:   method serviceName()
                                                        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
                                                        [mvn]   symbol:   method serviceName()
                                                        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
                                                        [mvn]   symbol:   method availableResourceGroupPrivateEndpointTypes()
                                                        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
                                                        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
                                                        [mvn] [ERROR]   symbol:   method serviceName()
                                                        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
                                                        [mvn] [ERROR]   symbol:   method serviceName()
                                                        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
                                                        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
                                                        [mvn] [ERROR]   symbol:   method availableResourceGroupPrivateEndpointTypes()
                                                        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
                                                        [mvn] [ERROR] -> [Help 1]
                                                        [mvn] [ERROR] 
                                                        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
                                                        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
                                                        [mvn] [ERROR] 
                                                        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
                                                        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
                                                      • ️✔️sdk/network/mgmt-v2019_06_01 [Logs]  [Preview SDK Changes]
                                                      • ️✔️sdk/network/mgmt-v2019_07_01 [Logs]  [Preview SDK Changes]
                                                      • ️✔️sdk/network/mgmt-v2019_08_01 [Logs]  [Preview SDK Changes]
                                                      • ⚠️sdk/network/mgmt-v2019_09_01 [Logs]  [Preview SDK Changes]
                                                          [mvn] [ERROR] COMPILATION ERROR : 
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
                                                          [mvn]   symbol:   class ResourceNavigationLinkInner
                                                          [mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
                                                          [mvn]   symbol:   class ServiceAssociationLinkInner
                                                          [mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
                                                          [mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
                                                          [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
                                                          [mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
                                                          [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
                                                          [mvn] [ERROR] -> [Help 1]
                                                          [mvn] [ERROR] 
                                                          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
                                                          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
                                                          [mvn] [ERROR] 
                                                          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
                                                          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

                                                        @openapi-sdkautomation
                                                        Copy link

                                                        openapi-sdkautomation bot commented Mar 16, 2020

                                                        azure-sdk-for-js

                                                        ️✔️ succeeded [Logs] [Expand Details]
                                                        • ️✔️ Generate from a5e15d0 with merge commit e0862d57f00aec31ada5872b9903b76025ad5b86. SDK Automation 13.0.17.20200320.2
                                                        • ️✔️@azure/arm-network [Logs]  [Preview SDK Changes]
                                                          [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
                                                          [npmPack] loaded rollup.config.js with warnings
                                                          [npmPack] (!) Unused external imports
                                                          [npmPack] default imported from external module 'rollup' but never used
                                                          [npmPack] 
                                                          [npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
                                                          [npmPack] created ./dist/arm-network.js in 2.2s

                                                        @openapi-sdkautomation
                                                        Copy link

                                                        openapi-sdkautomation bot commented Mar 16, 2020

                                                        azure-sdk-for-python

                                                        ⚠️ warning [Logs] [Expand Details]
                                                        • ⚠️ Generate from a5e15d0 with merge commit e0862d57f00aec31ada5872b9903b76025ad5b86. SDK Automation 13.0.17.20200320.2
                                                        • ⚠️azure-mgmt-network [Logs]  [Preview SDK Changes]
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2016-12-01', '2016-09-01'} in label v2016_12_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2016-12-01 based on label v2016_12_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-03-01'} in label v2017_03_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-03-01 based on label v2017_03_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-06-01'} in label v2017_06_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-06-01 based on label v2017_06_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-08-01', '2017-03-30'} in label v2017_08_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-08-01 based on label v2017_08_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-09-01'} in label v2017_09_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-09-01 based on label v2017_09_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-10-01'} in label v2017_10_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-10-01 based on label v2017_10_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-11-01'} in label v2017_11_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2017-11-01 based on label v2017_11_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-01-01'} in label v2018_01_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-01-01 based on label v2018_01_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-02-01'} in label v2018_02_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01 based on label v2018_02_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-04-01'} in label v2018_04_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-04-01 based on label v2018_04_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-06-01'} in label v2018_06_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-06-01 based on label v2018_06_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-07-01', '2017-03-30'} in label v2018_07_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-08-01', '2017-03-30'} in label v2018_08_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-08-01 based on label v2018_08_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2017-03-30'} in label v2018_10_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-10-01 based on label v2018_10_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-11-01'} in label v2018_11_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-11-01 based on label v2018_11_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-12-01', '2017-03-30'} in label v2018_12_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2018-12-01 based on label v2018_12_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-02-01', '2017-03-30'} in label v2019_02_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-02-01 based on label v2019_02_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2019-04-01'} in label v2019_04_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01', '2017-03-30'} in label v2019_06_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01 based on label v2019_06_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-07-01', '2019-06-01'} in label v2019_07_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-07-01 based on label v2019_07_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-08-01', '2019-06-01'} in label v2019_08_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-08-01 based on label v2019_08_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-06-01', '2019-09-01'} in label v2019_09_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-09-01 based on label v2019_09_01
                                                          [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-11-01'} in label v2019_11_01
                                                          [after_scripts|python] WARNING:__main__:Guessing you want 2019-11-01 based on label v2019_11_01
                                                          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                                          [build_package]   warnings.warn(msg)
                                                          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                                          [build_package]   warnings.warn(msg)
                                                          [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
                                                          [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'install', '-r', 'dev_requirements.txt']' died with .
                                                          Not exact 2 reports found:
                                                          code_reports/9.0.0/merged_report.json
                                                          code_reports/9.0.0/v2015_06_15.json
                                                          code_reports/9.0.0/v2016_09_01.json
                                                          code_reports/9.0.0/v2016_12_01.json
                                                          code_reports/9.0.0/v2017_03_01.json
                                                          code_reports/9.0.0/v2017_06_01.json
                                                          code_reports/9.0.0/v2017_08_01.json
                                                          code_reports/9.0.0/v2017_09_01.json
                                                          code_reports/9.0.0/v2017_10_01.json
                                                          code_reports/9.0.0/v2017_11_01.json
                                                          code_reports/9.0.0/v2018_01_01.json
                                                          code_reports/9.0.0/v2018_02_01.json
                                                          code_reports/9.0.0/v2018_04_01.json
                                                          code_reports/9.0.0/v2018_06_01.json
                                                          code_reports/9.0.0/v2018_07_01.json
                                                          code_reports/9.0.0/v2018_08_01.json
                                                          code_reports/9.0.0/v2018_10_01.json
                                                          code_reports/9.0.0/v2018_11_01.json
                                                          code_reports/9.0.0/v2018_12_01.json
                                                          code_reports/9.0.0/v2019_02_01.json
                                                          code_reports/9.0.0/v2019_04_01.json
                                                          code_reports/9.0.0/v2019_06_01.json
                                                          code_reports/9.0.0/v2019_07_01.json
                                                          code_reports/9.0.0/v2019_08_01.json
                                                          code_reports/9.0.0/v2019_09_01.json
                                                          code_reports/9.0.0/v2019_11_01.json
                                                          Not generating changelog.
                                                          [ChangeLog] WARNING: Failed to generate ChangeLog.

                                                        @openapi-sdkautomation
                                                        Copy link

                                                        openapi-sdkautomation bot commented Mar 16, 2020

                                                        azure-sdk-for-net

                                                        ️✔️ succeeded [Logs] [Expand Details]

                                                        @azuresdkci
                                                        Copy link
                                                        Contributor

                                                        Can one of the admins verify this patch?

                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @ishaniGupta27
                                                        Copy link
                                                        Contributor Author

                                                        Addressed the comments:

                                                        1. Added definition for SecurityPartnerProviderListResult
                                                        2. Updated Readme.md with securityPartnerProvider

                                                        @anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 18, 2020
                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        Copy link
                                                        Contributor

                                                        @anton-evseev anton-evseev left a comment

                                                        Choose a reason for hiding this comment

                                                        The reason will be displayed to describe this comment to others. Learn more.

                                                        LGTM except some nitpicks

                                                        "tags": [
                                                        "securityPartnerProviders"
                                                        ],
                                                        "operationId": "securityPartnerProviders_Delete",
                                                        Copy link
                                                        Contributor

                                                        Choose a reason for hiding this comment

                                                        The reason will be displayed to describe this comment to others. Learn more.

                                                        Suggested change
                                                        "operationId": "securityPartnerProviders_Delete",
                                                        "operationId": "SecurityPartnerProviders_Delete",

                                                        Please do this change in other parts of the spec

                                                        Copy link
                                                        Contributor Author

                                                        Choose a reason for hiding this comment

                                                        The reason will be displayed to describe this comment to others. Learn more.

                                                        Done..

                                                        "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/securityPartnerProviders/{securityPartnerProviderName}": {
                                                        "delete": {
                                                        "tags": [
                                                        "securityPartnerProviders"
                                                        Copy link
                                                        Contributor

                                                        Choose a reason for hiding this comment

                                                        The reason will be displayed to describe this comment to others. Learn more.

                                                        Suggested change
                                                        "securityPartnerProviders"
                                                        "SecurityPartnerProviders"

                                                        Please do this change in other parts of the spec

                                                        Copy link
                                                        Contributor Author

                                                        Choose a reason for hiding this comment

                                                        The reason will be displayed to describe this comment to others. Learn more.

                                                        Done.

                                                        "tags": [
                                                        "securityPartnerProviders"
                                                        ],
                                                        "operationId": "securityPartnerProviders_List",
                                                        Copy link
                                                        Contributor

                                                        Choose a reason for hiding this comment

                                                        The reason will be displayed to describe this comment to others. Learn more.

                                                        Suggested change
                                                        "operationId": "securityPartnerProviders_List",
                                                        "operationId": "SecurityPartnerProviders_ListByResourceGroup",

                                                        Copy link
                                                        Contributor Author

                                                        Choose a reason for hiding this comment

                                                        The reason will be displayed to describe this comment to others. Learn more.

                                                        Done..

                                                        "tags": [
                                                        "securityPartnerProviders"
                                                        ],
                                                        "operationId": "securityPartnerProviders_ListAll",
                                                        Copy link
                                                        Contributor

                                                        Choose a reason for hiding this comment

                                                        The reason will be displayed to describe this comment to others. Learn more.

                                                        Suggested change
                                                        "operationId": "securityPartnerProviders_ListAll",
                                                        "operationId": "SecurityPartnerProviders_List",

                                                        Copy link
                                                        Contributor Author

                                                        Choose a reason for hiding this comment

                                                        The reason will be displayed to describe this comment to others. Learn more.

                                                        Done..

                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @lirenhe lirenhe removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Mar 20, 2020
                                                        @azure-pipelines
                                                        Copy link

                                                        Azure Pipelines successfully started running 1 pipeline(s).

                                                        @akning-ms akning-ms merged commit 0198dc7 into Azure:network-march-release Mar 24, 2020
                                                        mmyyrroonn pushed a commit that referenced this pull request Apr 8, 2020
                                                        * Adds base for updating Microsoft.Network from version stable/2019-12-01 to version 2020-03-01
                                                        
                                                        * Updates readme
                                                        
                                                        * Updates API version in new specs and examples
                                                        
                                                        * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix… (#8708)
                                                        
                                                        * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues
                                                        
                                                        * Fix readme file
                                                        
                                                        Co-authored-by: Vinaya Damle <[email protected]>
                                                        
                                                        * Adding SecurityPartnerProvider Resource (#8721)
                                                        
                                                        * Adding securityPartnerProvider resource
                                                        
                                                        * Adding securityPartnerProvider resource : 2
                                                        
                                                        * Added Definition for SecurityPartnerProviderListResult
                                                        
                                                        * Updated Readme.md with securityPartnerProvider
                                                        
                                                        * fixing zone..
                                                        
                                                        * Fixing using Prettier
                                                        
                                                        * desc fix
                                                        
                                                        * Fixing enum conflict
                                                        
                                                        * RequiredPropertiesMissingInResourceModel Fix
                                                        
                                                        * capitalizing alphabets
                                                        
                                                        * renaming list/listall
                                                        
                                                        * Updated Tags to Caps
                                                        
                                                        Co-authored-by: Ishani Gupta <[email protected]>
                                                        
                                                        * AzureFirewall User Tags Update (#8748)
                                                        
                                                        * AzureFirewall User Tags Update
                                                        
                                                        * Prettier Fixes
                                                        
                                                        Co-authored-by: Ishani Gupta <[email protected]>
                                                        
                                                        * Add IpAllocation resource for Hypernet IP management. (#8701)
                                                        
                                                        * Add IpAllocation resource for Hypernet IP management.
                                                        
                                                        * Fix path issue.
                                                        
                                                        * Fix some issues by PR comments.
                                                        
                                                        * Fix document issue.
                                                        
                                                        * Fix reference with SubResource.
                                                        
                                                        * Fix IpAllocation tags name issue.
                                                        
                                                        * Add patch operation to IpAllocation resource.
                                                        
                                                        * Fix spell issue with pretter.
                                                        
                                                        * Introducing force policy association feature (#8738)
                                                        
                                                        * Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. (#8704)
                                                        
                                                        * Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint
                                                        
                                                        * Adding endzone keyword for build
                                                        
                                                        * Adding reference to 2020 private endpoint in readme for validation purposes
                                                        
                                                        * Misspelled reference to Get file fixed
                                                        
                                                        * Ran prettier fix on files
                                                        
                                                        * Removing reference in readme
                                                        
                                                        * Added some needed capitilization and punctuation, will be a pt2 to this commit
                                                        
                                                        * Added descriptions
                                                        
                                                        * Rerunning tests.
                                                        
                                                        * Updated definitions for customdnsconfig and record set
                                                        
                                                        * Rebuilding for pr
                                                        
                                                        * Changing word back to original sentence for PR.
                                                        
                                                        * Changed name in example file for create, as well as added List operation and fixed pr comments
                                                        
                                                        * resolved comments based on pr
                                                        
                                                        * Added changes based on PRcomments
                                                        
                                                        * Added integer tag to ttl
                                                        
                                                        * getting rid of type in private endpoint json
                                                        
                                                        * Changed type attribute in privateendpointdnszonegroupget
                                                        
                                                        * Added read only attribute to record set array
                                                        
                                                        Co-authored-by: Shane Baden <[email protected]>
                                                        
                                                        * Adding intrusionSystemMode property to firewallPolicy (#8885)
                                                        
                                                        * Add intrusionSystemMode to firewallPolicy
                                                        
                                                        * Change intrusionSystemMode to be either Enabled or Disabled
                                                        
                                                        * fix pretier
                                                        
                                                        * remove white space
                                                        
                                                        * remove the examples as this is a preview feature
                                                        
                                                        Co-authored-by: Shany Pozin <[email protected]>
                                                        
                                                        * DPDTimeout Multiple Radius for VPN Gateways (Network) (#8707)
                                                        
                                                        * DPDTimeout Multiple Radius changes
                                                        
                                                        * PR feedback, resource changes
                                                        
                                                        * PR feedback, example changes
                                                        
                                                        * examples fix
                                                        
                                                        * PR feedback
                                                        
                                                        * CI fix
                                                        
                                                        * prettier fix attempt
                                                        
                                                        Co-authored-by: Mikhail <[email protected]>
                                                        Co-authored-by: vinayada1 <[email protected]>
                                                        Co-authored-by: Vinaya Damle <[email protected]>
                                                        Co-authored-by: Ishani Gupta <[email protected]>
                                                        Co-authored-by: Ishani Gupta <[email protected]>
                                                        Co-authored-by: liuh-80 <[email protected]>
                                                        Co-authored-by: Venkata Krishnan Anantha Raman <[email protected]>
                                                        Co-authored-by: Shane Baden <[email protected]>
                                                        Co-authored-by: Shane Baden <[email protected]>
                                                        Co-authored-by: Shany Pozin <[email protected]>
                                                        Co-authored-by: Shany Pozin <[email protected]>
                                                        Co-authored-by: Henry Chen <[email protected]>
                                                        00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                                                        * Adds base for updating Microsoft.Network from version stable/2019-12-01 to version 2020-03-01
                                                        
                                                        * Updates readme
                                                        
                                                        * Updates API version in new specs and examples
                                                        
                                                        * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix… (Azure#8708)
                                                        
                                                        * Move ExpressRouteGateway definitions inside of virtualWAN.json to fix documentation issues
                                                        
                                                        * Fix readme file
                                                        
                                                        Co-authored-by: Vinaya Damle <[email protected]>
                                                        
                                                        * Adding SecurityPartnerProvider Resource (Azure#8721)
                                                        
                                                        * Adding securityPartnerProvider resource
                                                        
                                                        * Adding securityPartnerProvider resource : 2
                                                        
                                                        * Added Definition for SecurityPartnerProviderListResult
                                                        
                                                        * Updated Readme.md with securityPartnerProvider
                                                        
                                                        * fixing zone..
                                                        
                                                        * Fixing using Prettier
                                                        
                                                        * desc fix
                                                        
                                                        * Fixing enum conflict
                                                        
                                                        * RequiredPropertiesMissingInResourceModel Fix
                                                        
                                                        * capitalizing alphabets
                                                        
                                                        * renaming list/listall
                                                        
                                                        * Updated Tags to Caps
                                                        
                                                        Co-authored-by: Ishani Gupta <[email protected]>
                                                        
                                                        * AzureFirewall User Tags Update (Azure#8748)
                                                        
                                                        * AzureFirewall User Tags Update
                                                        
                                                        * Prettier Fixes
                                                        
                                                        Co-authored-by: Ishani Gupta <[email protected]>
                                                        
                                                        * Add IpAllocation resource for Hypernet IP management. (Azure#8701)
                                                        
                                                        * Add IpAllocation resource for Hypernet IP management.
                                                        
                                                        * Fix path issue.
                                                        
                                                        * Fix some issues by PR comments.
                                                        
                                                        * Fix document issue.
                                                        
                                                        * Fix reference with SubResource.
                                                        
                                                        * Fix IpAllocation tags name issue.
                                                        
                                                        * Add patch operation to IpAllocation resource.
                                                        
                                                        * Fix spell issue with pretter.
                                                        
                                                        * Introducing force policy association feature (Azure#8738)
                                                        
                                                        * Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. (Azure#8704)
                                                        
                                                        * Adding privateEndpoint child resource privateDNSZoneGroup, as well as adding customDNSconfig JSONto privateendpoint
                                                        
                                                        * Adding endzone keyword for build
                                                        
                                                        * Adding reference to 2020 private endpoint in readme for validation purposes
                                                        
                                                        * Misspelled reference to Get file fixed
                                                        
                                                        * Ran prettier fix on files
                                                        
                                                        * Removing reference in readme
                                                        
                                                        * Added some needed capitilization and punctuation, will be a pt2 to this commit
                                                        
                                                        * Added descriptions
                                                        
                                                        * Rerunning tests.
                                                        
                                                        * Updated definitions for customdnsconfig and record set
                                                        
                                                        * Rebuilding for pr
                                                        
                                                        * Changing word back to original sentence for PR.
                                                        
                                                        * Changed name in example file for create, as well as added List operation and fixed pr comments
                                                        
                                                        * resolved comments based on pr
                                                        
                                                        * Added changes based on PRcomments
                                                        
                                                        * Added integer tag to ttl
                                                        
                                                        * getting rid of type in private endpoint json
                                                        
                                                        * Changed type attribute in privateendpointdnszonegroupget
                                                        
                                                        * Added read only attribute to record set array
                                                        
                                                        Co-authored-by: Shane Baden <[email protected]>
                                                        
                                                        * Adding intrusionSystemMode property to firewallPolicy (Azure#8885)
                                                        
                                                        * Add intrusionSystemMode to firewallPolicy
                                                        
                                                        * Change intrusionSystemMode to be either Enabled or Disabled
                                                        
                                                        * fix pretier
                                                        
                                                        * remove white space
                                                        
                                                        * remove the examples as this is a preview feature
                                                        
                                                        Co-authored-by: Shany Pozin <[email protected]>
                                                        
                                                        * DPDTimeout Multiple Radius for VPN Gateways (Network) (Azure#8707)
                                                        
                                                        * DPDTimeout Multiple Radius changes
                                                        
                                                        * PR feedback, resource changes
                                                        
                                                        * PR feedback, example changes
                                                        
                                                        * examples fix
                                                        
                                                        * PR feedback
                                                        
                                                        * CI fix
                                                        
                                                        * prettier fix attempt
                                                        
                                                        Co-authored-by: Mikhail <[email protected]>
                                                        Co-authored-by: vinayada1 <[email protected]>
                                                        Co-authored-by: Vinaya Damle <[email protected]>
                                                        Co-authored-by: Ishani Gupta <[email protected]>
                                                        Co-authored-by: Ishani Gupta <[email protected]>
                                                        Co-authored-by: liuh-80 <[email protected]>
                                                        Co-authored-by: Venkata Krishnan Anantha Raman <[email protected]>
                                                        Co-authored-by: Shane Baden <[email protected]>
                                                        Co-authored-by: Shane Baden <[email protected]>
                                                        Co-authored-by: Shany Pozin <[email protected]>
                                                        Co-authored-by: Shany Pozin <[email protected]>
                                                        Co-authored-by: Henry Chen <[email protected]>
                                                        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                                                        Labels
                                                        ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
                                                        Projects
                                                        None yet
                                                        Development

                                                        Successfully merging this pull request may close these issues.

                                                        7 participants