-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.DigitalTwins to add version preview/2020-03-01-preview #8740
[Hub Generated] Review request for Microsoft.DigitalTwins to add version preview/2020-03-01-preview #8740
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
@@ -1177,7 +1177,6 @@ | |||
], | |||
"properties": { | |||
"properties": { | |||
"x-ms-client-flatten": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"x-ms-client-flatten": true, [](start = 10, length = 28)
May I ask why do you remove "x-ms-client-flatten": true. This will impact the generated SDK. What is the expected SDK data structure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason it is removed it to avoid flattening of DigitalTwinsEndpointResourceProperties
which uses "discriminator": "endpointType",
to model inheritance. If this flag is present generated SDK does not have a way to use sub-classes to set properties
value (e.g. EventGrid
, EventHub
and ServiceBus
).
Also there is no scenario where properties fields are set directly, they should only be initialized via sub-classes.
…ion preview/2020-03-01-preview (Azure#8740) * Remove x-ms-client-flatten flag from endpoint properties * Adds suppression to readme
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: