[Hub Generated] Review request for Microsoft.DigitalTwins to add version preview/2020-03-01-preview #8740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
sup-s
approved these changes
Mar 20, 2020
sup-s
approved these changes
Mar 23, 2020
qianwens
reviewed
Mar 24, 2020
| @@ -1177,7 +1177,6 @@ | |||
| ], | |||
| "properties": { | |||
| "properties": { | |||
| "x-ms-client-flatten": true, | |||
There was a problem hiding this comment.
"x-ms-client-flatten": true, [](start = 10, length = 28)
May I ask why do you remove "x-ms-client-flatten": true. This will impact the generated SDK. What is the expected SDK data structure?
There was a problem hiding this comment.
The reason it is removed it to avoid flattening of DigitalTwinsEndpointResourceProperties which uses "discriminator": "endpointType", to model inheritance. If this flag is present generated SDK does not have a way to use sub-classes to set properties value (e.g. EventGrid, EventHub and ServiceBus).
Also there is no scenario where properties fields are set directly, they should only be initialized via sub-classes.
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…ion preview/2020-03-01-preview (Azure#8740) * Remove x-ms-client-flatten flag from endpoint properties * Adds suppression to readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: