-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 #8820
[Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 #8820
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
@xccc-msft I believe the public.rest-api-specs (BreakingChange) gate failure is a false positive. |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-sdk-for-go - Release
|
@NullMDR Can you please advise for the CIs? |
@jianyexi Could you please help on the breaking change detection in CI? |
@xccc-msft @NullMDR @jianyexi Hi, any updates on this PR? |
|
Hi @liranc, Seems you are just fix duplicate RuleType issue in this PR. So removed ARM review request. agree it is not breaking change for api. but I am not sure for sdk. can you share me about what language sdk to be released for this PR? I may ask sdk owner to take a look. |
@akning-ms The released SDK is C#. The generated code will look a bit different and possibly break existing code, but is this an issue since the NuGet is always published using a different version? (so only those who would upgrade to the new version will need to make these few adjustments). |
approved, but @isra-fel for awareness .Net sdk |
…stable/2019-08-01 (Azure#8820) * Set ruleType as discriminator. Create concrete rule types * ran prettier Co-authored-by: Liran Chen <[email protected]>
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: