[Storage] Add object replication policy #8864

zfchen95 · 2020-03-27T22:14:42Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.
#https://github.com/Azure/azure-rest-api-specs-pr/pull/965/files

azure-pipelines · 2020-03-27T22:14:58Z

Azure Pipelines successfully started running 1 pipeline(s).

zfchen95 · 2020-03-27T22:15:53Z

https://github.com/Azure/azure-rest-api-specs-pr/pull/965/files

openapi-sdkautomation · 2020-03-27T22:16:21Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 13aa234 with merge commit 608254a. SDK Automation 13.0.17.20200326.3
️✔️sdk/storage/mgmt-v2016_01_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2017_10_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_02_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_03_01_preview [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2018_07_01 [Logs] [Release SDK Changes]
️✔️sdk/storage/mgmt-v2019_04_01 [Logs] [Release SDK Changes]

⚠️sdk/storage/mgmt-v2019_06_01 [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[78,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[78,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-03-27T22:16:21Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 13aa234 with merge commit 608254a. SDK Automation 13.0.17.20200326.3
⚠️preview/storage/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```
⚠️preview/storage/mgmt/2018-03-01-preview [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-01-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-05-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-12-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
️✔️storage/mgmt/2019-06-01 [Logs] [Release SDK Changes]
- storage.mgmt.2019-06-01.zip

openapi-sdkautomation · 2020-03-27T22:16:22Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 13aa234 with merge commit 608254a. SDK Automation 13.0.17.20200326.3

️✔️azure-mgmt-storage [Logs] [Release SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 4.997% size of original (original: 74665 chars, delta: 3731 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model RestorePolicyProperties has a new parameter last_enabled_time
[ChangeLog]   - Added operation group ObjectReplicationPoliciesOperations

openapi-sdkautomation · 2020-03-27T22:16:24Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-03-27T22:16:25Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 13aa234 with merge commit 608254a. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-storage [Logs] [Release SDK Changes]

azure-arm-storage-14.0.0.tgz

[npmPack] npm WARN lifecycle @azure/[email protected]~prepack: cannot run in wd @azure/[email protected] npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/storage/arm-storage)

openapi-sdkautomation · 2020-03-27T22:16:25Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 13aa234 with merge commit 608254a. SDK Automation 13.0.17.20200326.3
️✔️Microsoft.Azure.Management.Storage [Logs] [Release SDK Changes]

azuresdkci · 2020-03-27T22:16:47Z

Can one of the admins verify this patch?

blueww · 2020-03-28T05:12:46Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/storage.json

+          "description": "Optional. Filters the results to replicate only blobs whose names begin with the specified prefix."
+        },
+        "minCreationTime": {
+          "type": "string",


This should be datetime format. Using string format will make we need to add a lot of code to handle to format convert in Powershell (and other user of SDK), which easy to take bugs.

Using datetime format will break the server side. Server side could support datetime format in the future.

How would it break server side? It would still be serialized as a string in JSON.

In reply to: 401773509 [](ancestors = 401773509)

It would also be good to get this fixed up front so we generate SDKs correctly from the beginning.

In reply to: 403179698 [](ancestors = 403179698,401773509)

blueww · 2020-03-28T07:47:35Z

For the .NET SDK failure, it caused by a before swager change in #8595.

I have raised a PR to fix the unit test in .NET SDK Azure/azure-sdk-for-net#10867, We should rerun the .NET SDK test after the PR is in.

[Update on 3/30/2020] The .NET SDK PR is in, and the .NET SDK check pass now.

blueww · 2020-03-30T05:41:16Z

/azp run

azure-pipelines · 2020-03-30T05:41:34Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2020-03-31T00:04:52Z

Azure Pipelines successfully started running 1 pipeline(s).

zfchen95 · 2020-03-31T01:28:12Z

Please add ARM team for review if needed. Thanks

majastrz

Looks identical to the previously approved private PR (except for the one date-time format change). Signed off from ARM side. Please clear up the date-time format issue before merging, though.

* [Storage] Add object replication policy * Fix spellcheck and prettier check

[Storage] Add object replication policy

77b8987

zfchen95 requested a review from JasonYang-MSFT as a code owner March 27, 2020 22:14

openapi-assignment-bot bot assigned qianwens Mar 27, 2020

blueww reviewed Mar 28, 2020

View reviewed changes

Fix spellcheck and prettier check

13aa234

JasonYang-MSFT added the WaitForARMReview label Apr 1, 2020

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMReview labels Apr 3, 2020

majastrz approved these changes Apr 3, 2020

View reviewed changes

blueww approved these changes Apr 7, 2020

View reviewed changes

qianwens merged commit 608254a into Azure:master Apr 7, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

[Storage] Add object replication policy (Azure#8864)

128297d

* [Storage] Add object replication policy * Fix spellcheck and prettier check

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Storage] Add object replication policy #8864

[Storage] Add object replication policy #8864

zfchen95 commented Mar 27, 2020 •

edited

Loading

azure-pipelines bot commented Mar 27, 2020

zfchen95 commented Mar 27, 2020

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

azuresdkci commented Mar 27, 2020

blueww Mar 28, 2020

zfchen95 Apr 1, 2020

majastrz Apr 3, 2020

majastrz Apr 3, 2020

blueww commented Mar 28, 2020 •

edited

Loading

blueww commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

azure-pipelines bot commented Mar 31, 2020

zfchen95 commented Mar 31, 2020

majastrz left a comment

[Storage] Add object replication policy #8864

[Storage] Add object replication policy #8864

Conversation

zfchen95 commented Mar 27, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Mar 27, 2020

zfchen95 commented Mar 27, 2020

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Mar 27, 2020 • edited Loading

azure-sdk-for-net - Release

azuresdkci commented Mar 27, 2020

blueww Mar 28, 2020

Choose a reason for hiding this comment

zfchen95 Apr 1, 2020

Choose a reason for hiding this comment

majastrz Apr 3, 2020

Choose a reason for hiding this comment

majastrz Apr 3, 2020

Choose a reason for hiding this comment

blueww commented Mar 28, 2020 • edited Loading

blueww commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

azure-pipelines bot commented Mar 31, 2020

zfchen95 commented Mar 31, 2020

majastrz left a comment

Choose a reason for hiding this comment

zfchen95 commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 27, 2020 •

edited

Loading

blueww commented Mar 28, 2020 •

edited

Loading