Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added metadata field to SapMonitor provider instance #8901

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Added metadata field to SapMonitor provider instance #8901

merged 2 commits into from
Apr 9, 2020

Conversation

PakDLiu
Copy link
Contributor

@PakDLiu PakDLiu commented Mar 31, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from e8507a3 with merge commit 77b51e3. SDK Automation 13.0.17.20200326.3 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from e8507a3 with merge commit 77b51e3. SDK Automation 13.0.17.20200326.3
  • ⚠️preview/hanaonazure/mgmt/2017-11-03-preview [Logs]  
      No file is changed.

    This was referenced Mar 31, 2020
    Closed
    Closed
    tniek
    tniek approved these changes Mar 31, 2020
    View reviewed changes
    Copy link

    @tniek tniek left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good to me

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 2, 2020
    @PakDLiu
    Copy link
    Contributor Author

    PakDLiu commented Apr 2, 2020 •
    edited
    Loading

    Added new field to provider instance: metadata
    It is of string type
    The string should be of JSON format. The JSON schema is dependent on the type field, that is why is of string type rather than a JSON object.
    The field is optional

    KrisBash
    KrisBash approved these changes Apr 6, 2020
    View reviewed changes
    Copy link
    Contributor

    @KrisBash KrisBash left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 6, 2020
    @lirenhe
    Copy link
    Member

    lirenhe commented Apr 8, 2020

    @PakDLiu, it looks your PR would cause breaking change, could you double check whether you have any SDK released?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @akning-ms
    Copy link
    Contributor

    as @PakDLiu confirm it is preview version and no one is using this version api, so breaking change fail approved

    @akning-ms akning-ms merged commit 77b51e3 into Azure:master Apr 9, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @PakDLiu @00Kai0
    Added metadata field to SapMonitor provider instance (Azure#8901)
    4b3c44e 
    * Added metadata field to SapMonitor provider instance

* fixed examples
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @KrisBash KrisBash KrisBash approved these changes

    @lirenhe lirenhe lirenhe approved these changes

    @tniek tniek tniek approved these changes

    @rukawata rukawata rukawata approved these changes

    Assignees

    @lirenhe lirenhe

    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @PakDLiu @azuresdkci @lirenhe @akning-ms @KrisBash @tniek @rukawata