-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return throughput in response for Cosmos DB runtime resources #8902
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
Can one of the admins verify this patch? |
specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side.
Could someone from the SDK team look at this PR? I think the gates are failing because it is marked as a breaking change. I could not find any other errors in the runs. |
Azure Pipelines successfully started running 1 pipeline(s). |
@allenjzhang Can you review this change and help with the failing gates? The only errors I could find are that this was identified as a breaking change. |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @shurd, Besides the API breaking change failure. (add ‘options’ property in response) And also there is SDK breaking change as below: |
The autopilot property was renamed in a previous change, and we do not think anyone has taken a dependency on the original naming. The property is not used in CLI/PS yet, but we will be adding it there soon. |
…8902) * return options.throughput in response for runtime resources * update configuration files to account for new api version * suppress provider pascal case errors Co-authored-by: Sam Hurd <[email protected]>
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.