Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.insights pl flags new version - fix conflicting parameters for SDK #8905

Merged

Conversation

arolshan
Copy link
Contributor

@arolshan arolshan commented Apr 1, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from bbbfb46 with merge commit 5e1b628. SDK Automation 13.0.17.20200326.3
  • ️✔️azure-mgmt-applicationinsights [Logs]  [Release SDK Changes]
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
    [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
    [ChangeLog] Size of delta 2.535% size of original (original: 50134 chars, delta: 1271 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter retention_in_days
    [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter connection_string
    [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter disable_ip_masking
    [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter private_link_scoped_resources
    [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter immediate_purge_data_on30_days

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 1, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from bbbfb46 with merge commit 5e1b628. SDK Automation 13.0.17.20200326.3
  • ️✔️Microsoft.Azure.ApplicationInsights [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @mmyyrroonn mmyyrroonn added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 1, 2020
    @mmyyrroonn
    Copy link
    Contributor

    @akning-ms Hi. This PR changed the three common parameters(sub, api and resource group) by using the common type. Only the descriptions and validation part changed. Since they are quite general parameters across Azure and these validations have been there before this PR. I think it's not a real breaking change for customer. Could you take a look and help us merge this PR?

    @akning-ms akning-ms merged commit 5e1b628 into Azure:master Apr 1, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    …for SDK (Azure#8905)
    
    * clone to new version for new flags
    
    * Update readme.md
    
    * Update readme.md
    
    * Update components_API.json
    
    * Update components_API.json
    
    * Update componentProactiveDetection_API.json
    
    * Update ProactiveDetectionConfigurationUpdate.json
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants