New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add avocado ci-fix #8907

Merged

akning-ms merged 3 commits into Azure:master from ruowan:avocado-ci-fix

Apr 9, 2020

Member

ruowan commented Apr 1, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.


          Add avocado ci-fix

fa76aa5

openapi-assignment-bot bot assigned josefree

azure-pipelines bot commented Apr 1, 2020

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

Contributor

azuresdkci commented Apr 1, 2020

Can one of the admins verify this patch?

akning-ms reviewed

View reviewed changes

documentation/ci-fix.md


		```
		npm install -g @azure/avocado

Contributor

akning-ms Apr 1, 2020 •

edited

Loading

Should we add step here? e.g. cd

Member Author

ruowan Apr 2, 2020

No. npm install -g mean install in root node_module. You can use avocado in any directory.

Contributor

akning-ms Apr 3, 2020

I mean cd to the RP folder before run avocado

Member Author

ruowan Apr 7, 2020

Currently, Avocado can't support running in RP folder. Avocado running process based on root folder. I can design a feature to support it.

akning-ms requested a review from josefree

April 1, 2020 12:16

akning-ms assigned akning-ms and unassigned josefree

josefree reviewed

View reviewed changes

documentation/ci-fix.md Outdated


		When type avocado in command line, avocado will validate in the current directory.

		NOTE: When running in azure devops Avocado only report new errors involved in PR, but ignore the previous existing errors. So when running in local machine, Avocado report all errors.

Member

josefree Apr 3, 2020

The NOTE is a little bit confusing. Some tuning based my understanding...

Note: when running in Azure Devops (what do you referring to? Do you mean PR pipeline? ), Avocado only reports errors with file updates in the PR, but ignore errors existing in the base. However, when running Avacado against local directory, it reports all errors existing in the files.

Member Author

ruowan Apr 3, 2020

Yes. It's Azure pipeline. updated the note.

ruowan added 2 commits

April 3, 2020 07:07


          update note

6d00f22


          swagger PR pipeline

ccd8725

azure-pipelines bot commented Apr 8, 2020

Azure Pipelines successfully started running 1 pipeline(s).

akning-ms approved these changes

View reviewed changes

akning-ms merged commit 27f3aad into Azure:master

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request


          Add avocado ci-fix (Azure#8907)

293054b

* Add avocado ci-fix

* update note

* swagger PR pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet