-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview #8951
Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview #8951
Conversation
This reverts commit e0889b2.
Azure Pipelines successfully started running 1 pipeline(s). |
This specification was reviewed earlier and ARM SignedOff in the PR branch - https://github.com/Azure/azure-rest-api-specs-pr/pull/908. Creating this pull request to merge into the public branch of azure api specs. |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
…rnetesConfiguration-2019-11-01-preview
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NarayanThiru , please address the comments, thanks.
specification/kubernetesconfiguration/resource-manager/readme.csharp.md
Outdated
Show resolved
Hide resolved
specification/kubernetesconfiguration/resource-manager/readme.csharp.md
Outdated
Show resolved
Hide resolved
specification/kubernetesconfiguration/resource-manager/readme.csharp.md
Outdated
Show resolved
Hide resolved
Deleting file added accidentally
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - APIs had been previously reviewed. Small delta of changes look fine.
specification/kubernetesconfiguration/resource-manager/readme.go.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NarayanThiru , the namespaces for different language are different, could you please follow the below sample to update namespaces: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/cosmos-db/resource-manager
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
I've addressed all the comments. Can this PR be merged? |
Hi @NarayanThiru would you please also change the namespace of python, typescript and ruby? I am not an expert on those, but they do not seems right to me, comparing with other services. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for pointing those out. I've updated the readme of ruby, python and typescript. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…1 01 preview (Azure#8951) * Add Microsoft.KubernetesConfiguration to azure api specs * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Revert "Add Microsoft.KubernetesConfiguration to azure api specs" This reverts commit e0889b2. * Add Microsoft.KubernetesConfiguration specification * PrettierCheck fixes * Remove unused example file * Delete settings.json Deleting file added accidentally * Address review comments * Update output-folder for go config * Mark Delete as Sync; and address review comment * Updated Delete example to remove 202 * Updated readme of ruby and python for namespace values * More updates for readme of ruby, python and typescript
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.