Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview #8951

NarayanThiru · 2020-04-06T06:17:19Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

This reverts commit e0889b2.

azure-pipelines · 2020-04-06T06:17:35Z

Azure Pipelines successfully started running 1 pipeline(s).

NarayanThiru · 2020-04-06T06:18:40Z

This specification was reviewed earlier and ARM SignedOff in the PR branch - https://github.com/Azure/azure-rest-api-specs-pr/pull/908. Creating this pull request to merge into the public branch of azure api specs.

openapi-sdkautomation · 2020-04-06T06:18:56Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-06T06:18:58Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from b290767 with merge commit 9c34dd7. SDK Automation 13.0.17.20200326.3
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-04-06T06:19:05Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b290767 with merge commit 9c34dd7. SDK Automation 13.0.17.20200326.3
️✔️preview/kubernetesconfiguration/mgmt/2019-11-01-preview [Logs] [Release SDK Changes]
- preview.kubernetesconfiguration.mgmt.2019-11-01-preview.zip

openapi-sdkautomation · 2020-04-06T06:19:10Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from b290767 with merge commit 9c34dd7. SDK Automation 13.0.17.20200326.3

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/__init__.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/_configuration.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/_source_control_configuration_client.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/models/__init__.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/models/_models.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/models/_source_control_configuration_client_enums.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/operations/_source_control_configurations_operations.py
/z/work/azure-sdk-for-python/sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/azure/mgmt/kubernetesconfiguration/version.py

openapi-sdkautomation · 2020-04-06T06:20:38Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b290767 with merge commit 9c34dd7. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-kubernetesconfiguration [Logs] [Release SDK Changes]

azure-arm-kubernetesconfiguration-1.0.0.tgz

[npmPack] npm WARN lifecycle @azure/[email protected]~prepack: cannot run in wd @azure/[email protected] npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/kubernetesconfiguration/arm-kubernetesconfiguration)

openapi-sdkautomation · 2020-04-06T06:21:30Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-04-06T06:40:33Z

Can one of the admins verify this patch?

…rnetesConfiguration-2019-11-01-preview

azure-pipelines · 2020-04-07T03:01:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-07T05:41:47Z

Azure Pipelines successfully started running 1 pipeline(s).

erich-wang

@NarayanThiru , please address the comments, thanks.

.vscode/settings.json

specification/kubernetesconfiguration/resource-manager/readme.csharp.md

Deleting file added accidentally

azure-pipelines · 2020-04-07T06:42:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-07T06:51:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-07T17:57:24Z

Azure Pipelines successfully started running 1 pipeline(s).

KrisBash

LGTM - APIs had been previously reviewed. Small delta of changes look fine.

specification/kubernetesconfiguration/resource-manager/readme.go.md

erich-wang

@NarayanThiru , the namespaces for different language are different, could you please follow the below sample to update namespaces: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/cosmos-db/resource-manager

azure-pipelines · 2020-04-08T22:22:40Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-08T22:41:36Z

Azure Pipelines successfully started running 1 pipeline(s).

NarayanThiru · 2020-04-09T00:05:59Z

I've addressed all the comments. Can this PR be merged?

ArcturusZhang · 2020-04-09T02:41:55Z

I've addressed all the comments. Can this PR be merged?

Hi @NarayanThiru would you please also change the namespace of python, typescript and ruby? I am not an expert on those, but they do not seems right to me, comparing with other services.
You can take these as examples:

azure-pipelines · 2020-04-09T05:14:51Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-04-09T05:30:38Z

Azure Pipelines successfully started running 1 pipeline(s).

NarayanThiru · 2020-04-09T05:31:14Z

Thanks for pointing those out. I've updated the readme of ruby, python and typescript.

ArcturusZhang

LGTM 👍

…1 01 preview (Azure#8951) * Add Microsoft.KubernetesConfiguration to azure api specs * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Revert "Add Microsoft.KubernetesConfiguration to azure api specs" This reverts commit e0889b2. * Add Microsoft.KubernetesConfiguration specification * PrettierCheck fixes * Remove unused example file * Delete settings.json Deleting file added accidentally * Address review comments * Update output-folder for go config * Mark Delete as Sync; and address review comment * Updated Delete example to remove 202 * Updated readme of ruby and python for namespace values * More updates for readme of ruby, python and typescript

NarayanThiru and others added 11 commits April 5, 2020 21:39

Add Microsoft.KubernetesConfiguration to azure api specs

e0889b2

New Readme Config File

81001fc

New Go Language Readme Config File

34418bd

New Typescript Language Readme Config File

97d45a0

New Python Language Readme Config File

121218e

New C# Language Readme Config File

7c91e5e

New Ruby Language Readme Config File

d8ff726

New Swagger Spec File

c6c6b81

New Swagger Example Spec File

50d505c

Revert "Add Microsoft.KubernetesConfiguration to azure api specs"

8771184

This reverts commit e0889b2.

Add Microsoft.KubernetesConfiguration specification

c2ffc24

openapi-assignment-bot bot assigned erich-wang Apr 6, 2020

NarayanThiru added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Apr 6, 2020

NarayanThiru added 2 commits April 6, 2020 19:27

Merge branch 'master' into dev-kubernetesconfiguration-Microsoft.Kube…

423140a

…rnetesConfiguration-2019-11-01-preview

PrettierCheck fixes

5a100dd

NarayanThiru removed the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Apr 7, 2020

Remove unused example file

0807c03

erich-wang suggested changes Apr 7, 2020

View reviewed changes

erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 7, 2020

Delete settings.json

e808642

Deleting file added accidentally

Address review comments

ad58b51

Update output-folder for go config

3c6c1ad

KrisBash approved these changes Apr 8, 2020

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 8, 2020

ArcturusZhang requested changes Apr 8, 2020

View reviewed changes

specification/kubernetesconfiguration/resource-manager/readme.go.md Outdated Show resolved Hide resolved

erich-wang suggested changes Apr 8, 2020

View reviewed changes

Mark Delete as Sync; and address review comment

3060345

Updated Delete example to remove 202

4a3a20b

Updated readme of ruby and python for namespace values

6aaf30d

More updates for readme of ruby, python and typescript

b290767

openapi-sdkautomation bot mentioned this pull request Apr 9, 2020

[AutoPR @azure/arm-kubernetesconfiguration] Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview AzureSDKAutomation/azure-sdk-for-js#1004

Closed

ArcturusZhang approved these changes Apr 9, 2020

View reviewed changes

erich-wang approved these changes Apr 9, 2020

View reviewed changes

erich-wang merged commit 9c34dd7 into Azure:master Apr 9, 2020

NarayanThiru mentioned this pull request Apr 10, 2020

[Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2019-11-01-preview #9006

Closed

2 tasks

ArcturusZhang mentioned this pull request Apr 24, 2020

Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview #9170

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview #8951

Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview #8951

NarayanThiru commented Apr 6, 2020 •

edited

Loading

azure-pipelines bot commented Apr 6, 2020

NarayanThiru commented Apr 6, 2020

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

azuresdkci commented Apr 6, 2020

azure-pipelines bot commented Apr 7, 2020

azure-pipelines bot commented Apr 7, 2020

erich-wang left a comment

azure-pipelines bot commented Apr 7, 2020

azure-pipelines bot commented Apr 7, 2020

azure-pipelines bot commented Apr 7, 2020

KrisBash left a comment

erich-wang left a comment

azure-pipelines bot commented Apr 8, 2020

azure-pipelines bot commented Apr 8, 2020

NarayanThiru commented Apr 9, 2020

ArcturusZhang commented Apr 9, 2020

azure-pipelines bot commented Apr 9, 2020

azure-pipelines bot commented Apr 9, 2020

NarayanThiru commented Apr 9, 2020

ArcturusZhang left a comment

Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview #8951

Dev kubernetesconfiguration microsoft.kubernetes configuration 2019 11 01 preview #8951

Conversation

NarayanThiru commented Apr 6, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Apr 6, 2020

NarayanThiru commented Apr 6, 2020

openapi-sdkautomation bot commented Apr 6, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Apr 6, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Apr 6, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Apr 6, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Apr 6, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Apr 6, 2020 • edited Loading

azure-sdk-for-net - Release

azuresdkci commented Apr 6, 2020

azure-pipelines bot commented Apr 7, 2020

azure-pipelines bot commented Apr 7, 2020

erich-wang left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Apr 7, 2020

azure-pipelines bot commented Apr 7, 2020

azure-pipelines bot commented Apr 7, 2020

KrisBash left a comment

Choose a reason for hiding this comment

erich-wang left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Apr 8, 2020

azure-pipelines bot commented Apr 8, 2020

NarayanThiru commented Apr 9, 2020

ArcturusZhang commented Apr 9, 2020

azure-pipelines bot commented Apr 9, 2020

azure-pipelines bot commented Apr 9, 2020

NarayanThiru commented Apr 9, 2020

ArcturusZhang left a comment

Choose a reason for hiding this comment

NarayanThiru commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 6, 2020 •

edited

Loading