Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Description for the DiffDiskPlacement property. #8964

Merged
merged 45 commits into from
Apr 10, 2020

Conversation

hari-bodicherla
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

…xamples where we are passing read only parameter in the request
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 7, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@yungezz
Copy link
Member

yungezz commented Apr 7, 2020

hi @hari-bodicherla is the PR ready to merge?

@hari-bodicherla hari-bodicherla added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 7, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hari-bodicherla hari-bodicherla removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 7, 2020
@hari-bodicherla
Copy link
Contributor Author

@yungezz I was waiting for resolving comments from Sameer. I just resolved the comments. please merge this PR if needed.

@hari-bodicherla hari-bodicherla added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 7, 2020
@hari-bodicherla
Copy link
Contributor Author

@yungezz , I got few more comments to resolve. I will let you know once it is ready to merge. Thanks.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hari-bodicherla
Copy link
Contributor Author

@smotwani , Updated the Swagger. Please have a look . Thanks

@hari-bodicherla hari-bodicherla removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 9, 2020
@hari-bodicherla
Copy link
Contributor Author

@yungezz . I just got approval from the reviewers. please merge this PR if you dont have any comments to add. Thanks

@yungezz yungezz merged commit 2b208cb into Azure:master Apr 10, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants