Monitor #8969
Merged
Monitor #8969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can one of the admins verify this patch? |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
This was referenced Apr 7, 2020
mmyyrroonn
reviewed
Apr 8, 2020
| @@ -15,6 +15,9 @@ | |||
| "consumes": [ | |||
| "application/json" | |||
| ], | |||
| "x-ms-code-generation-settings": { | |||
There was a problem hiding this comment.
this has been solved and can be removed.
There was a problem hiding this comment.
The title in readme is title: MonitorClient. Any reason why this need to be in json?
There was a problem hiding this comment.
not sure. But they should have same effect for autorest. We can remove this part since it has been added in the above lines in another PR.
There was a problem hiding this comment.
if remove this, then in python sdk, the client will be named as: MonitorClient, it will cause a breaking change
There was a problem hiding this comment.
Then why does this not causing change to other SDKs?
Should we just define another title: in readme inside yaml $(python) block to override the default one?
There was a problem hiding this comment.
i think it will also cause breaking change to other SDK as Fanqiu mentioned that c# also found this
and i am not sure whether it is reasonable to override it in readme inside $(python), i am not python code-gen, maybe zim is clear about this
|
Azure Pipelines successfully started running 1 pipeline(s). |
weidongxu-microsoft
approved these changes
Apr 8, 2020
|
I've approved it. Please take a look whether this is real or not. You can ping me if you want it merged. |
|
@weidongxu-microsoft Hi. I checked the breaking changes and they're expected breaking changes. @chenjianfei2017 @LianwMS If it's ok to you, we can merge this PR. @VeryEarly Please take a look as well. |
|
@chenjianfei2017 Hi. Looks like the python sdk is not correct. Could you please take a look or let someone in your team take a look? Looks like the fix is not working. We have two clients in the generated code right now. |
zikalino
approved these changes
Apr 8, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* revise readme.md for resourcegraph * revise for monitor * revert * Update readme.md * remove redundant settings Co-authored-by: MyronFanQiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.